From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C4A5DC4741F for ; Sat, 26 Sep 2020 15:46:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 848842177B for ; Sat, 26 Sep 2020 15:46:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1601135185; bh=TZhjmcr8VBb2HsuIr9PXLqYwy3YlpUkT+H7f/gykJlU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=QErg2y48eooXE1ZBS/VnAtP2nRyC3c9+ITRsSjvtAdefyQcdAf6U2zcB1OlqfYFn3 kFGirsTLMDgqqKhNZFta9kGh5Wjva+lnjW+1IyeT3pHcAuGC7avEGsa1B3EhjAqExd hGQhBQ/ChD6uQdjUFXCGm+kh8sPT/adzUr6ZcIAI= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729795AbgIZPqY (ORCPT ); Sat, 26 Sep 2020 11:46:24 -0400 Received: from mail.kernel.org ([198.145.29.99]:51714 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725208AbgIZPqY (ORCPT ); Sat, 26 Sep 2020 11:46:24 -0400 Received: from localhost (83-86-74-64.cable.dynamic.v4.ziggo.nl [83.86.74.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 5918121527; Sat, 26 Sep 2020 15:46:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1601135183; bh=TZhjmcr8VBb2HsuIr9PXLqYwy3YlpUkT+H7f/gykJlU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=e1KvFX/1u2YJrdGtkJLOLQwU13CcFwlP242OYfizkB3PUnttZrS9gkoO2LVQisLuz +Aq/MMM6CB7z1B+lAhYN0GzV+d7u6GzhN4cQ5NdFWdf6pFm/fSOWypsDZTvsMDqASB EvDg1yCUOihIIpJyhwMMYv8v5IeldatxQhC3hOPs= Date: Sat, 26 Sep 2020 17:46:35 +0200 From: Greg Kroah-Hartman To: Pavel Machek Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org, Kfir Itzhak , David Ahern , "David S. Miller" Subject: Re: [PATCH 4.19 23/37] ipv4: Update exception handling for multipath routes via same device Message-ID: <20200926154635.GA3347445@kroah.com> References: <20200925124720.972208530@linuxfoundation.org> <20200925124724.448531559@linuxfoundation.org> <20200925165134.GA7253@duo.ucw.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200925165134.GA7253@duo.ucw.cz> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Sep 25, 2020 at 06:51:34PM +0200, Pavel Machek wrote: > Hi! > > > [ Upstream commit 2fbc6e89b2f1403189e624cabaf73e189c5e50c6 ] > > > > Kfir reported that pmtu exceptions are not created properly for > > deployments where multipath routes use the same device. > > This is mismerged (in a way that does not affect functionality): > > > > @@ -779,6 +779,8 @@ static void __ip_do_redirect(struct rtab > > if (fib_lookup(net, fl4, &res, 0) == 0) { > > struct fib_nh *nh = &FIB_RES_NH(res); > > > > + fib_select_path(net, &res, fl4, skb); > > + nh = &FIB_RES_NH(res); > > update_or_create_fnhe(nh, fl4->daddr, new_gw, > > 0, false, > > nh is assigned value that is never used. Mainline patch removes the > assignment (but variable has different type). > > 4.19 should delete the assignment, too. Ah, good catch, I'll merge this in, thanks. greg k-h