* [PATCH] dpaa2-mac: Fix potential null pointer dereference
@ 2020-09-27 13:31 Alex Dewar
2020-09-27 13:59 ` Ioana Ciornei
0 siblings, 1 reply; 2+ messages in thread
From: Alex Dewar @ 2020-09-27 13:31 UTC (permalink / raw)
Cc: Alex Dewar, Ioana Ciornei, Ioana Radulescu, David S. Miller,
Jakub Kicinski, netdev, linux-kernel
In dpaa2_pcs_destroy, variable pcs is dereference before it is
null-checked. Fix this.
Addresses-Coverity: CID 1497159: Null pointer dereferences (REVERSE_INULL)
Signed-off-by: Alex Dewar <alex.dewar90@gmail.com>
---
drivers/net/ethernet/freescale/dpaa2/dpaa2-mac.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/freescale/dpaa2/dpaa2-mac.c b/drivers/net/ethernet/freescale/dpaa2/dpaa2-mac.c
index 6ff64dd1cf27..09bf4fec1172 100644
--- a/drivers/net/ethernet/freescale/dpaa2/dpaa2-mac.c
+++ b/drivers/net/ethernet/freescale/dpaa2/dpaa2-mac.c
@@ -291,11 +291,10 @@ static int dpaa2_pcs_create(struct dpaa2_mac *mac,
static void dpaa2_pcs_destroy(struct dpaa2_mac *mac)
{
struct lynx_pcs *pcs = mac->pcs;
- struct device *dev = &pcs->mdio->dev;
if (pcs) {
lynx_pcs_destroy(pcs);
- put_device(dev);
+ put_device(&pcs->mdio->dev);
mac->pcs = NULL;
}
}
--
2.28.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] dpaa2-mac: Fix potential null pointer dereference
2020-09-27 13:31 [PATCH] dpaa2-mac: Fix potential null pointer dereference Alex Dewar
@ 2020-09-27 13:59 ` Ioana Ciornei
0 siblings, 0 replies; 2+ messages in thread
From: Ioana Ciornei @ 2020-09-27 13:59 UTC (permalink / raw)
To: Alex Dewar
Cc: Ioana Ciocoi Radulescu, David S. Miller, Jakub Kicinski, netdev,
linux-kernel
On Sun, Sep 27, 2020 at 02:31:20PM +0100, Alex Dewar wrote:
> In dpaa2_pcs_destroy, variable pcs is dereference before it is
> null-checked. Fix this.
>
> Addresses-Coverity: CID 1497159: Null pointer dereferences (REVERSE_INULL)
> Signed-off-by: Alex Dewar <alex.dewar90@gmail.com>
> ---
> drivers/net/ethernet/freescale/dpaa2/dpaa2-mac.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/net/ethernet/freescale/dpaa2/dpaa2-mac.c b/drivers/net/ethernet/freescale/dpaa2/dpaa2-mac.c
> index 6ff64dd1cf27..09bf4fec1172 100644
> --- a/drivers/net/ethernet/freescale/dpaa2/dpaa2-mac.c
> +++ b/drivers/net/ethernet/freescale/dpaa2/dpaa2-mac.c
> @@ -291,11 +291,10 @@ static int dpaa2_pcs_create(struct dpaa2_mac *mac,
> static void dpaa2_pcs_destroy(struct dpaa2_mac *mac)
> {
> struct lynx_pcs *pcs = mac->pcs;
> - struct device *dev = &pcs->mdio->dev;
>
> if (pcs) {
> lynx_pcs_destroy(pcs);
> - put_device(dev);
> + put_device(&pcs->mdio->dev);
> mac->pcs = NULL;
> }
> }
This would introduce another problem because you would access an already
freed pcs. Maybe just move the declaration and initialization of dev
inside the if statement.
Thanks, Ioana
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-09-27 13:59 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-27 13:31 [PATCH] dpaa2-mac: Fix potential null pointer dereference Alex Dewar
2020-09-27 13:59 ` Ioana Ciornei
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.