From: Tang Bin <tangbin@cmss.chinamobile.com>
To: balbi@kernel.org, gregkh@linuxfoundation.org
Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
Tang Bin <tangbin@cmss.chinamobile.com>,
Zhang Shengju <zhangshengju@cmss.chinamobile.com>
Subject: [PATCH] usb: bdc: Remove duplicate error message in bdc_probe()
Date: Sun, 27 Sep 2020 21:42:18 +0800 [thread overview]
Message-ID: <20200927134218.20028-1-tangbin@cmss.chinamobile.com> (raw)
In this function, we don't need dev_err() message because
when something goes wrong, devm_platform_ioremap_resource()
can print an error message itself, so remove the redundant
one.
Signed-off-by: Zhang Shengju <zhangshengju@cmss.chinamobile.com>
Signed-off-by: Tang Bin <tangbin@cmss.chinamobile.com>
---
drivers/usb/gadget/udc/bdc/bdc_core.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/usb/gadget/udc/bdc/bdc_core.c b/drivers/usb/gadget/udc/bdc/bdc_core.c
index 02a3a7746..9454f179e 100644
--- a/drivers/usb/gadget/udc/bdc/bdc_core.c
+++ b/drivers/usb/gadget/udc/bdc/bdc_core.c
@@ -508,10 +508,8 @@ static int bdc_probe(struct platform_device *pdev)
bdc->clk = clk;
bdc->regs = devm_platform_ioremap_resource(pdev, 0);
- if (IS_ERR(bdc->regs)) {
- dev_err(dev, "ioremap error\n");
+ if (IS_ERR(bdc->regs))
return -ENOMEM;
- }
irq = platform_get_irq(pdev, 0);
if (irq < 0)
return irq;
--
2.20.1.windows.1
next reply other threads:[~2020-09-27 13:42 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-27 13:42 Tang Bin [this message]
2020-09-27 13:45 ` [PATCH] usb: bdc: Remove duplicate error message in bdc_probe() Greg KH
2020-09-28 8:45 ` Tang Bin
2020-09-28 9:40 ` Felipe Balbi
2020-09-28 10:55 ` Tang Bin
2020-09-28 11:23 ` Greg KH
2020-09-28 11:31 ` Tang Bin
2020-09-28 6:49 ` Chunfeng Yun
2020-09-28 8:40 ` Tang Bin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200927134218.20028-1-tangbin@cmss.chinamobile.com \
--to=tangbin@cmss.chinamobile.com \
--cc=balbi@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=zhangshengju@cmss.chinamobile.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.