All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kevin Wolf <kwolf@redhat.com>
To: Ying Fang <fangying1@huawei.com>
Cc: zhang.zhanghailiang@huawei.com, qemu-devel@nongnu.org, mreitz@redhat.com
Subject: Re: [RFC PATCH 0/7] block-backend: Introduce I/O hang
Date: Mon, 28 Sep 2020 12:57:11 +0200	[thread overview]
Message-ID: <20200928105711.GF5451@linux.fritz.box> (raw)
In-Reply-To: <20200927130420.1095-1-fangying1@huawei.com>

Am 27.09.2020 um 15:04 hat Ying Fang geschrieben:
> A VM in the cloud environment may use a virutal disk as the backend storage,
> and there are usually filesystems on the virtual block device. When backend
> storage is temporarily down, any I/O issued to the virtual block device will
> cause an error. For example, an error occurred in ext4 filesystem would make
> the filesystem readonly. However a cloud backend storage can be soon recovered.
> For example, an IP-SAN may be down due to network failure and will be online
> soon after network is recovered. The error in the filesystem may not be
> recovered unless a device reattach or system restart. So an I/O rehandle is
> in need to implement a self-healing mechanism.
> 
> This patch series propose a feature called I/O hang. It can rehandle AIOs
> with EIO error without sending error back to guest. From guest's perspective
> of view it is just like an IO is hanging and not returned. Guest can get
> back running smoothly when I/O is recovred with this feature enabled.

What is the problem with setting werror=stop and rerror=stop for the
device? Is it that QEMU won't automatically retry, but management tool
interaction is required to resume the guest?

I haven't checked your patches in detail yet, but implementing this
functionality in the backend means that blk_drain() will hang (or if it
doesn't hang, it doesn't do what it's supposed to do), making the whole
QEMU process unresponsive until the I/O succeeds again. Amongst others,
this would make it impossible to migrate away from a host with storage
problems.

Kevin



  parent reply	other threads:[~2020-09-28 10:59 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-27 13:04 [RFC PATCH 0/7] block-backend: Introduce I/O hang Ying Fang
2020-09-27 13:04 ` [RFC PATCH 1/7] block-backend: introduce I/O rehandle info Ying Fang
2020-09-27 13:04 ` [RFC PATCH 2/7] block-backend: rehandle block aios when EIO Ying Fang
2020-09-27 13:04 ` [RFC PATCH 3/7] block-backend: add I/O hang timeout Ying Fang
2020-09-27 13:04 ` [RFC PATCH 4/7] block-backend: add I/O hang drain when disbale Ying Fang
2020-09-28 15:09   ` Eric Blake
2020-09-27 13:04 ` [RFC PATCH 5/7] virtio-blk: disable I/O hang when resetting Ying Fang
2020-09-27 13:04 ` [RFC PATCH 6/7] qemu-option: add I/O hang timeout option Ying Fang
2020-09-27 13:04 ` [RFC PATCH 7/7] qapi: add I/O hang and I/O hang timeout qapi event Ying Fang
2020-09-27 13:27 ` [RFC PATCH 0/7] block-backend: Introduce I/O hang no-reply
2020-09-27 13:32 ` no-reply
2020-09-28 10:57 ` Kevin Wolf [this message]
2020-09-29  9:48   ` cenjiahui

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200928105711.GF5451@linux.fritz.box \
    --to=kwolf@redhat.com \
    --cc=fangying1@huawei.com \
    --cc=mreitz@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=zhang.zhanghailiang@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.