All of lore.kernel.org
 help / color / mirror / Atom feed
From: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
To: Bjorn Helgaas <helgaas@kernel.org>
Cc: Gustavo Pimentel <Gustavo.Pimentel@synopsys.com>,
	linux-pci@vger.kernel.org, bhelgaas@google.com,
	Joao Pinto <Joao.Pinto@synopsys.com>
Subject: Re: [PATCH] [-next] PCI: DWC: Fix cast truncates bits from constant value
Date: Mon, 28 Sep 2020 12:42:27 +0100	[thread overview]
Message-ID: <20200928114227.GB13256@e121166-lin.cambridge.arm.com> (raw)
In-Reply-To: <20200922165755.GA2211756@bjorn-Precision-5520>

On Tue, Sep 22, 2020 at 11:57:55AM -0500, Bjorn Helgaas wrote:
> [+cc Lorenzo]
> 
> On Tue, Sep 22, 2020 at 11:59:10AM +0200, Gustavo Pimentel wrote:
> > Fixes warning given by executing "make C=2 drivers/pci/"
> > 
> > Sparse output:
> > CHECK drivers/pci/controller/dwc/pcie-designware.c
> >  drivers/pci/controller/dwc/pcie-designware.c:432:52: warning:
> >  cast truncates bits from constant value (ffffffff7fffffff becomes
> >  7fffffff)
> > 
> > Reported-by: Bjorn Helgaas <bhelgaas@google.com>
> > Cc: Joao Pinto <jpinto@synopsys.com>
> > Signed-off-by: Gustavo Pimentel <gustavo.pimentel@synopsys.com>
> 
> Looks good to me; thanks for persevering with this.
> 
> Hopefully Lorenzo will apply this and, in the process, adjust the
> subject line to match the history:
> 
>   PCI: dwc: ...

Done, applied to pci/dwc, thanks.

Lorenzo

> >  drivers/pci/controller/dwc/pcie-designware.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/pci/controller/dwc/pcie-designware.c b/drivers/pci/controller/dwc/pcie-designware.c
> > index 3c3a4d1..e7a41d9 100644
> > --- a/drivers/pci/controller/dwc/pcie-designware.c
> > +++ b/drivers/pci/controller/dwc/pcie-designware.c
> > @@ -429,7 +429,7 @@ void dw_pcie_disable_atu(struct dw_pcie *pci, int index,
> >  	}
> >  
> >  	dw_pcie_writel_dbi(pci, PCIE_ATU_VIEWPORT, region | index);
> > -	dw_pcie_writel_dbi(pci, PCIE_ATU_CR2, (u32)~PCIE_ATU_ENABLE);
> > +	dw_pcie_writel_dbi(pci, PCIE_ATU_CR2, ~(u32)PCIE_ATU_ENABLE);
> >  }
> >  
> >  int dw_pcie_wait_for_link(struct dw_pcie *pci)
> > -- 
> > 2.7.4
> > 

  reply	other threads:[~2020-09-28 11:42 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-22  9:59 [PATCH] [-next] PCI: DWC: Fix cast truncates bits from constant value Gustavo Pimentel
2020-09-22 16:57 ` Bjorn Helgaas
2020-09-28 11:42   ` Lorenzo Pieralisi [this message]
  -- strict thread matches above, loose matches on Subject: below --
2020-09-17 21:28 Gustavo Pimentel
2020-09-17 21:47 ` Bjorn Helgaas
2020-09-18  7:15   ` Gustavo Pimentel
2020-09-21 11:30     ` Gustavo Pimentel
2020-09-21 16:36       ` Bjorn Helgaas
2020-09-22  9:57         ` Gustavo Pimentel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200928114227.GB13256@e121166-lin.cambridge.arm.com \
    --to=lorenzo.pieralisi@arm.com \
    --cc=Gustavo.Pimentel@synopsys.com \
    --cc=Joao.Pinto@synopsys.com \
    --cc=bhelgaas@google.com \
    --cc=helgaas@kernel.org \
    --cc=linux-pci@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.