All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stephen Hemminger <stephen@networkplumber.org>
To: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>
Cc: dev@dpdk.org, phil.yang@arm.com, jgrajcia@cisco.com,
	ferruh.yigit@intel.com, nd@arm.com, stable@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v2 1/8] net/memif: do not update local copy of tail in tx function
Date: Mon, 28 Sep 2020 13:53:53 -0700	[thread overview]
Message-ID: <20200928135353.774a805f@hermes.local> (raw)
In-Reply-To: <20200928190334.40624-1-honnappa.nagarahalli@arm.com>

On Mon, 28 Sep 2020 14:03:27 -0500
Honnappa Nagarahalli <honnappa.nagarahalli@arm.com> wrote:

> In the case of S2M queues, the receiver synchronizes with the sender
> (i.e. informs of the packets it has received) using ring->tail.
> Hence, the sender does not need to update last_tail.
> 
> In the case of M2S queues, the receiver uses last_tail to
> keep track of the descriptors it has received. The
> sender is not required to update the last_tail. Updating
> the last_tail makes it a shared variable between the
> transmitter and receiver affecting the performance.
> 
> Fixes: 09c7e63a71f9 ("net/memif: introduce memory interface PMD")
> Cc: jgrajcia@cisco.com
> Cc: stable@dpdk.org
> 
> Signed-off-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>
> Reviewed-by: Phil Yang <phil.yang@arm.com>
> Reviewed-by: Ruifeng Wang <ruifeng.wang@arm.com>

This patch series will conflict with the pending master/slave patchset.
Please let the master/slave renaming go in first.

  parent reply	other threads:[~2020-09-28 20:54 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-21 19:22 [dpdk-dev] [PATCH 1/4] net/memif: do not update local copy of tail in tx function Honnappa Nagarahalli
2020-09-21 19:22 ` [dpdk-dev] [PATCH 2/4] net/memif: relax the load of ring tail pointer for M2S ring Honnappa Nagarahalli
2020-09-21 19:22 ` [dpdk-dev] [PATCH 3/4] net/memif: relax the load of ring head pointer for S2M ring Honnappa Nagarahalli
2020-09-21 19:22 ` [dpdk-dev] [PATCH 4/4] net/memif: relax the load of ring head pointer for M2S ring Honnappa Nagarahalli
2020-09-28 19:03 ` [dpdk-dev] [PATCH v2 1/8] net/memif: do not update local copy of tail in tx function Honnappa Nagarahalli
2020-09-28 19:03   ` [dpdk-dev] [PATCH v2 2/8] net/memif: relax the load of ring tail pointer for M2S ring Honnappa Nagarahalli
2020-09-28 19:03   ` [dpdk-dev] [PATCH v2 3/8] net/memif: relax the load of ring head " Honnappa Nagarahalli
2020-09-28 19:03   ` [dpdk-dev] [PATCH v2 4/8] net/memif: relax the load of ring head pointer for S2M ring Honnappa Nagarahalli
2020-09-28 19:03   ` [dpdk-dev] [PATCH v2 5/8] net/memif: relax the load of ring head pointer for M2S zc ring Honnappa Nagarahalli
2020-09-28 19:03   ` [dpdk-dev] [PATCH v2 6/8] net/memif: remove extra check Honnappa Nagarahalli
2020-09-28 19:03   ` [dpdk-dev] [PATCH v2 7/8] net/memif: relax the load of ring head pointer for S2M zc ring Honnappa Nagarahalli
2020-09-28 19:03   ` [dpdk-dev] [PATCH v2 8/8] net/memif: move the barrier outside the loop Honnappa Nagarahalli
2020-09-28 20:53   ` Stephen Hemminger [this message]
2020-09-29  5:24     ` [dpdk-dev] [PATCH v2 1/8] net/memif: do not update local copy of tail in tx function Honnappa Nagarahalli
2020-10-07 17:08   ` Honnappa Nagarahalli
2020-10-09 11:23     ` Jakub Grajciar -X (jgrajcia - PANTHEON TECH SRO at Cisco)
2020-10-09 15:59       ` Ferruh Yigit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200928135353.774a805f@hermes.local \
    --to=stephen@networkplumber.org \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    --cc=honnappa.nagarahalli@arm.com \
    --cc=jgrajcia@cisco.com \
    --cc=nd@arm.com \
    --cc=phil.yang@arm.com \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.