From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B7541C2D0A8 for ; Mon, 28 Sep 2020 23:55:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 70E1520825 for ; Mon, 28 Sep 2020 23:55:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1601337336; bh=ZFEod8yQOVrkBo8ei/0ZNHsZ2G5wacEFDAQREbQ1Mrc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=VEgZO7lji/04yF+KFuq5PbOrQFdrcj3zd6IPoun26FuREcsks9lVm6Q/CAmuMHm+X w4OppZ2mMq01Uvwu4lQr3Iy9rvFEPUZuhb2Z/opts8UCZTIa/VIkXJdsJLMH9heWye om+Pn9TMK58i6josj+u0QQhcMMAjhv2iaW+F4r1w= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727174AbgI1Xzc (ORCPT ); Mon, 28 Sep 2020 19:55:32 -0400 Received: from mail.kernel.org ([198.145.29.99]:51778 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726952AbgI1Xzc (ORCPT ); Mon, 28 Sep 2020 19:55:32 -0400 Received: from localhost (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 947A82193E; Mon, 28 Sep 2020 22:00:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1601330426; bh=ZFEod8yQOVrkBo8ei/0ZNHsZ2G5wacEFDAQREbQ1Mrc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=gJLQq3XgRmcaXVK+sZq+JIMO4IOEauGmH4HgF2Sa6Btp9+3h4CDacN1VCnp/tPJMz DUmXdPyhHucWge65pwMg1pegZv6ltXZdy1x3aZox7MFn9fTY83MkimhlRgaCHfFpds LDiJd1X2alw+WM3v7lVlQJ1Xidohk/r8SnkeGMZ0= Date: Mon, 28 Sep 2020 18:00:25 -0400 From: Sasha Levin To: Naresh Kamboju Cc: open list , linux- stable , Raviteja Narayanam , Shubhrajyoti Datta , Greg Kroah-Hartman , linux-serial@vger.kernel.org, Linux ARM Subject: Re: [PATCH AUTOSEL 4.4 42/64] serial: uartps: Wait for tx_empty in console setup Message-ID: <20200928220025.GD2219727@sasha-vm> References: <20200918021643.2067895-1-sashal@kernel.org> <20200918021643.2067895-42-sashal@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Sep 29, 2020 at 01:46:59AM +0530, Naresh Kamboju wrote: >On Fri, 18 Sep 2020 at 07:51, Sasha Levin wrote: >> >> From: Raviteja Narayanam >> >> [ Upstream commit 42e11948ddf68b9f799cad8c0ddeab0a39da33e8 ] >> >> On some platforms, the log is corrupted while console is being >> registered. It is observed that when set_termios is called, there >> are still some bytes in the FIFO to be transmitted. >> >> So, wait for tx_empty inside cdns_uart_console_setup before calling >> set_termios. >> >> Signed-off-by: Raviteja Narayanam >> Reviewed-by: Shubhrajyoti Datta >> Link: https://lore.kernel.org/r/1586413563-29125-2-git-send-email-raviteja.narayanam@xilinx.com >> Signed-off-by: Greg Kroah-Hartman >> Signed-off-by: Sasha Levin > >stable rc branch 4.4 arm64 build broken. > >../drivers/tty/serial/xilinx_uartps.c: In function ‘cdns_uart_console_setup’: >../drivers/tty/serial/xilinx_uartps.c:1170:40: error: ‘TX_TIMEOUT’ >undeclared (first use in this function) > 1170 | time_out = jiffies + usecs_to_jiffies(TX_TIMEOUT); > ^~~~~~~~~~ >Reported-by: Naresh Kamboju Dropped, thanks! -- Thanks, Sasha From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0A718C2D0A8 for ; Mon, 28 Sep 2020 22:01:48 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A50DA221E7 for ; Mon, 28 Sep 2020 22:01:47 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="i3i8fNJO"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="gJLQq3Xg" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A50DA221E7 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=8T9//DXif4eciLQ/Z+NJsCNwbholxMMFZtfPfWkHHhE=; b=i3i8fNJO8J6O7JzEiCZ01uDHb MuWoFXoTei3FFIM0aNs1LWHpCdQZjcU94WeAa3pnjwGQ+Yet8uDUzQSZF6jJtI6qVYIdMV+D4Gii/ qcw1IaiNA5AqKhiSWR0CZT1UQdRTvJWIOHZ+hqsCeldF5zK4EnqriP6pnd6ZGPSAGF3Jf7uWt3hUd Hsgvz2HIo8wl4BX+UDVIL+IGi6Dx4kYrmDMLquBQhmg//n/aTXAs+C1UH/Tyi+xvUwH8PnhQ2WzAI 9/TZfaG5+/wBCisBN/EQ3pjpfAMpNjQPBZrGe6v2k/5iO/WgKmHD92W5XzkL8GMGE4NJFSfw6HkQA EGlwr0KUA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kN1CA-00010t-Lp; Mon, 28 Sep 2020 22:00:30 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kN1C8-00010T-66 for linux-arm-kernel@lists.infradead.org; Mon, 28 Sep 2020 22:00:29 +0000 Received: from localhost (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 947A82193E; Mon, 28 Sep 2020 22:00:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1601330426; bh=ZFEod8yQOVrkBo8ei/0ZNHsZ2G5wacEFDAQREbQ1Mrc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=gJLQq3XgRmcaXVK+sZq+JIMO4IOEauGmH4HgF2Sa6Btp9+3h4CDacN1VCnp/tPJMz DUmXdPyhHucWge65pwMg1pegZv6ltXZdy1x3aZox7MFn9fTY83MkimhlRgaCHfFpds LDiJd1X2alw+WM3v7lVlQJ1Xidohk/r8SnkeGMZ0= Date: Mon, 28 Sep 2020 18:00:25 -0400 From: Sasha Levin To: Naresh Kamboju Subject: Re: [PATCH AUTOSEL 4.4 42/64] serial: uartps: Wait for tx_empty in console setup Message-ID: <20200928220025.GD2219727@sasha-vm> References: <20200918021643.2067895-1-sashal@kernel.org> <20200918021643.2067895-42-sashal@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200928_180028_292366_22E3341F X-CRM114-Status: GOOD ( 14.78 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Raviteja Narayanam , Greg Kroah-Hartman , Shubhrajyoti Datta , open list , linux- stable , linux-serial@vger.kernel.org, Linux ARM Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gVHVlLCBTZXAgMjksIDIwMjAgYXQgMDE6NDY6NTlBTSArMDUzMCwgTmFyZXNoIEthbWJvanUg d3JvdGU6Cj5PbiBGcmksIDE4IFNlcCAyMDIwIGF0IDA3OjUxLCBTYXNoYSBMZXZpbiA8c2FzaGFs QGtlcm5lbC5vcmc+IHdyb3RlOgo+Pgo+PiBGcm9tOiBSYXZpdGVqYSBOYXJheWFuYW0gPHJhdml0 ZWphLm5hcmF5YW5hbUB4aWxpbnguY29tPgo+Pgo+PiBbIFVwc3RyZWFtIGNvbW1pdCA0MmUxMTk0 OGRkZjY4YjlmNzk5Y2FkOGMwZGRlYWIwYTM5ZGEzM2U4IF0KPj4KPj4gT24gc29tZSBwbGF0Zm9y bXMsIHRoZSBsb2cgaXMgY29ycnVwdGVkIHdoaWxlIGNvbnNvbGUgaXMgYmVpbmcKPj4gcmVnaXN0 ZXJlZC4gSXQgaXMgb2JzZXJ2ZWQgdGhhdCB3aGVuIHNldF90ZXJtaW9zIGlzIGNhbGxlZCwgdGhl cmUKPj4gYXJlIHN0aWxsIHNvbWUgYnl0ZXMgaW4gdGhlIEZJRk8gdG8gYmUgdHJhbnNtaXR0ZWQu Cj4+Cj4+IFNvLCB3YWl0IGZvciB0eF9lbXB0eSBpbnNpZGUgY2Ruc191YXJ0X2NvbnNvbGVfc2V0 dXAgYmVmb3JlIGNhbGxpbmcKPj4gc2V0X3Rlcm1pb3MuCj4+Cj4+IFNpZ25lZC1vZmYtYnk6IFJh dml0ZWphIE5hcmF5YW5hbSA8cmF2aXRlamEubmFyYXlhbmFtQHhpbGlueC5jb20+Cj4+IFJldmll d2VkLWJ5OiBTaHViaHJhanlvdGkgRGF0dGEgPHNodWJocmFqeW90aS5kYXR0YUB4aWxpbnguY29t Pgo+PiBMaW5rOiBodHRwczovL2xvcmUua2VybmVsLm9yZy9yLzE1ODY0MTM1NjMtMjkxMjUtMi1n aXQtc2VuZC1lbWFpbC1yYXZpdGVqYS5uYXJheWFuYW1AeGlsaW54LmNvbQo+PiBTaWduZWQtb2Zm LWJ5OiBHcmVnIEtyb2FoLUhhcnRtYW4gPGdyZWdraEBsaW51eGZvdW5kYXRpb24ub3JnPgo+PiBT aWduZWQtb2ZmLWJ5OiBTYXNoYSBMZXZpbiA8c2FzaGFsQGtlcm5lbC5vcmc+Cj4KPnN0YWJsZSBy YyBicmFuY2ggNC40IGFybTY0IGJ1aWxkIGJyb2tlbi4KPgo+Li4vZHJpdmVycy90dHkvc2VyaWFs L3hpbGlueF91YXJ0cHMuYzogSW4gZnVuY3Rpb24g4oCYY2Ruc191YXJ0X2NvbnNvbGVfc2V0dXDi gJk6Cj4uLi9kcml2ZXJzL3R0eS9zZXJpYWwveGlsaW54X3VhcnRwcy5jOjExNzA6NDA6IGVycm9y OiDigJhUWF9USU1FT1VU4oCZCj51bmRlY2xhcmVkIChmaXJzdCB1c2UgaW4gdGhpcyBmdW5jdGlv bikKPiAxMTcwIHwgIHRpbWVfb3V0ID0gamlmZmllcyArIHVzZWNzX3RvX2ppZmZpZXMoVFhfVElN RU9VVCk7Cj4gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgXn5+fn5+fn5+fgo+UmVwb3J0ZWQtYnk6IE5hcmVzaCBLYW1i b2p1IDxuYXJlc2gua2FtYm9qdUBsaW5hcm8ub3JnPgoKRHJvcHBlZCwgdGhhbmtzIQoKLS0gClRo YW5rcywKU2FzaGEKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fCmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFybS1rZXJuZWxAbGlzdHMu aW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZv L2xpbnV4LWFybS1rZXJuZWwK