From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BBFA8C2D0A8 for ; Mon, 28 Sep 2020 23:15:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8CF2623A5A for ; Mon, 28 Sep 2020 23:15:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727340AbgI1XPY (ORCPT ); Mon, 28 Sep 2020 19:15:24 -0400 Received: from mga01.intel.com ([192.55.52.88]:30710 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727251AbgI1XOq (ORCPT ); Mon, 28 Sep 2020 19:14:46 -0400 IronPort-SDR: eayjO9fC1DYqjeGB8m/ntb/tH1UZk5ZyOZErM4Q288iXryDCshcNFobk4ox07iQsoYWPULLHCb OG1ORKdmDmZQ== X-IronPort-AV: E=McAfee;i="6000,8403,9758"; a="180234029" X-IronPort-AV: E=Sophos;i="5.77,315,1596524400"; d="scan'208";a="180234029" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Sep 2020 16:07:40 -0700 IronPort-SDR: 9XkV9aLbK1uAODE88byKKp4MRaliHvhMU2hA+PTmt3T8XPM+w0ywCelOZNty1UJdqIhZAm4dv8 RTFYnpFF8n1g== X-IronPort-AV: E=Sophos;i="5.77,315,1596524400"; d="scan'208";a="340597549" Received: from pchilaka-mobl.amr.corp.intel.com (HELO ldmartin-desk1) ([10.212.247.146]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Sep 2020 16:07:39 -0700 Date: Mon, 28 Sep 2020 16:07:39 -0700 From: Lucas De Marchi To: Jani Nikula Cc: "Surendrakumar Upadhyay, TejaskumarX" , "Vivi, Rodrigo" , "airlied@linux.ie" , "daniel@ffwll.ch" , "intel-gfx@lists.freedesktop.org" , "dri-devel@lists.freedesktop.org" , "linux-kernel@vger.kernel.org" , "Ausmus, James" , "Roper, Matthew D" , "Souza, Jose" , "ville.syrjala@linux.intel.com" , "Pandey, Hariom" Subject: Re: [Intel-gfx] [PATCH 2/2] drm/i915/edp/jsl: Update vswing table for HBR and HBR2 Message-ID: <20200928230739.vpj22bwebqhtehuk@ldmartin-desk1> References: <20200928080931.246347-1-tejaskumarx.surendrakumar.upadhyay@intel.com> <20200928080931.246347-3-tejaskumarx.surendrakumar.upadhyay@intel.com> <87a6xaow40.fsf@intel.com> <871rilq0um.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <871rilq0um.fsf@intel.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Sep 28, 2020 at 08:15:29PM +0300, Jani Nikula wrote: >On Mon, 28 Sep 2020, "Surendrakumar Upadhyay, TejaskumarX" wrote: >> This is a good example of a potential trap that having >> IS_ELKHARTLAKE() cover both ELK and JSP creates. An unsuspecting coder >> might change the if ladder to have IS_ELKHARTLAKE() first, and the >> subsequent IS_JASPERLAKE() branch would never be taken. >> >> BR, >> Jani. >> >> Tejas : In that case I will put attention note in comment about >> platform checks such that ladder distrubance can be avoided. What you >> suggest? >The solution is to make IS_ELKHARTLAKE() mean ELK and only ELK. Since we are talking about the TLA for JSL in the other patch, for elkhartlake it is EHL, not ELK. ELK is something else, but I'm not sure what: $ git grep -w ELK -- drivers/gpu/drm/ drivers/gpu/drm/i915/gem/i915_gem_stolen.c: IS_GM45(i915) ? "CTG" : "ELK", reg_val); drivers/gpu/drm/i915/gem/i915_gem_stolen.c: * Whether ILK really reuses the ELK register for this is unclear. drivers/gpu/drm/i915/intel_pm.c: * Not 100% sure which way ELK should go here as the drivers/gpu/drm/i915/intel_pm.c: * assume ELK doesn't need this. Lucas De Marchi > >BR, >Jani. > > >-- >Jani Nikula, Intel Open Source Graphics Center From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E04C7C2D0A8 for ; Mon, 28 Sep 2020 23:07:44 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8CFBC23A58 for ; Mon, 28 Sep 2020 23:07:44 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8CFBC23A58 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 849B36E160; Mon, 28 Sep 2020 23:07:42 +0000 (UTC) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by gabe.freedesktop.org (Postfix) with ESMTPS id C6F3D89F01; Mon, 28 Sep 2020 23:07:40 +0000 (UTC) IronPort-SDR: L3UR5RZVDDQItRY9zY30xuOeQ23DHmrFeRacRmOCQ+f8xUwRc/89wZypBjwy/28KQshz3vSLQR C3pE+klsiOVA== X-IronPort-AV: E=McAfee;i="6000,8403,9758"; a="246817677" X-IronPort-AV: E=Sophos;i="5.77,315,1596524400"; d="scan'208";a="246817677" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Sep 2020 16:07:40 -0700 IronPort-SDR: 9XkV9aLbK1uAODE88byKKp4MRaliHvhMU2hA+PTmt3T8XPM+w0ywCelOZNty1UJdqIhZAm4dv8 RTFYnpFF8n1g== X-IronPort-AV: E=Sophos;i="5.77,315,1596524400"; d="scan'208";a="340597549" Received: from pchilaka-mobl.amr.corp.intel.com (HELO ldmartin-desk1) ([10.212.247.146]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Sep 2020 16:07:39 -0700 Date: Mon, 28 Sep 2020 16:07:39 -0700 From: Lucas De Marchi To: Jani Nikula Subject: Re: [Intel-gfx] [PATCH 2/2] drm/i915/edp/jsl: Update vswing table for HBR and HBR2 Message-ID: <20200928230739.vpj22bwebqhtehuk@ldmartin-desk1> References: <20200928080931.246347-1-tejaskumarx.surendrakumar.upadhyay@intel.com> <20200928080931.246347-3-tejaskumarx.surendrakumar.upadhyay@intel.com> <87a6xaow40.fsf@intel.com> <871rilq0um.fsf@intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <871rilq0um.fsf@intel.com> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "Pandey, Hariom" , "Ausmus, James" , "airlied@linux.ie" , "intel-gfx@lists.freedesktop.org" , "linux-kernel@vger.kernel.org" , "dri-devel@lists.freedesktop.org" , "Souza, Jose" , "Vivi, Rodrigo" , "Surendrakumar Upadhyay, TejaskumarX" Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Mon, Sep 28, 2020 at 08:15:29PM +0300, Jani Nikula wrote: >On Mon, 28 Sep 2020, "Surendrakumar Upadhyay, TejaskumarX" wrote: >> This is a good example of a potential trap that having >> IS_ELKHARTLAKE() cover both ELK and JSP creates. An unsuspecting coder >> might change the if ladder to have IS_ELKHARTLAKE() first, and the >> subsequent IS_JASPERLAKE() branch would never be taken. >> >> BR, >> Jani. >> >> Tejas : In that case I will put attention note in comment about >> platform checks such that ladder distrubance can be avoided. What you >> suggest? >The solution is to make IS_ELKHARTLAKE() mean ELK and only ELK. Since we are talking about the TLA for JSL in the other patch, for elkhartlake it is EHL, not ELK. ELK is something else, but I'm not sure what: $ git grep -w ELK -- drivers/gpu/drm/ drivers/gpu/drm/i915/gem/i915_gem_stolen.c: IS_GM45(i915) ? "CTG" : "ELK", reg_val); drivers/gpu/drm/i915/gem/i915_gem_stolen.c: * Whether ILK really reuses the ELK register for this is unclear. drivers/gpu/drm/i915/intel_pm.c: * Not 100% sure which way ELK should go here as the drivers/gpu/drm/i915/intel_pm.c: * assume ELK doesn't need this. Lucas De Marchi > >BR, >Jani. > > >-- >Jani Nikula, Intel Open Source Graphics Center _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D5F0CC2D0A8 for ; Mon, 28 Sep 2020 23:07:42 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7639C23A58 for ; Mon, 28 Sep 2020 23:07:42 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7639C23A58 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id E575889F01; Mon, 28 Sep 2020 23:07:41 +0000 (UTC) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by gabe.freedesktop.org (Postfix) with ESMTPS id C6F3D89F01; Mon, 28 Sep 2020 23:07:40 +0000 (UTC) IronPort-SDR: L3UR5RZVDDQItRY9zY30xuOeQ23DHmrFeRacRmOCQ+f8xUwRc/89wZypBjwy/28KQshz3vSLQR C3pE+klsiOVA== X-IronPort-AV: E=McAfee;i="6000,8403,9758"; a="246817677" X-IronPort-AV: E=Sophos;i="5.77,315,1596524400"; d="scan'208";a="246817677" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Sep 2020 16:07:40 -0700 IronPort-SDR: 9XkV9aLbK1uAODE88byKKp4MRaliHvhMU2hA+PTmt3T8XPM+w0ywCelOZNty1UJdqIhZAm4dv8 RTFYnpFF8n1g== X-IronPort-AV: E=Sophos;i="5.77,315,1596524400"; d="scan'208";a="340597549" Received: from pchilaka-mobl.amr.corp.intel.com (HELO ldmartin-desk1) ([10.212.247.146]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Sep 2020 16:07:39 -0700 Date: Mon, 28 Sep 2020 16:07:39 -0700 From: Lucas De Marchi To: Jani Nikula Message-ID: <20200928230739.vpj22bwebqhtehuk@ldmartin-desk1> References: <20200928080931.246347-1-tejaskumarx.surendrakumar.upadhyay@intel.com> <20200928080931.246347-3-tejaskumarx.surendrakumar.upadhyay@intel.com> <87a6xaow40.fsf@intel.com> <871rilq0um.fsf@intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <871rilq0um.fsf@intel.com> Subject: Re: [Intel-gfx] [PATCH 2/2] drm/i915/edp/jsl: Update vswing table for HBR and HBR2 X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "Pandey, Hariom" , "airlied@linux.ie" , "intel-gfx@lists.freedesktop.org" , "linux-kernel@vger.kernel.org" , "dri-devel@lists.freedesktop.org" Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Mon, Sep 28, 2020 at 08:15:29PM +0300, Jani Nikula wrote: >On Mon, 28 Sep 2020, "Surendrakumar Upadhyay, TejaskumarX" wrote: >> This is a good example of a potential trap that having >> IS_ELKHARTLAKE() cover both ELK and JSP creates. An unsuspecting coder >> might change the if ladder to have IS_ELKHARTLAKE() first, and the >> subsequent IS_JASPERLAKE() branch would never be taken. >> >> BR, >> Jani. >> >> Tejas : In that case I will put attention note in comment about >> platform checks such that ladder distrubance can be avoided. What you >> suggest? >The solution is to make IS_ELKHARTLAKE() mean ELK and only ELK. Since we are talking about the TLA for JSL in the other patch, for elkhartlake it is EHL, not ELK. ELK is something else, but I'm not sure what: $ git grep -w ELK -- drivers/gpu/drm/ drivers/gpu/drm/i915/gem/i915_gem_stolen.c: IS_GM45(i915) ? "CTG" : "ELK", reg_val); drivers/gpu/drm/i915/gem/i915_gem_stolen.c: * Whether ILK really reuses the ELK register for this is unclear. drivers/gpu/drm/i915/intel_pm.c: * Not 100% sure which way ELK should go here as the drivers/gpu/drm/i915/intel_pm.c: * assume ELK doesn't need this. Lucas De Marchi > >BR, >Jani. > > >-- >Jani Nikula, Intel Open Source Graphics Center _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx