From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:mime-version:content-disposition :user-agent; bh=vsIVZIZnHn3jRliLAeQtxD7Mqf2HRE4KmLHVTVrukAA=; b=lsiEhPxdmXtpKUMGQ+atIe5fNBVAfYezaSa9NRHx2SV3+6bkbJ76VGA58ril/UW0ei HM8h0HTt36iRSe3LodqaITeFsq9kdc7hvs3ueRalQnFunz9AEiqxtP+rACOUQ0YuBANh 71vt4yRK26ivo/3biAxvEvGY8A4+9BjX1NsD9LSopoff+n1jAmw2Z4qeOtC09W5+55Sp GKjnqHosR8jkPVcdsNDmzZME30yB8eOZHMUI9F39BhUeCeVCozIhZ7NCozlB3rkW7jnD AcDPofS86mY0k914xuVZ59faE0KvcXzkJjqHrdDSWlIXWIMzSoBnA1DgLXLSTzqmKMLR rZlw== Date: Tue, 29 Sep 2020 16:35:18 +0800 From: Junchang Wang Subject: [PATCH] api-gcc.h: fix typos in the functions atomic_add_* Message-ID: <20200929083518.GA30685@HongKong.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline To: paulmck@kernel.org Cc: perfbook@vger.kernel.org List-ID: The typo in atomic_add_return() incurs tricky bugs. For example, the current atomic_dec_return() is indeed an atomic_add_return(). A similar typo appears in the function atomic_add_negative(). Signed-off-by: Junchang Wang --- CodeSamples/api-pthreads/api-gcc.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/CodeSamples/api-pthreads/api-gcc.h b/CodeSamples/api-pthreads/api-gcc.h index fbbedf2..9ad8a68 100644 --- a/CodeSamples/api-pthreads/api-gcc.h +++ b/CodeSamples/api-pthreads/api-gcc.h @@ -140,7 +140,7 @@ static __inline__ int atomic_inc_and_test(atomic_t *v) */ static __inline__ int atomic_add_negative(int i, atomic_t *v) { - return __atomic_add_fetch(&v->counter, 1, __ATOMIC_SEQ_CST) < 0; + return __atomic_add_fetch(&v->counter, i, __ATOMIC_SEQ_CST) < 0; } /** @@ -152,7 +152,7 @@ static __inline__ int atomic_add_negative(int i, atomic_t *v) */ static __inline__ int atomic_add_return(int i, atomic_t *v) { - return __atomic_add_fetch(&v->counter, 1, __ATOMIC_SEQ_CST); + return __atomic_add_fetch(&v->counter, i, __ATOMIC_SEQ_CST); } static __inline__ int atomic_sub_return(int i, atomic_t *v) -- 2.7.4