From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C5E8CC4727C for ; Tue, 29 Sep 2020 09:15:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 78A2820848 for ; Tue, 29 Sep 2020 09:15:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727995AbgI2JPY (ORCPT ); Tue, 29 Sep 2020 05:15:24 -0400 Received: from mga06.intel.com ([134.134.136.31]:58538 "EHLO mga06.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727775AbgI2JPX (ORCPT ); Tue, 29 Sep 2020 05:15:23 -0400 IronPort-SDR: IX01F1jy1GOnq/4T/3a5iNUaN3FWKeaN2ynQy5FHh+Cd9Bc2M2CoolrsAtdIzyYj7E44MS3+Y5 LYtIsCY+W5GQ== X-IronPort-AV: E=McAfee;i="6000,8403,9758"; a="223738816" X-IronPort-AV: E=Sophos;i="5.77,317,1596524400"; d="scan'208";a="223738816" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Sep 2020 02:15:18 -0700 IronPort-SDR: 0DB0T6vhXOkGZh9FzgEDSSxLocytoEZPSXi5+vus9vfvea4Ft7NqXUZj4b0+bPNTsyCID90FCT V2TKn+XagUmQ== X-IronPort-AV: E=Sophos;i="5.77,317,1596524400"; d="scan'208";a="489430265" Received: from paasikivi.fi.intel.com ([10.237.72.42]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Sep 2020 02:15:14 -0700 Received: by paasikivi.fi.intel.com (Postfix, from userid 1000) id 42740204FD; Tue, 29 Sep 2020 12:15:12 +0300 (EEST) Date: Tue, 29 Sep 2020 12:15:12 +0300 From: Sakari Ailus To: Krzysztof Kozlowski Cc: Mauro Carvalho Chehab , Rob Herring , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4 1/4] dt-bindings: media: imx258: add bindings for IMX258 sensor Message-ID: <20200929091512.GF26842@paasikivi.fi.intel.com> References: <20200923152129.21736-1-krzk@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200923152129.21736-1-krzk@kernel.org> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Krzysztof, On Wed, Sep 23, 2020 at 05:21:26PM +0200, Krzysztof Kozlowski wrote: > Add bindings for the IMX258 camera sensor. The bindings, just like the > driver, are quite limited, e.g. do not support regulator supplies. > > Signed-off-by: Krzysztof Kozlowski > > --- > > Changes since v3: > 1. Document also two lane setup. > > Changes since v2: > 1. Remove clock-frequency, add reset GPIOs, add supplies. Oops. I missed this one. How does the driver know the appropriate clock frequency for the platform if it's not in DT? The sensor supports a range of frequencies, not a single frequency. Could you add clock-frequency back? -- Kind regards, Sakari Ailus From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DB33FC4727F for ; Tue, 29 Sep 2020 09:17:32 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6249A20897 for ; Tue, 29 Sep 2020 09:17:32 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="myDX9DJe" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6249A20897 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=u1iTTlhiTU6NHdxqdVcvQDhuh1x0S2sIeFr5SIXDn/4=; b=myDX9DJemre1OU2ShChUr/dE4 c/iZlcOeqIH49xibEJpWVWuVNTcwHX4Q6O+4sA/5zWAG6s8MBIc6ouft5fvMETXlT1GjJrD2qSg7q XajIDjbjCaBKYNiYwHgrgsFgcXbCZrKhojeodiO8nOP3SVNYb53ljtMSFSc7P9x21xmZ5ePznESMa ZgRqLj1qfdIrv+h+RY9hXKnn+GukFDTVy943WZiBJD2k9561XC7rBrjgynHJLR8KtV7p7maNAZIHK GpyFfbmG919mD1LUfPn57iH3ZvzndeqmAsOYJrj0pgakGVEIrkv7jhRWds3X1pdr0AJd/AUK5szOR VBzs7Ekyw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kNBja-0002NU-H5; Tue, 29 Sep 2020 09:15:42 +0000 Received: from mga12.intel.com ([192.55.52.136]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kNBjI-0002KM-Fi for linux-arm-kernel@lists.infradead.org; Tue, 29 Sep 2020 09:15:25 +0000 IronPort-SDR: MzXO0OJl/HUnG/P81uyz+5yBh9DX5dRWoqaysty4rJKo6UvGMuTerMOgAWBGh3P/+CLOvp/Q3+ 7OnGEdyc3aVg== X-IronPort-AV: E=McAfee;i="6000,8403,9758"; a="141555072" X-IronPort-AV: E=Sophos;i="5.77,317,1596524400"; d="scan'208";a="141555072" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Sep 2020 02:15:19 -0700 IronPort-SDR: 0DB0T6vhXOkGZh9FzgEDSSxLocytoEZPSXi5+vus9vfvea4Ft7NqXUZj4b0+bPNTsyCID90FCT V2TKn+XagUmQ== X-IronPort-AV: E=Sophos;i="5.77,317,1596524400"; d="scan'208";a="489430265" Received: from paasikivi.fi.intel.com ([10.237.72.42]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Sep 2020 02:15:14 -0700 Received: by paasikivi.fi.intel.com (Postfix, from userid 1000) id 42740204FD; Tue, 29 Sep 2020 12:15:12 +0300 (EEST) Date: Tue, 29 Sep 2020 12:15:12 +0300 From: Sakari Ailus To: Krzysztof Kozlowski Subject: Re: [PATCH v4 1/4] dt-bindings: media: imx258: add bindings for IMX258 sensor Message-ID: <20200929091512.GF26842@paasikivi.fi.intel.com> References: <20200923152129.21736-1-krzk@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200923152129.21736-1-krzk@kernel.org> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200929_051524_693999_6FB97228 X-CRM114-Status: GOOD ( 15.18 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Shawn Guo , Sascha Hauer , linux-kernel@vger.kernel.org, Rob Herring , NXP Linux Team , Pengutronix Kernel Team , Mauro Carvalho Chehab , Fabio Estevam , linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Krzysztof, On Wed, Sep 23, 2020 at 05:21:26PM +0200, Krzysztof Kozlowski wrote: > Add bindings for the IMX258 camera sensor. The bindings, just like the > driver, are quite limited, e.g. do not support regulator supplies. > > Signed-off-by: Krzysztof Kozlowski > > --- > > Changes since v3: > 1. Document also two lane setup. > > Changes since v2: > 1. Remove clock-frequency, add reset GPIOs, add supplies. Oops. I missed this one. How does the driver know the appropriate clock frequency for the platform if it's not in DT? The sensor supports a range of frequencies, not a single frequency. Could you add clock-frequency back? -- Kind regards, Sakari Ailus _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel