From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7E3C8C4727C for ; Tue, 29 Sep 2020 11:53:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2D2182065C for ; Tue, 29 Sep 2020 11:53:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1601380409; bh=hlCTEfeCQncgpBOMjD101cTzGYTMWM+Cj52a8KqvpF4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=fU7mlmKTt2zbkxXaEYv1GSa7DqFDT6oHFswWxYdX3h/2W0bJ2ooxFET688KbPYI7a KA5rOjSzhIRUfS/BcvaojhByrLFbQvTgkwWGxPUcikBgVAdrYA900nrg3t4TWjBWZ7 8aYpsgK1sVIzrGfplf1PoI/NTmd71Ll41mKJPwQI= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730483AbgI2Lx1 (ORCPT ); Tue, 29 Sep 2020 07:53:27 -0400 Received: from mail.kernel.org ([198.145.29.99]:47382 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731049AbgI2LrA (ORCPT ); Tue, 29 Sep 2020 07:47:00 -0400 Received: from localhost (83-86-74-64.cable.dynamic.v4.ziggo.nl [83.86.74.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 62CAB2158C; Tue, 29 Sep 2020 11:46:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1601380004; bh=hlCTEfeCQncgpBOMjD101cTzGYTMWM+Cj52a8KqvpF4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=CIxnkbCWDMi+k5z2ueynr8KfWIxpiKSXNNyPiH9DENmFx8mfWkc1Xx3K9BHW/wEgk W32k5dQceBQKd95gqPkhVYRoSg5MkfT38EOjQLMmP9xsZAVpZ6fxlTr2ayFP9VHtdl VtHsXD+/6gFiY8SuwEQadvL0pUV+HfOumh8mufEo= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Sumera Priyadarsini , Linus Walleij , Stephen Boyd , Sasha Levin Subject: [PATCH 5.8 06/99] clk: versatile: Add of_node_put() before return statement Date: Tue, 29 Sep 2020 13:00:49 +0200 Message-Id: <20200929105930.030467179@linuxfoundation.org> X-Mailer: git-send-email 2.28.0 In-Reply-To: <20200929105929.719230296@linuxfoundation.org> References: <20200929105929.719230296@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Sumera Priyadarsini [ Upstream commit da9c43dc0e2ec5c42a3d414e389feb30467000e2 ] Every iteration of for_each_available_child_of_node() decrements the reference count of the previous node, however when control is transferred from the middle of the loop, as in the case of a return or break or goto, there is no decrement thus ultimately resulting in a memory leak. Fix a potential memory leak in clk-impd1.c by inserting of_node_put() before a return statement. Issue found with Coccinelle. Signed-off-by: Sumera Priyadarsini Link: https://lore.kernel.org/r/20200829175704.GA10998@Kaladin Reviewed-by: Linus Walleij Signed-off-by: Stephen Boyd Signed-off-by: Sasha Levin --- drivers/clk/versatile/clk-impd1.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/clk/versatile/clk-impd1.c b/drivers/clk/versatile/clk-impd1.c index ca798249544d0..85c395df9c008 100644 --- a/drivers/clk/versatile/clk-impd1.c +++ b/drivers/clk/versatile/clk-impd1.c @@ -109,8 +109,10 @@ static int integrator_impd1_clk_probe(struct platform_device *pdev) for_each_available_child_of_node(np, child) { ret = integrator_impd1_clk_spawn(dev, np, child); - if (ret) + if (ret) { + of_node_put(child); break; + } } return ret; -- 2.25.1