All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: Biwen Li <biwen.li@oss.nxp.com>
Cc: jdelvare@suse.com, linux@roeck-us.net, mark.rutland@arm.com,
	linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org,
	devicetree@vger.kernel.org, Reinhard Pfau <pfau@gdsys.de>,
	Biwen Li <biwen.li@nxp.com>
Subject: Re: [PATCH] hwmon: add support for SMSC EMC2305/03/02/01 fan controller
Date: Tue, 29 Sep 2020 14:49:37 -0500	[thread overview]
Message-ID: <20200929194937.GA1046240@bogus> (raw)
In-Reply-To: <20200928104326.40386-1-biwen.li@oss.nxp.com>

On Mon, Sep 28, 2020 at 06:43:26PM +0800, Biwen Li wrote:
> From: Reinhard Pfau <pfau@gdsys.de>
> 
> Add support for SMSC EMC2305, EMC2303, EMC2302, EMC2301 fan controller
> chips.
> The driver primary supports the EMC2305 chip which provides RPM-based
> PWM control and monitoring for up to 5 fans.
> 
> According to the SMSC data sheets the EMC2303, EMC2302 and EMC2301 chips
> have basically the same functionality and register layout, but support
> less fans and (in case of EMC2302 and EMC2301) less possible I2C addresses.
> The driver supports them, too.
> 
> The driver supports configuration via devicetree. This can also be used
> to restrict the fans exposed via sysfs (see doc for details).
> 
> Signed-off-by: Reinhard Pfau <pfau@gdsys.de>
> Signed-off-by: Biwen Li <biwen.li@nxp.com>
> ---
>  .../devicetree/bindings/hwmon/emc2305.txt     |  33 +

Split to a separate patch and should be in DT schema format. 
checkpatch.pl will tell you both of these things.

>  Documentation/hwmon/emc2305.rst               |  34 +
>  MAINTAINERS                                   |   8 +
>  drivers/hwmon/Kconfig                         |  10 +
>  drivers/hwmon/Makefile                        |   1 +
>  drivers/hwmon/emc2305.c                       | 689 ++++++++++++++++++
>  6 files changed, 775 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/hwmon/emc2305.txt
>  create mode 100644 Documentation/hwmon/emc2305.rst
>  create mode 100644 drivers/hwmon/emc2305.c

  parent reply	other threads:[~2020-09-29 19:49 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-28 10:43 [PATCH] hwmon: add support for SMSC EMC2305/03/02/01 fan controller Biwen Li
2020-09-28 10:58 ` Biwen Li
2020-09-28 16:28 ` Guenter Roeck
2020-09-29 10:18   ` Biwen Li (OSS)
2020-09-29 19:49 ` Rob Herring [this message]
2020-10-16  9:24   ` Biwen Li (OSS)
  -- strict thread matches above, loose matches on Subject: below --
2013-06-13 10:40 Reinhard Pfau
2013-06-13 10:40 ` [PATCH] " Reinhard Pfau
2013-06-14  3:45   ` Guenter Roeck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200929194937.GA1046240@bogus \
    --to=robh@kernel.org \
    --cc=biwen.li@nxp.com \
    --cc=biwen.li@oss.nxp.com \
    --cc=devicetree@vger.kernel.org \
    --cc=jdelvare@suse.com \
    --cc=linux-hwmon@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=mark.rutland@arm.com \
    --cc=pfau@gdsys.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.