From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 860C2C47423 for ; Wed, 30 Sep 2020 00:13:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2B7922074B for ; Wed, 30 Sep 2020 00:13:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729301AbgI3ANC (ORCPT ); Tue, 29 Sep 2020 20:13:02 -0400 Received: from mail.kernel.org ([198.145.29.99]:36094 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728192AbgI3ANB (ORCPT ); Tue, 29 Sep 2020 20:13:01 -0400 Received: from oasis.local.home (cpe-66-24-58-225.stny.res.rr.com [66.24.58.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 5580B20739; Wed, 30 Sep 2020 00:12:59 +0000 (UTC) Date: Tue, 29 Sep 2020 20:12:57 -0400 From: Steven Rostedt To: Sami Tolvanen Cc: Masahiro Yamada , Will Deacon , Peter Zijlstra , Greg Kroah-Hartman , "Paul E. McKenney" , Kees Cook , Nick Desaulniers , clang-built-linux@googlegroups.com, kernel-hardening@lists.openwall.com, linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, x86@kernel.org Subject: Re: [PATCH v4 06/29] tracing: move function tracer options to Kconfig Message-ID: <20200929201257.1570aadd@oasis.local.home> In-Reply-To: <20200929214631.3516445-7-samitolvanen@google.com> References: <20200929214631.3516445-1-samitolvanen@google.com> <20200929214631.3516445-7-samitolvanen@google.com> X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 29 Sep 2020 14:46:08 -0700 Sami Tolvanen wrote: > +++ b/kernel/trace/Kconfig > @@ -595,6 +595,22 @@ config FTRACE_MCOUNT_RECORD > depends on DYNAMIC_FTRACE > depends on HAVE_FTRACE_MCOUNT_RECORD > > +config FTRACE_MCOUNT_USE_PATCHABLE_FUNCTION_ENTRY > + bool > + depends on FTRACE_MCOUNT_RECORD > + > +config FTRACE_MCOUNT_USE_CC > + def_bool y > + depends on $(cc-option,-mrecord-mcount) Does the above get executed at every build? Or does a make *config need to be done? If someone were to pass a .config to someone else that had a compiler that didn't support this, would it be changed if the person just did a make? -- Steve > + depends on !FTRACE_MCOUNT_USE_PATCHABLE_FUNCTION_ENTRY > + depends on FTRACE_MCOUNT_RECORD > + > +config FTRACE_MCOUNT_USE_RECORDMCOUNT > + def_bool y > + depends on !FTRACE_MCOUNT_USE_PATCHABLE_FUNCTION_ENTRY > + depends on !FTRACE_MCOUNT_USE_CC > + depends on FTRACE_MCOUNT_RECORD > + > config TRACING_MAP > bool > depends on ARCH_HAVE_NMI_SAFE_CMPXCHG From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8002AC4727C for ; Wed, 30 Sep 2020 00:14:58 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C6B6C20739 for ; Wed, 30 Sep 2020 00:14:57 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="fG68Xyq/" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C6B6C20739 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=goodmis.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=zZCXxde1CFLOqbeZmf3mCkReb93agf0xGFJgMPF9s84=; b=fG68Xyq/0jwtHnEZi+DtYUsBU fgf3ETzIDu3QB4C14TLrIqghG9aRPMI7LZBY51G1oz7F5ggmtoCKrGVfyPs6uM9cLxL5AtOs90vZu UPuW5ntIqpAI8+pfVU+VDHXna8uq5fJPy7o/Xoq9bRLTp8s234u9Co2+fdkc36Fri9uJT2HnV7J9g Cs3HAadpq7DjP5JVP5vGgKhboBbYDL83fSPhqbIvErVRsOgrpQLKOf35OZy05l2Q4S/hu7bQ+6/2b MRcvhOlHbfv/6JILbK2rmuBJMD6Jf+LjnXTadjyuRo83NRZ60bD0GVVdcAwu+M6tus+m6Q8SiSAGT Jf0a1ypAA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kNPk3-0002AD-78; Wed, 30 Sep 2020 00:13:07 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kNPjz-000299-Q8 for linux-arm-kernel@lists.infradead.org; Wed, 30 Sep 2020 00:13:04 +0000 Received: from oasis.local.home (cpe-66-24-58-225.stny.res.rr.com [66.24.58.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 5580B20739; Wed, 30 Sep 2020 00:12:59 +0000 (UTC) Date: Tue, 29 Sep 2020 20:12:57 -0400 From: Steven Rostedt To: Sami Tolvanen Subject: Re: [PATCH v4 06/29] tracing: move function tracer options to Kconfig Message-ID: <20200929201257.1570aadd@oasis.local.home> In-Reply-To: <20200929214631.3516445-7-samitolvanen@google.com> References: <20200929214631.3516445-1-samitolvanen@google.com> <20200929214631.3516445-7-samitolvanen@google.com> X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200929_201303_922564_5F73111F X-CRM114-Status: GOOD ( 17.35 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-arch@vger.kernel.org, x86@kernel.org, Kees Cook , "Paul E. McKenney" , kernel-hardening@lists.openwall.com, Peter Zijlstra , Greg Kroah-Hartman , Masahiro Yamada , linux-kbuild@vger.kernel.org, Nick Desaulniers , linux-kernel@vger.kernel.org, clang-built-linux@googlegroups.com, linux-pci@vger.kernel.org, Will Deacon , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, 29 Sep 2020 14:46:08 -0700 Sami Tolvanen wrote: > +++ b/kernel/trace/Kconfig > @@ -595,6 +595,22 @@ config FTRACE_MCOUNT_RECORD > depends on DYNAMIC_FTRACE > depends on HAVE_FTRACE_MCOUNT_RECORD > > +config FTRACE_MCOUNT_USE_PATCHABLE_FUNCTION_ENTRY > + bool > + depends on FTRACE_MCOUNT_RECORD > + > +config FTRACE_MCOUNT_USE_CC > + def_bool y > + depends on $(cc-option,-mrecord-mcount) Does the above get executed at every build? Or does a make *config need to be done? If someone were to pass a .config to someone else that had a compiler that didn't support this, would it be changed if the person just did a make? -- Steve > + depends on !FTRACE_MCOUNT_USE_PATCHABLE_FUNCTION_ENTRY > + depends on FTRACE_MCOUNT_RECORD > + > +config FTRACE_MCOUNT_USE_RECORDMCOUNT > + def_bool y > + depends on !FTRACE_MCOUNT_USE_PATCHABLE_FUNCTION_ENTRY > + depends on !FTRACE_MCOUNT_USE_CC > + depends on FTRACE_MCOUNT_RECORD > + > config TRACING_MAP > bool > depends on ARCH_HAVE_NMI_SAFE_CMPXCHG _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel