CC: kbuild-all(a)lists.01.org CC: linux-kernel(a)vger.kernel.org TO: Denis Efremov CC: Julia Lawall CC: Valentina Manea CC: Shuah Khan CC: "Greg Kroah-Hartman" CC: linux-usb(a)vger.kernel.org CC: linux-kernel(a)vger.kernel.org From: kernel test robot drivers/usb/usbip/stub_dev.c:33:8-16: WARNING: use scnprintf or sprintf From Documentation/filesystems/sysfs.txt: show() must not use snprintf() when formatting the value to be returned to user space. If you can guarantee that an overflow will never happen you can use sprintf() otherwise you must use scnprintf(). Generated by: scripts/coccinelle/api/device_attr_show.cocci Fixes: abfc19ff202d ("coccinelle: api: add device_attr_show script") CC: Denis Efremov Signed-off-by: kernel test robot --- tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: ccc1d052eff9f3cfe59d201263903fe1d46c79a5 commit: abfc19ff202d287742483e15fd478ddd6ada2187 coccinelle: api: add device_attr_show script :::::: branch date: 3 hours ago :::::: commit date: 8 weeks ago Please take the patch only if it's a positive warning. Thanks! stub_dev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/usb/usbip/stub_dev.c +++ b/drivers/usb/usbip/stub_dev.c @@ -30,7 +30,7 @@ static ssize_t usbip_status_show(struct status = sdev->ud.status; spin_unlock_irq(&sdev->ud.lock); - return snprintf(buf, PAGE_SIZE, "%d\n", status); + return scnprintf(buf, PAGE_SIZE, "%d\n", status); } static DEVICE_ATTR_RO(usbip_status);