From: Thomas Gleixner <tglx@linutronix.de> To: LKML <linux-kernel@vger.kernel.org> Cc: Peter Zijlstra <peterz@infradead.org>, Paul McKenney <paulmck@kernel.org>, Matthew Wilcox <willy@infradead.org>, Christian Benvenuti <benve@cisco.com>, Govindarajulu Varadarajan <_govind@gmx.com>, Dave Miller <davem@davemloft.net>, Jakub Kicinski <kuba@kernel.org>, netdev@vger.kernel.org, Jonathan Corbet <corbet@lwn.net>, Mauro Carvalho Chehab <mchehab+huawei@kernel.org>, linux-doc@vger.kernel.org, Sebastian Andrzej Siewior <bigeasy@linutronix.de>, Luc Van Oostenryck <luc.vanoostenryck@gmail.com>, Jay Cliburn <jcliburn@gmail.com>, Chris Snook <chris.snook@gmail.com>, Vishal Kulkarni <vishal@chelsio.com>, Jeff Kirsher <jeffrey.t.kirsher@intel.com>, intel-wired-lan@lists.osuosl.org, Shannon Nelson <snelson@pensando.io>, Pensando Drivers <drivers@pensando.io>, Andrew Lunn <andrew@lunn.ch>, Heiner Kallweit <hkallweit1@gmail.com>, Russell King <linux@armlinux.org.uk>, Thomas Bogendoerfer <tsbogend@alpha.franken.de>, Solarflare linux maintainers <linux-net-drivers@solarflare.com>, Edward Cree <ecree@solarflare.com>, Martin Habets <mhabets@solarflare.com>, Jon Mason <jdmason@kudzu.us>, Daniel Drake <dsd@gentoo.org>, Ulrich Kunitz <kune@deine-taler.de>, Kalle Valo <kvalo@codeaurora.org>, linux-wireless@vger.kernel.org, linux-usb@vger.kernel.org, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Arend van Spriel <arend.vanspriel@broadcom.com>, Franky Lin <franky.lin@broadcom.com>, Hante Meuleman <hante.meuleman@broadcom.com>, Chi-Hsien Lin <chi-hsien.lin@cypress.com>, Wright Feng <wright.feng@cypress.com>, brcm80211-dev-list.pdl@broadcom.com, brcm80211-dev-list@cypress.com, Stanislav Yakovlev <stas.yakovlev@gmail.com>, Stanislaw Gruszka <stf_xl@wp.pl>, Johannes Berg <johannes.berg@intel.com>, Emmanuel Grumbach <emmanuel.grumbach@intel.com>, Luca Coelho <luciano.coelho@intel.com>, Intel Linux Wireless <linuxwifi@intel.com>, Jouni Malinen <j@w1.fi>, Amitkumar Karwar <amitkarwar@gmail.com>, Ganapathi Bhat <ganapathi.bhat@nxp.com>, Xinming Hu <huxinming820@gmail.com>, libertas-dev@lists.infradead.org, Pascal Terjan <pterjan@google.com>, Ping-Ke Shih <pkshih@realtek.com> Subject: [patch V2 35/36] net: rtlwifi: Remove in_interrupt() from debug macro Date: Tue, 29 Sep 2020 22:25:44 +0200 [thread overview] Message-ID: <20200929203502.960332937@linutronix.de> (raw) In-Reply-To: 20200929202509.673358734@linutronix.de From: Sebastian Andrzej Siewior <bigeasy@linutronix.de> The usage of in_interrupt() in drivers in is phased out. rtl_dbg() a printk based debug aid is using in_interrupt() in the underlying C function _rtl_dbg_out() which is almost identical to _rtl_dbg_print(). The only difference is the printout of in_interrupt(). The decoding of in_interrupt() as hexvalue is non-trivial and aside of being phased out for driver usage the return value is just by chance the masked preempt count value and not a boolean. These home brewn printk debug aids are tedious to work with and provide only minimal context. They should be replaced by trace_printk() or a debug tracepoint which automatically records all context information. To make progress on the in_interrupt() cleanup, make rtl_dbg() use _rtl_dbg_print() and remove _rtl_dbg_out(). Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de> Signed-off-by: Thomas Gleixner <tglx@linutronix.de> Acked-by: Kalle Valo <kvalo@codeaurora.org> --- V2: Adopted to the new names of the same thing. --- drivers/net/wireless/realtek/rtlwifi/debug.c | 20 -------------------- drivers/net/wireless/realtek/rtlwifi/debug.h | 8 ++------ 2 files changed, 2 insertions(+), 26 deletions(-) --- a/drivers/net/wireless/realtek/rtlwifi/debug.c +++ b/drivers/net/wireless/realtek/rtlwifi/debug.c @@ -8,26 +8,6 @@ #include <linux/vmalloc.h> #ifdef CONFIG_RTLWIFI_DEBUG -void _rtl_dbg_out(struct rtl_priv *rtlpriv, u64 comp, int level, - const char *fmt, ...) -{ - if (unlikely((comp & rtlpriv->cfg->mod_params->debug_mask) && - level <= rtlpriv->cfg->mod_params->debug_level)) { - struct va_format vaf; - va_list args; - - va_start(args, fmt); - - vaf.fmt = fmt; - vaf.va = &args; - - pr_info(":<%lx> %pV", in_interrupt(), &vaf); - - va_end(args); - } -} -EXPORT_SYMBOL_GPL(_rtl_dbg_out); - void _rtl_dbg_print(struct rtl_priv *rtlpriv, u64 comp, int level, const char *fmt, ...) { --- a/drivers/net/wireless/realtek/rtlwifi/debug.h +++ b/drivers/net/wireless/realtek/rtlwifi/debug.h @@ -149,10 +149,6 @@ enum dbgp_flag_e { struct rtl_priv; __printf(4, 5) -void _rtl_dbg_out(struct rtl_priv *rtlpriv, u64 comp, int level, - const char *fmt, ...); - -__printf(4, 5) void _rtl_dbg_print(struct rtl_priv *rtlpriv, u64 comp, int level, const char *fmt, ...); @@ -160,8 +156,8 @@ void _rtl_dbg_print_data(struct rtl_priv const char *titlestring, const void *hexdata, int hexdatalen); -#define rtl_dbg(rtlpriv, comp, level, fmt, ...) \ - _rtl_dbg_out(rtlpriv, comp, level, \ +#define rtl_dbg(rtlpriv, comp, level, fmt, ...) \ + _rtl_dbg_print(rtlpriv, comp, level, \ fmt, ##__VA_ARGS__) #define RTPRINT(rtlpriv, dbgtype, dbgflag, fmt, ...) \
WARNING: multiple messages have this Message-ID (diff)
From: Thomas Gleixner <tglx@linutronix.de> To: intel-wired-lan@osuosl.org Subject: [Intel-wired-lan] [patch V2 35/36] net: rtlwifi: Remove in_interrupt() from debug macro Date: Tue, 29 Sep 2020 22:25:44 +0200 [thread overview] Message-ID: <20200929203502.960332937@linutronix.de> (raw) In-Reply-To: 20200929202509.673358734@linutronix.de From: Sebastian Andrzej Siewior <bigeasy@linutronix.de> The usage of in_interrupt() in drivers in is phased out. rtl_dbg() a printk based debug aid is using in_interrupt() in the underlying C function _rtl_dbg_out() which is almost identical to _rtl_dbg_print(). The only difference is the printout of in_interrupt(). The decoding of in_interrupt() as hexvalue is non-trivial and aside of being phased out for driver usage the return value is just by chance the masked preempt count value and not a boolean. These home brewn printk debug aids are tedious to work with and provide only minimal context. They should be replaced by trace_printk() or a debug tracepoint which automatically records all context information. To make progress on the in_interrupt() cleanup, make rtl_dbg() use _rtl_dbg_print() and remove _rtl_dbg_out(). Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de> Signed-off-by: Thomas Gleixner <tglx@linutronix.de> Acked-by: Kalle Valo <kvalo@codeaurora.org> --- V2: Adopted to the new names of the same thing. --- drivers/net/wireless/realtek/rtlwifi/debug.c | 20 -------------------- drivers/net/wireless/realtek/rtlwifi/debug.h | 8 ++------ 2 files changed, 2 insertions(+), 26 deletions(-) --- a/drivers/net/wireless/realtek/rtlwifi/debug.c +++ b/drivers/net/wireless/realtek/rtlwifi/debug.c @@ -8,26 +8,6 @@ #include <linux/vmalloc.h> #ifdef CONFIG_RTLWIFI_DEBUG -void _rtl_dbg_out(struct rtl_priv *rtlpriv, u64 comp, int level, - const char *fmt, ...) -{ - if (unlikely((comp & rtlpriv->cfg->mod_params->debug_mask) && - level <= rtlpriv->cfg->mod_params->debug_level)) { - struct va_format vaf; - va_list args; - - va_start(args, fmt); - - vaf.fmt = fmt; - vaf.va = &args; - - pr_info(":<%lx> %pV", in_interrupt(), &vaf); - - va_end(args); - } -} -EXPORT_SYMBOL_GPL(_rtl_dbg_out); - void _rtl_dbg_print(struct rtl_priv *rtlpriv, u64 comp, int level, const char *fmt, ...) { --- a/drivers/net/wireless/realtek/rtlwifi/debug.h +++ b/drivers/net/wireless/realtek/rtlwifi/debug.h @@ -149,10 +149,6 @@ enum dbgp_flag_e { struct rtl_priv; __printf(4, 5) -void _rtl_dbg_out(struct rtl_priv *rtlpriv, u64 comp, int level, - const char *fmt, ...); - -__printf(4, 5) void _rtl_dbg_print(struct rtl_priv *rtlpriv, u64 comp, int level, const char *fmt, ...); @@ -160,8 +156,8 @@ void _rtl_dbg_print_data(struct rtl_priv const char *titlestring, const void *hexdata, int hexdatalen); -#define rtl_dbg(rtlpriv, comp, level, fmt, ...) \ - _rtl_dbg_out(rtlpriv, comp, level, \ +#define rtl_dbg(rtlpriv, comp, level, fmt, ...) \ + _rtl_dbg_print(rtlpriv, comp, level, \ fmt, ##__VA_ARGS__) #define RTPRINT(rtlpriv, dbgtype, dbgflag, fmt, ...) \
next prev parent reply other threads:[~2020-09-29 20:36 UTC|newest] Thread overview: 88+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-09-29 20:25 [patch V2 00/36] net: in_interrupt() cleanup and fixes Thomas Gleixner 2020-09-29 20:25 ` [Intel-wired-lan] " Thomas Gleixner 2020-09-29 20:25 ` [patch V2 01/36] net: enic: Cure the enic api locking trainwreck Thomas Gleixner 2020-09-29 20:25 ` [Intel-wired-lan] " Thomas Gleixner 2020-09-29 20:25 ` [patch V2 02/36] net: caif: Remove unused caif SPI driver Thomas Gleixner 2020-09-29 20:25 ` [Intel-wired-lan] " Thomas Gleixner 2020-09-29 20:25 ` [patch V2 03/36] net: Add netif_rx_any_context() Thomas Gleixner 2020-09-29 20:25 ` [Intel-wired-lan] " Thomas Gleixner 2020-09-29 20:25 ` [patch V2 04/36] net: caif: Use netif_rx_any_context() Thomas Gleixner 2020-09-29 20:25 ` [Intel-wired-lan] " Thomas Gleixner 2020-09-29 20:25 ` [patch V2 05/36] net: atheros: Remove WARN_ON(in_interrupt()) Thomas Gleixner 2020-09-29 20:25 ` [Intel-wired-lan] " Thomas Gleixner 2020-09-29 20:25 ` [patch V2 06/36] net: cxgb3: Cleanup in_interrupt() usage Thomas Gleixner 2020-09-29 20:25 ` [Intel-wired-lan] " Thomas Gleixner 2020-09-29 20:25 ` [patch V2 07/36] net: cxbg4: Remove pointless in_interrupt() check Thomas Gleixner 2020-09-29 20:25 ` [Intel-wired-lan] " Thomas Gleixner 2020-09-29 20:25 ` [patch V2 08/36] net: e100: Remove in_interrupt() usage and pointless GFP_ATOMIC allocation Thomas Gleixner 2020-09-29 20:25 ` [Intel-wired-lan] " Thomas Gleixner 2020-09-29 20:25 ` [patch V2 09/36] net: fec_mpc52xx: Replace in_interrupt() usage Thomas Gleixner 2020-09-29 20:25 ` [Intel-wired-lan] " Thomas Gleixner 2020-09-29 20:25 ` [patch V2 10/36] net: intel: Remove in_interrupt() warnings Thomas Gleixner 2020-09-29 20:25 ` [Intel-wired-lan] " Thomas Gleixner 2020-09-29 20:25 ` [patch V2 11/36] net: ionic: Replace in_interrupt() usage Thomas Gleixner 2020-09-29 20:25 ` [Intel-wired-lan] " Thomas Gleixner 2020-09-29 23:06 ` Shannon Nelson 2020-09-29 23:06 ` [Intel-wired-lan] " Shannon Nelson 2020-09-29 20:25 ` [patch V2 12/36] net: ionic: Remove WARN_ON(in_interrupt()) Thomas Gleixner 2020-09-29 20:25 ` [Intel-wired-lan] " Thomas Gleixner 2020-09-29 20:25 ` [patch V2 13/36] net: mdiobus: Remove WARN_ON_ONCE(in_interrupt()) Thomas Gleixner 2020-09-29 20:25 ` [Intel-wired-lan] " Thomas Gleixner 2020-09-29 20:25 ` [patch V2 14/36] net: natsemi: Replace in_interrupt() usage Thomas Gleixner 2020-09-29 20:25 ` [Intel-wired-lan] " Thomas Gleixner 2020-09-29 20:25 ` [patch V2 15/36] net: sfc: " Thomas Gleixner 2020-09-29 20:25 ` [Intel-wired-lan] " Thomas Gleixner 2020-09-29 20:25 ` [patch V2 16/36] net: sfc: Use GFP_KERNEL in efx_ef10_try_update_nic_stats() Thomas Gleixner 2020-09-29 20:25 ` [Intel-wired-lan] " Thomas Gleixner 2020-09-30 8:00 ` Martin Habets 2020-09-30 8:00 ` [Intel-wired-lan] " Martin Habets 2020-09-29 20:25 ` [patch V2 17/36] net: sunbmac: Replace in_interrupt() usage Thomas Gleixner 2020-09-29 20:25 ` [Intel-wired-lan] " Thomas Gleixner 2020-09-29 20:25 ` [patch V2 18/36] net: sun3lance: Remove redundant checks in interrupt handler Thomas Gleixner 2020-09-29 20:25 ` [Intel-wired-lan] " Thomas Gleixner 2020-09-29 20:25 ` [patch V2 19/36] net: vxge: Remove in_interrupt() conditionals Thomas Gleixner 2020-09-29 20:25 ` [Intel-wired-lan] " Thomas Gleixner 2020-09-29 20:25 ` [patch V2 20/36] net: zd1211rw: Remove ZD_ASSERT(in_interrupt()) Thomas Gleixner 2020-09-29 20:25 ` [Intel-wired-lan] " Thomas Gleixner 2020-09-29 20:25 ` [patch V2 21/36] net: usb: kaweth: Replace kaweth_control() with usb_control_msg() Thomas Gleixner 2020-09-29 20:25 ` [Intel-wired-lan] " Thomas Gleixner 2020-09-30 6:22 ` Greg Kroah-Hartman 2020-09-30 6:22 ` [Intel-wired-lan] " Greg Kroah-Hartman 2020-09-29 20:25 ` [patch V2 22/36] net: usb: kaweth: Remove last user of kaweth_control() Thomas Gleixner 2020-09-29 20:25 ` [Intel-wired-lan] " Thomas Gleixner 2020-09-29 20:25 ` [patch V2 23/36] net: usb: net1080: Remove in_interrupt() comment Thomas Gleixner 2020-09-29 20:25 ` [Intel-wired-lan] " Thomas Gleixner 2020-09-29 20:25 ` [patch V2 24/36] net: wan/lmc: Remove lmc_trace() Thomas Gleixner 2020-09-29 20:25 ` [Intel-wired-lan] " Thomas Gleixner 2020-09-29 20:25 ` [patch V2 25/36] net: brcmfmac: Replace in_interrupt() Thomas Gleixner 2020-09-29 20:25 ` [Intel-wired-lan] " Thomas Gleixner 2020-09-29 20:25 ` [patch V2 26/36] net: brcmfmac: Convey execution context via argument to brcmf_netif_rx() Thomas Gleixner 2020-09-29 20:25 ` [Intel-wired-lan] " Thomas Gleixner 2020-09-29 22:03 ` Arend Van Spriel 2020-09-29 22:03 ` [Intel-wired-lan] " Arend Van Spriel 2020-09-29 20:25 ` [patch V2 27/36] net: brcmfmac: Convey allocation mode as argument Thomas Gleixner 2020-09-29 20:25 ` [Intel-wired-lan] " Thomas Gleixner 2020-09-29 22:07 ` Arend Van Spriel 2020-09-29 22:07 ` [Intel-wired-lan] " Arend Van Spriel 2020-09-29 20:25 ` [patch V2 28/36] net: ipw2x00,iwlegacy,iwlwifi: Remove in_interrupt() from debug macros Thomas Gleixner 2020-09-29 20:25 ` [Intel-wired-lan] [patch V2 28/36] net: ipw2x00, iwlegacy, iwlwifi: " Thomas Gleixner 2020-09-29 20:25 ` [patch V2 29/36] net: iwlwifi: Remove in_interrupt() from tracing macro Thomas Gleixner 2020-09-29 20:25 ` [Intel-wired-lan] " Thomas Gleixner 2020-09-29 20:25 ` [patch V2 30/36] net: hostap: Remove in_interrupt() usage Thomas Gleixner 2020-09-29 20:25 ` [Intel-wired-lan] " Thomas Gleixner 2020-09-29 20:25 ` [patch V2 31/36] net: mwifiex: Use netif_rx_any_context() Thomas Gleixner 2020-09-29 20:25 ` [Intel-wired-lan] " Thomas Gleixner 2020-09-29 20:25 ` [patch V2 32/36] net: libertas libertas_tf: Remove in_interrupt() from debug macro Thomas Gleixner 2020-09-29 20:25 ` [Intel-wired-lan] " Thomas Gleixner 2020-09-29 20:25 ` [patch V2 33/36] net: libertas: Use netif_rx_any_context() Thomas Gleixner 2020-09-29 20:25 ` [Intel-wired-lan] " Thomas Gleixner 2020-09-29 21:53 ` James Cameron 2020-09-29 21:53 ` [Intel-wired-lan] " James Cameron 2020-09-29 20:25 ` [patch V2 34/36] net: rtlwifi: Remove void* casts related to delayed work Thomas Gleixner 2020-09-29 20:25 ` [Intel-wired-lan] " Thomas Gleixner 2020-09-29 20:25 ` Thomas Gleixner [this message] 2020-09-29 20:25 ` [Intel-wired-lan] [patch V2 35/36] net: rtlwifi: Remove in_interrupt() from debug macro Thomas Gleixner 2020-09-29 20:25 ` [patch V2 36/36] net: rtlwifi: Replace in_interrupt() for context detection Thomas Gleixner 2020-09-29 20:25 ` [Intel-wired-lan] " Thomas Gleixner 2020-09-29 21:22 ` [patch V2 00/36] net: in_interrupt() cleanup and fixes David Miller 2020-09-29 21:22 ` [Intel-wired-lan] " David Miller
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200929203502.960332937@linutronix.de \ --to=tglx@linutronix.de \ --cc=_govind@gmx.com \ --cc=amitkarwar@gmail.com \ --cc=andrew@lunn.ch \ --cc=arend.vanspriel@broadcom.com \ --cc=benve@cisco.com \ --cc=bigeasy@linutronix.de \ --cc=brcm80211-dev-list.pdl@broadcom.com \ --cc=brcm80211-dev-list@cypress.com \ --cc=chi-hsien.lin@cypress.com \ --cc=chris.snook@gmail.com \ --cc=corbet@lwn.net \ --cc=davem@davemloft.net \ --cc=drivers@pensando.io \ --cc=dsd@gentoo.org \ --cc=ecree@solarflare.com \ --cc=emmanuel.grumbach@intel.com \ --cc=franky.lin@broadcom.com \ --cc=ganapathi.bhat@nxp.com \ --cc=gregkh@linuxfoundation.org \ --cc=hante.meuleman@broadcom.com \ --cc=hkallweit1@gmail.com \ --cc=huxinming820@gmail.com \ --cc=intel-wired-lan@lists.osuosl.org \ --cc=j@w1.fi \ --cc=jcliburn@gmail.com \ --cc=jdmason@kudzu.us \ --cc=jeffrey.t.kirsher@intel.com \ --cc=johannes.berg@intel.com \ --cc=kuba@kernel.org \ --cc=kune@deine-taler.de \ --cc=kvalo@codeaurora.org \ --cc=libertas-dev@lists.infradead.org \ --cc=linux-doc@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-net-drivers@solarflare.com \ --cc=linux-usb@vger.kernel.org \ --cc=linux-wireless@vger.kernel.org \ --cc=linux@armlinux.org.uk \ --cc=linuxwifi@intel.com \ --cc=luc.vanoostenryck@gmail.com \ --cc=luciano.coelho@intel.com \ --cc=mchehab+huawei@kernel.org \ --cc=mhabets@solarflare.com \ --cc=netdev@vger.kernel.org \ --cc=paulmck@kernel.org \ --cc=peterz@infradead.org \ --cc=pkshih@realtek.com \ --cc=pterjan@google.com \ --cc=snelson@pensando.io \ --cc=stas.yakovlev@gmail.com \ --cc=stf_xl@wp.pl \ --cc=tsbogend@alpha.franken.de \ --cc=vishal@chelsio.com \ --cc=willy@infradead.org \ --cc=wright.feng@cypress.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.