Re: [PATCH v2 2/6] mfd: Add MFD driver for ATC260x PMICs

From: Cristian Ciocaltea <cristian.ciocaltea@gmail.com>
To: Lee Jones <lee.jones@linaro.org>
Cc: "kernel test robot" <lkp@intel.com>,
	"Rob Herring" <robh+dt@kernel.org>,
	"Dmitry Torokhov" <dmitry.torokhov@gmail.com>,
	"Sebastian Reichel" <sre@kernel.org>,
	"Liam Girdwood" <lgirdwood@gmail.com>,
	"Mark Brown" <broonie@kernel.org>,
	kbuild-all@lists.01.org,
	"Manivannan Sadhasivam" <manivannan.sadhasivam@linaro.org>,
	"Andreas Färber" <afaerber@suse.de>,
	linux-actions@lists.infradead.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v2 2/6] mfd: Add MFD driver for ATC260x PMICs
Date: Tue, 29 Sep 2020 23:45:33 +0300	[thread overview]
Message-ID: <20200929204533.GA35053@BV030612LT> (raw)
In-Reply-To: <20200929094857.GF6148@dell>

Hi Lee,

On Tue, Sep 29, 2020 at 10:48:57AM +0100, Lee Jones wrote:
> On Sat, 22 Aug 2020, kernel test robot wrote:
> 
> > Hi Cristian,
> > 
> > Thank you for the patch! Yet something to improve:
> > 
> > [auto build test ERROR on lee-mfd/for-mfd-next]
> > [also build test ERROR on regulator/for-next v5.9-rc1 next-20200821]
> > [cannot apply to input/next power-supply/for-next]
> > [If your patch is applied to the wrong git tree, kindly drop us a note.
> > And when submitting patch, we suggest to use '--base' as documented in
> > https://git-scm.com/docs/git-format-patch]
> > 
> > url:    https://github.com/0day-ci/linux/commits/Cristian-Ciocaltea/Add-initial-support-for-ATC260x-PMICs/20200822-062126
> > base:   https://git.kernel.org/pub/scm/linux/kernel/git/lee/mfd.git for-mfd-next
> > config: sh-allmodconfig (attached as .config)
> > compiler: sh4-linux-gcc (GCC) 9.3.0
> > reproduce (this is a W=1 build):
> >         wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
> >         chmod +x ~/bin/make.cross
> >         # save the attached .config to linux build tree
> >         COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=sh 
> > 
> > If you fix the issue, kindly add following tag as appropriate
> > Reported-by: kernel test robot <lkp@intel.com>
> > 
> > All errors (new ones prefixed by >>, old ones prefixed by <<):
> > 
> > WARNING: modpost: missing MODULE_LICENSE() in drivers/mfd/atc260x-core.o
> > >> FATAL: modpost: drivers/mfd/atc260x-i2c: sizeof(struct i2c_device_id)=24 is not a modulo of the size of section __mod_i2c__<identifier>_device_table=588.
> > >> Fix definition of struct i2c_device_id in mod_devicetable.h
> > 
> > ---
> > 0-DAY CI Kernel Test Service, Intel Corporation
> > https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
> 
> Is this something you plan to fix?

Yes, I was just waiting to get some initial feedback for the drivers
code before submitting a new revision. Except for the MFD core, I think
this is almost completed.

> -- 
> Lee Jones [李琼斯]
> Senior Technical Lead - Developer Services
> Linaro.org │ Open source software for Arm SoCs
> Follow Linaro: Facebook | Twitter | Blog

Kind regards,
Cristi