From: James Bottomley <James.Bottomley@HansenPartnership.com>
To: linux-integrity@vger.kernel.org
Cc: Jason Gunthorpe <jgg@ziepe.ca>,
Jerry Snitselaar <jsnitsel@redhat.com>,
Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>,
Peter Huewe <peterhuewe@gmx.de>
Subject: [PATCH 0/4] tpm_tis: fix interrupts (again)
Date: Tue, 29 Sep 2020 15:32:12 -0700 [thread overview]
Message-ID: <20200929223216.22584-1-James.Bottomley@HansenPartnership.com> (raw)
The current state of the TIS TPM is that interrupts have been globally
disabled by various changes. The problems we got reported the last
time they were enabled was interrupt storms. With my own TIS TPM,
I've found that this is caused because my TPM doesn't do legacy
cycles, The TIS spec (chapter 6.1 "Locality Usage Per Register")
requires any TIS TPM without legacy cycles not to act on any write to
an interrupt register unless the locality is enabled. This means if
an interrupt fires after we relinquish the locality, the TPM_EOI in
the interrupt routine is ineffective meaning the same interrupt
triggers over and over again. This problem also means we can have
trouble setting up interrupts on TIS TPMs because the current init
code does the setup before the locality is claimed for the first time.
James Bottomley (4):
tpm_tis: Clean up locality release
tpm_tis: Fix interrupts for TIS TPMs without legacy cycles
tpm_tis: fix IRQ probing
Revert "tpm: Revert "tpm_tis_core: Turn on the TPM before probing
IRQ's""
drivers/char/tpm/tpm_tis_core.c | 182 ++++++++++++++++++++------------
1 file changed, 115 insertions(+), 67 deletions(-)
--
2.28.0
next reply other threads:[~2020-09-29 22:32 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-29 22:32 James Bottomley [this message]
2020-09-29 22:32 ` [PATCH 1/4] tpm_tis: Clean up locality release James Bottomley
2020-09-30 2:26 ` Jarkko Sakkinen
2020-09-30 2:26 ` Jarkko Sakkinen
2020-09-30 21:19 ` Jerry Snitselaar
2020-09-30 23:03 ` James Bottomley
2020-10-01 0:01 ` Jerry Snitselaar
2020-10-01 15:58 ` James Bottomley
2021-01-02 1:17 ` Laurent Bigonville
2020-10-01 2:01 ` Jarkko Sakkinen
2020-10-01 4:49 ` James Bottomley
2020-10-01 17:48 ` James Bottomley
2020-09-29 22:32 ` [PATCH 2/4] tpm_tis: Fix interrupts for TIS TPMs without legacy cycles James Bottomley
2020-09-30 2:39 ` Jarkko Sakkinen
2020-09-29 22:32 ` [PATCH 3/4] tpm_tis: fix IRQ probing James Bottomley
2020-09-30 2:40 ` Jarkko Sakkinen
2020-09-29 22:32 ` [PATCH 4/4] Revert "tpm: Revert "tpm_tis_core: Turn on the TPM before probing IRQ's"" James Bottomley
2020-09-30 2:40 ` Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200929223216.22584-1-James.Bottomley@HansenPartnership.com \
--to=james.bottomley@hansenpartnership.com \
--cc=jarkko.sakkinen@linux.intel.com \
--cc=jgg@ziepe.ca \
--cc=jsnitsel@redhat.com \
--cc=linux-integrity@vger.kernel.org \
--cc=peterhuewe@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.