From: "Philippe Mathieu-Daudé" <philmd@redhat.com> To: qemu-devel@nongnu.org Cc: "Thomas Huth" <thuth@redhat.com>, "Paolo Bonzini" <pbonzini@redhat.com>, "Richard Henderson" <richard.henderson@linaro.org>, "Fam Zheng" <fam@euphon.net>, "Peter Maydell" <peter.maydell@linaro.org>, kvm@vger.kernel.org, "Alex Bennée" <alex.bennee@linaro.org>, qemu-arm@nongnu.org, "Richard Henderson" <rth@twiddle.net>, "Philippe Mathieu-Daudé" <philmd@redhat.com>, "Keith Packard" <keithp@keithp.com> Subject: [PATCH v4 01/12] accel/tcg: Add stub for cpu_loop_exit() Date: Wed, 30 Sep 2020 00:43:44 +0200 [thread overview] Message-ID: <20200929224355.1224017-2-philmd@redhat.com> (raw) In-Reply-To: <20200929224355.1224017-1-philmd@redhat.com> Since the support of SYS_READC in commit 8de702cb67 the semihosting code is strongly depedent of the TCG accelerator via a call to cpu_loop_exit(). Ideally we would only build semihosting support when TCG is available, but unfortunately this is not trivial because semihosting is used by many targets in different configurations. For now add a simple stub to avoid link failure when building with --disable-tcg: hw/semihosting/console.c:160: undefined reference to `cpu_loop_exit' Cc: Keith Packard <keithp@keithp.com> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com> --- accel/stubs/tcg-stub.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/accel/stubs/tcg-stub.c b/accel/stubs/tcg-stub.c index e4bbf997aa..1eec7fb90e 100644 --- a/accel/stubs/tcg-stub.c +++ b/accel/stubs/tcg-stub.c @@ -29,3 +29,8 @@ void *probe_access(CPUArchState *env, target_ulong addr, int size, /* Handled by hardware accelerator. */ g_assert_not_reached(); } + +void cpu_loop_exit(CPUState *cpu) +{ + g_assert_not_reached(); +} -- 2.26.2
WARNING: multiple messages have this Message-ID (diff)
From: "Philippe Mathieu-Daudé" <philmd@redhat.com> To: qemu-devel@nongnu.org Cc: "Fam Zheng" <fam@euphon.net>, "Peter Maydell" <peter.maydell@linaro.org>, "Thomas Huth" <thuth@redhat.com>, kvm@vger.kernel.org, "Philippe Mathieu-Daudé" <philmd@redhat.com>, "Richard Henderson" <richard.henderson@linaro.org>, "Keith Packard" <keithp@keithp.com>, qemu-arm@nongnu.org, "Paolo Bonzini" <pbonzini@redhat.com>, "Alex Bennée" <alex.bennee@linaro.org>, "Richard Henderson" <rth@twiddle.net> Subject: [PATCH v4 01/12] accel/tcg: Add stub for cpu_loop_exit() Date: Wed, 30 Sep 2020 00:43:44 +0200 [thread overview] Message-ID: <20200929224355.1224017-2-philmd@redhat.com> (raw) In-Reply-To: <20200929224355.1224017-1-philmd@redhat.com> Since the support of SYS_READC in commit 8de702cb67 the semihosting code is strongly depedent of the TCG accelerator via a call to cpu_loop_exit(). Ideally we would only build semihosting support when TCG is available, but unfortunately this is not trivial because semihosting is used by many targets in different configurations. For now add a simple stub to avoid link failure when building with --disable-tcg: hw/semihosting/console.c:160: undefined reference to `cpu_loop_exit' Cc: Keith Packard <keithp@keithp.com> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com> --- accel/stubs/tcg-stub.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/accel/stubs/tcg-stub.c b/accel/stubs/tcg-stub.c index e4bbf997aa..1eec7fb90e 100644 --- a/accel/stubs/tcg-stub.c +++ b/accel/stubs/tcg-stub.c @@ -29,3 +29,8 @@ void *probe_access(CPUArchState *env, target_ulong addr, int size, /* Handled by hardware accelerator. */ g_assert_not_reached(); } + +void cpu_loop_exit(CPUState *cpu) +{ + g_assert_not_reached(); +} -- 2.26.2
next prev parent reply other threads:[~2020-09-29 22:44 UTC|newest] Thread overview: 70+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-09-29 22:43 [PATCH v4 00/12] Support disabling TCG on ARM (part 2) Philippe Mathieu-Daudé 2020-09-29 22:43 ` Philippe Mathieu-Daudé 2020-09-29 22:43 ` Philippe Mathieu-Daudé [this message] 2020-09-29 22:43 ` [PATCH v4 01/12] accel/tcg: Add stub for cpu_loop_exit() Philippe Mathieu-Daudé 2020-09-30 7:08 ` Thomas Huth 2020-09-30 7:08 ` Thomas Huth 2020-10-03 9:09 ` Richard Henderson 2020-10-03 9:09 ` Richard Henderson 2020-09-29 22:43 ` [PATCH v4 02/12] meson: Allow optional target/${ARCH}/Kconfig Philippe Mathieu-Daudé 2020-09-29 22:43 ` Philippe Mathieu-Daudé 2020-09-30 12:50 ` Claudio Fontana 2020-09-30 12:50 ` Claudio Fontana 2020-09-30 13:17 ` Paolo Bonzini 2020-09-30 13:17 ` Paolo Bonzini 2020-10-03 9:13 ` Richard Henderson 2020-10-03 9:13 ` Richard Henderson 2020-10-03 9:15 ` Paolo Bonzini 2020-10-03 9:15 ` Paolo Bonzini 2020-10-03 9:32 ` Richard Henderson 2020-10-03 9:32 ` Richard Henderson 2020-09-29 22:43 ` [PATCH v4 03/12] target/arm: Select SEMIHOSTING if TCG is available Philippe Mathieu-Daudé 2020-09-29 22:43 ` Philippe Mathieu-Daudé 2020-10-03 9:43 ` Richard Henderson 2020-10-03 9:43 ` Richard Henderson 2020-09-29 22:43 ` [PATCH v4 04/12] target/arm: Restrict ARMv4 cpus to TCG accel Philippe Mathieu-Daudé 2020-09-29 22:43 ` Philippe Mathieu-Daudé 2020-09-30 8:03 ` Philippe Mathieu-Daudé 2020-09-30 8:03 ` Philippe Mathieu-Daudé 2020-10-03 9:17 ` Thomas Huth 2020-10-03 9:17 ` Thomas Huth 2020-09-29 22:43 ` [PATCH v4 05/12] target/arm: Restrict ARMv5 " Philippe Mathieu-Daudé 2020-09-29 22:43 ` Philippe Mathieu-Daudé 2020-09-29 22:43 ` [PATCH v4 06/12] target/arm: Restrict ARMv6 " Philippe Mathieu-Daudé 2020-09-29 22:43 ` Philippe Mathieu-Daudé 2020-09-29 22:43 ` [PATCH v4 07/12] target/arm: Restrict ARMv7 R-profile " Philippe Mathieu-Daudé 2020-09-29 22:43 ` Philippe Mathieu-Daudé 2020-09-29 22:43 ` [PATCH v4 08/12] target/arm: Restrict ARMv7 M-profile " Philippe Mathieu-Daudé 2020-09-29 22:43 ` Philippe Mathieu-Daudé 2020-09-29 22:43 ` [PATCH v4 09/12] target/arm: Make m_helper.c optional via CONFIG_ARM_V7M Philippe Mathieu-Daudé 2020-09-29 22:43 ` Philippe Mathieu-Daudé 2020-10-03 9:48 ` Richard Henderson 2020-10-03 9:48 ` Richard Henderson 2021-01-29 18:53 ` Philippe Mathieu-Daudé 2021-01-29 18:53 ` Philippe Mathieu-Daudé 2020-09-29 22:43 ` [PATCH v4 10/12] target/arm: Do not build TCG objects when TCG is off Philippe Mathieu-Daudé 2020-09-29 22:43 ` Philippe Mathieu-Daudé 2020-10-03 9:52 ` Richard Henderson 2020-10-03 9:52 ` Richard Henderson 2020-09-29 22:43 ` [PATCH v4 11/12] target/arm: Reorder meson.build rules Philippe Mathieu-Daudé 2020-09-29 22:43 ` Philippe Mathieu-Daudé 2020-10-03 9:53 ` Richard Henderson 2020-10-03 9:53 ` Richard Henderson 2020-09-29 22:43 ` [PATCH v4 12/12] .travis.yml: Add a KVM-only Aarch64 job Philippe Mathieu-Daudé 2020-09-29 22:43 ` Philippe Mathieu-Daudé 2020-10-03 10:03 ` Richard Henderson 2020-10-03 10:03 ` Richard Henderson 2020-10-03 10:14 ` Thomas Huth 2020-10-03 10:14 ` Thomas Huth 2020-10-03 10:37 ` Richard Henderson 2020-10-03 10:37 ` Richard Henderson 2020-09-30 7:58 ` [PATCH v4 00/12] Support disabling TCG on ARM (part 2) Igor Mammedov 2020-09-30 7:58 ` Igor Mammedov 2020-09-30 10:20 ` Philippe Mathieu-Daudé 2020-09-30 10:20 ` Philippe Mathieu-Daudé 2021-01-28 0:41 ` Alex Bennée 2021-01-28 0:41 ` Alex Bennée 2021-01-28 11:02 ` Philippe Mathieu-Daudé 2021-01-28 11:02 ` Philippe Mathieu-Daudé 2021-01-28 15:42 ` Alex Bennée 2021-01-28 15:42 ` Alex Bennée
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200929224355.1224017-2-philmd@redhat.com \ --to=philmd@redhat.com \ --cc=alex.bennee@linaro.org \ --cc=fam@euphon.net \ --cc=keithp@keithp.com \ --cc=kvm@vger.kernel.org \ --cc=pbonzini@redhat.com \ --cc=peter.maydell@linaro.org \ --cc=qemu-arm@nongnu.org \ --cc=qemu-devel@nongnu.org \ --cc=richard.henderson@linaro.org \ --cc=rth@twiddle.net \ --cc=thuth@redhat.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.