From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9A265C4363D for ; Wed, 30 Sep 2020 22:03:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 56BC32075F for ; Wed, 30 Sep 2020 22:03:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730941AbgI3WDv (ORCPT ); Wed, 30 Sep 2020 18:03:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46960 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730090AbgI3WDv (ORCPT ); Wed, 30 Sep 2020 18:03:51 -0400 Received: from shards.monkeyblade.net (shards.monkeyblade.net [IPv6:2620:137:e000::1:9]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A0643C061755; Wed, 30 Sep 2020 15:03:51 -0700 (PDT) Received: from localhost (unknown [IPv6:2601:601:9f00:477::3d5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 6689213C732A9; Wed, 30 Sep 2020 14:47:02 -0700 (PDT) Date: Wed, 30 Sep 2020 15:03:49 -0700 (PDT) Message-Id: <20200930.150349.1490001851325231827.davem@davemloft.net> To: calvin.johnson@oss.nxp.com Cc: grant.likely@arm.com, rafael@kernel.org, jeremy.linton@arm.com, andrew@lunn.ch, andy.shevchenko@gmail.com, f.fainelli@gmail.com, linux@armlinux.org.uk, cristian.sovaiala@nxp.com, florinlaurentiu.chiculita@nxp.com, ioana.ciornei@nxp.com, madalin.bucur@oss.nxp.com, heikki.krogerus@linux.intel.com, linux-kernel@vger.kernel.org, linux.cj@gmail.com, netdev@vger.kernel.org, linux-acpi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, diana.craciun@nxp.com, laurentiu.tudor@nxp.com, hkallweit1@gmail.com, kuba@kernel.org Subject: Re: [net-next PATCH v1 2/7] net: phy: Introduce phy related fwnode functions From: David Miller In-Reply-To: <20200930160430.7908-3-calvin.johnson@oss.nxp.com> References: <20200930160430.7908-1-calvin.johnson@oss.nxp.com> <20200930160430.7908-3-calvin.johnson@oss.nxp.com> X-Mailer: Mew version 6.8 on Emacs 27.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [2620:137:e000::1:9]); Wed, 30 Sep 2020 14:47:03 -0700 (PDT) Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org From: Calvin Johnson Date: Wed, 30 Sep 2020 21:34:25 +0530 > +struct phy_device *fwnode_phy_find_device(struct fwnode_handle *phy_fwnode) > +{ > + struct device *d; > + struct mdio_device *mdiodev; Please use reverse christmas tree ordering for local variables. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7E36FC4727C for ; Wed, 30 Sep 2020 22:05:32 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 144442076A for ; Wed, 30 Sep 2020 22:05:32 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="rfGC/sxV" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 144442076A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=davemloft.net Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Mime-Version:References:In-Reply-To:From:Subject:To: Message-Id:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=V1alVdvrLt0H9blbBlobRrt2dRMB2kvYa2MpeNzqumc=; b=rfGC/sxVEmoCm6de7XIdM8RRL qm5EimbNRjJpFRUeVg5lF2MVm8dgW8toiqI05XhPD36LJrBT9vFfxxAYT81gd4TPoYV3DR/2RcdBc hRADdEzuFI7MOndMwv627PwePw/UCHomiQquCpFuxVmI75Zw8G2+3dNm5of7YAPBWcctxI5nM7+ic 7oYhZoL3Kt194kWGASH4yoMHHKcOlafTtBGdST9i5viX01uPnhS2W+vsf95Uw3dAo3hPjgQB1EJVl xp6eMimAqipooMwiUlNbKbH3U69NXOgxao6zJHirCRCRdLhEvq94Xenlb1SxHSh9mjGdRyg9i7dWs IHKRoCR9A==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kNkCh-0003wl-9r; Wed, 30 Sep 2020 22:04:03 +0000 Received: from shards.monkeyblade.net ([2620:137:e000::1:9]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kNkCe-0003vQ-LU for linux-arm-kernel@lists.infradead.org; Wed, 30 Sep 2020 22:04:01 +0000 Received: from localhost (unknown [IPv6:2601:601:9f00:477::3d5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 6689213C732A9; Wed, 30 Sep 2020 14:47:02 -0700 (PDT) Date: Wed, 30 Sep 2020 15:03:49 -0700 (PDT) Message-Id: <20200930.150349.1490001851325231827.davem@davemloft.net> To: calvin.johnson@oss.nxp.com Subject: Re: [net-next PATCH v1 2/7] net: phy: Introduce phy related fwnode functions From: David Miller In-Reply-To: <20200930160430.7908-3-calvin.johnson@oss.nxp.com> References: <20200930160430.7908-1-calvin.johnson@oss.nxp.com> <20200930160430.7908-3-calvin.johnson@oss.nxp.com> X-Mailer: Mew version 6.8 on Emacs 27.1 Mime-Version: 1.0 X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [2620:137:e000::1:9]); Wed, 30 Sep 2020 14:47:03 -0700 (PDT) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200930_180400_932406_62798F65 X-CRM114-Status: UNSURE ( 8.47 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: andrew@lunn.ch, f.fainelli@gmail.com, kuba@kernel.org, rafael@kernel.org, madalin.bucur@oss.nxp.com, netdev@vger.kernel.org, linux@armlinux.org.uk, jeremy.linton@arm.com, linux-kernel@vger.kernel.org, diana.craciun@nxp.com, linux-acpi@vger.kernel.org, andy.shevchenko@gmail.com, grant.likely@arm.com, linux.cj@gmail.com, ioana.ciornei@nxp.com, heikki.krogerus@linux.intel.com, hkallweit1@gmail.com, laurentiu.tudor@nxp.com, cristian.sovaiala@nxp.com, linux-arm-kernel@lists.infradead.org, florinlaurentiu.chiculita@nxp.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: Calvin Johnson Date: Wed, 30 Sep 2020 21:34:25 +0530 > +struct phy_device *fwnode_phy_find_device(struct fwnode_handle *phy_fwnode) > +{ > + struct device *d; > + struct mdio_device *mdiodev; Please use reverse christmas tree ordering for local variables. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel