From: Jason Gunthorpe <jgg@nvidia.com>
To: Yishai Hadas <yishaih@nvidia.com>
Cc: Leon Romanovsky <leon@kernel.org>,
Doug Ledford <dledford@redhat.com>, <linux-rdma@vger.kernel.org>,
Christoph Hellwig <hch@infradead.org>
Subject: Re: [PATCH rdma-next v2 1/4] IB/core: Improve ODP to use hmm_range_fault()
Date: Tue, 29 Sep 2020 21:37:44 -0300 [thread overview]
Message-ID: <20200930003744.GB816047@nvidia.com> (raw)
In-Reply-To: <ec93e0f2-22c5-ac93-3a3a-8874ab7d8aa6@nvidia.com>
On Tue, Sep 29, 2020 at 11:30:24PM +0300, Yishai Hadas wrote:
> > > flags. (see ODP_DMA_ADDR_MASK). Also, if we went through a
> > > read->write access without invalidation why do we need to mask at
> > > all ? the new access_mask should have the write access.
> > Feels like a good idea to be safe here
> It followed your note from V1 that the extra mask was really redundant, the
> original code also didn't have it, but up-to-you.
It wasn't hard to read from the diff that this was being done in all
cases, not just as the result of ib_dma_map_page(). This is why I
think it would be clearer with the control flow I suggested
> > > > And all the pr_debugs around this code being touched should become
> > > > mlx5_ib_dbg
> > > We are in IB core, why mlx5_ib_debug ?
> > oops, dev_dbg
> Can it can done locally ?
As long as the ib_device is avaiable the print function should be used
Actually it is ibdev_dbg() these days
Jason
next prev parent reply other threads:[~2020-09-30 0:37 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-22 8:21 [PATCH rdma-next v2 0/4] Improve ODP by using HMM API Leon Romanovsky
2020-09-22 8:21 ` [PATCH rdma-next v2 1/4] IB/core: Improve ODP to use hmm_range_fault() Leon Romanovsky
2020-09-29 17:59 ` Jason Gunthorpe
2020-09-29 18:02 ` Christoph Hellwig
2020-09-29 18:13 ` Jason Gunthorpe
2020-09-29 18:15 ` Christoph Hellwig
2020-09-29 18:27 ` Jason Gunthorpe
2020-09-29 20:20 ` Yishai Hadas
2020-09-29 19:27 ` Jason Gunthorpe
2020-09-29 20:09 ` Yishai Hadas
2020-09-29 20:13 ` Jason Gunthorpe
2020-09-29 20:30 ` Yishai Hadas
2020-09-30 0:37 ` Jason Gunthorpe [this message]
2020-09-29 21:34 ` Yishai Hadas
2020-09-30 0:35 ` Jason Gunthorpe
2020-09-30 7:32 ` Yishai Hadas
2020-09-22 8:21 ` [PATCH rdma-next v2 2/4] IB/core: Enable ODP sync without faulting Leon Romanovsky
2020-09-22 8:21 ` [PATCH rdma-next v2 3/4] RDMA/mlx5: Extend advice MR to support non faulting mode Leon Romanovsky
2020-09-22 8:21 ` [PATCH rdma-next v2 4/4] RDMA/mlx5: Sync device with CPU pages upon ODP MR registration Leon Romanovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200930003744.GB816047@nvidia.com \
--to=jgg@nvidia.com \
--cc=dledford@redhat.com \
--cc=hch@infradead.org \
--cc=leon@kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=yishaih@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.