From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7EF32C4727E for ; Wed, 30 Sep 2020 11:59:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 45D5C2075F for ; Wed, 30 Sep 2020 11:59:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729382AbgI3L7o (ORCPT ); Wed, 30 Sep 2020 07:59:44 -0400 Received: from mga04.intel.com ([192.55.52.120]:22014 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729372AbgI3L7o (ORCPT ); Wed, 30 Sep 2020 07:59:44 -0400 IronPort-SDR: GT0V0zrL41J9/jxByVazz5ixAttefc8tmetxBZy/FW0lzSRmLlhfoSoDfbcV94B31adgB8uUoB 5Zhw0x4CqBgQ== X-IronPort-AV: E=McAfee;i="6000,8403,9759"; a="159814765" X-IronPort-AV: E=Sophos;i="5.77,322,1596524400"; d="scan'208";a="159814765" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Sep 2020 04:59:43 -0700 IronPort-SDR: gu367M5H2ZN4V7avZSxV5vhUUKmsscYKkex41phaa8EYkUSvBzRcdNs7o+aVxO7VqxRbqeRA3T UB8Fky3LGTiQ== X-IronPort-AV: E=Sophos;i="5.77,322,1596524400"; d="scan'208";a="497212937" Received: from lbentzio-mobl.ger.corp.intel.com (HELO localhost) ([10.252.32.88]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Sep 2020 04:59:41 -0700 Date: Wed, 30 Sep 2020 14:59:39 +0300 From: Jarkko Sakkinen To: Petr Vorel Cc: ltp@lists.linux.it, Lakshmi Ramasubramanian , Mimi Zohar , linux-integrity@vger.kernel.org, James Bottomley , Greg Kroah-Hartman Subject: Re: [PATCH v3 0/4] TPM 2.0 fixes in IMA tests Message-ID: <20200930115939.GB7612@linux.intel.com> References: <20200929165021.11731-1-pvorel@suse.cz> <20200929231118.GA805493@linux.intel.com> <20200930055314.GA21664@dell5510> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200930055314.GA21664@dell5510> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-integrity@vger.kernel.org On Wed, Sep 30, 2020 at 07:53:14AM +0200, Petr Vorel wrote: > Hi Jarkko, > > > Hi, is there something specific I should look at in this patch set? > > I'm sorry to bother you with LTP specific code. Can you have a quick look if I > didn't overlook anything obvious in reading PCR files (read_pcr_tpm*())? > > I'm surprised that it's working on my TPM 2.0 which does not export > /sys/kernel/security/tpm0/binary_bios_measurements (using evmctl). Thank you, this was actually really important remark and reminder. OK so I think James' patch is stuck because of me, i.e. https://lore.kernel.org/linux-integrity/20200911114820.GB6877@linux.intel.com/ I'm sorry about this. The final final conclusion is that the way it exports PCRs is just fine. Can you test this version? https://patchwork.kernel.org/patch/11759729/ I can then add reviewd-by and apply it and you don't have to do any sort of stupid hacks. /Jarkkko From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jarkko Sakkinen Date: Wed, 30 Sep 2020 14:59:39 +0300 Subject: [LTP] [PATCH v3 0/4] TPM 2.0 fixes in IMA tests In-Reply-To: <20200930055314.GA21664@dell5510> References: <20200929165021.11731-1-pvorel@suse.cz> <20200929231118.GA805493@linux.intel.com> <20200930055314.GA21664@dell5510> Message-ID: <20200930115939.GB7612@linux.intel.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: ltp@lists.linux.it On Wed, Sep 30, 2020 at 07:53:14AM +0200, Petr Vorel wrote: > Hi Jarkko, > > > Hi, is there something specific I should look at in this patch set? > > I'm sorry to bother you with LTP specific code. Can you have a quick look if I > didn't overlook anything obvious in reading PCR files (read_pcr_tpm*())? > > I'm surprised that it's working on my TPM 2.0 which does not export > /sys/kernel/security/tpm0/binary_bios_measurements (using evmctl). Thank you, this was actually really important remark and reminder. OK so I think James' patch is stuck because of me, i.e. https://lore.kernel.org/linux-integrity/20200911114820.GB6877@linux.intel.com/ I'm sorry about this. The final final conclusion is that the way it exports PCRs is just fine. Can you test this version? https://patchwork.kernel.org/patch/11759729/ I can then add reviewd-by and apply it and you don't have to do any sort of stupid hacks. /Jarkkko