From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7C0F6C4727C for ; Wed, 30 Sep 2020 20:45:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3CB482064E for ; Wed, 30 Sep 2020 20:45:08 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="N1JSnjgI" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730291AbgI3UpH (ORCPT ); Wed, 30 Sep 2020 16:45:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34760 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725872AbgI3UpG (ORCPT ); Wed, 30 Sep 2020 16:45:06 -0400 Received: from mail-pg1-x543.google.com (mail-pg1-x543.google.com [IPv6:2607:f8b0:4864:20::543]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A608BC0613D1 for ; Wed, 30 Sep 2020 13:45:06 -0700 (PDT) Received: by mail-pg1-x543.google.com with SMTP id s31so1868334pga.7 for ; Wed, 30 Sep 2020 13:45:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=JgQmmymEepmTyKfdtmZJjASTO5kyTURiWqToh5meDKE=; b=N1JSnjgIbsN1xv7O/7f3T3QNscpYc+Oc8Onavg+xJhKmu87Vl5txC0mRnj581yP+T5 vji39GuQ54k3KnvTyItbHHJyjV7n/9yiIdpidKzXo0JDXhzi+h96aiFk9fi64j8d2bCt gMDMVPAGpbUo9icFxVDwyRsfPfCjPc7VT3l7U= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=JgQmmymEepmTyKfdtmZJjASTO5kyTURiWqToh5meDKE=; b=IwSZs9tECB5jrrcN82ci2wAYF4S2+jsSZ4gVecvS9vaV7jTWZD2ClPrvnb0vM2IR8h ZEyJfYitfMs9dhnChn6Yva2LGkOCLtmH8QGfOPTBDOtXhVze8HvnQ6bALpOiD/+ba24R fnGwFxIOuuBUIc0YfuWulJJeUn6gZJXq4d8aXjtsN3Nr+4qBc+KNakrpgiGkoyj95F3s kov63WSMHxQ6FWQ7kea65IplBJkWpC+qeMPfejHFkb+SDQsqOdKwi+iEz/Fol8nRkcXJ 9c1PxyrINI8+48n/3FGkiHvgdr6mg4uN63ZNs+3zkoVL684GMI7ppFpXqxES6y6vWiTH CL8A== X-Gm-Message-State: AOAM532EIe9uJGD2SNu60MpT0KTjQrx8yfT8xbos3MF5eUw0gb9fJvFD 6ai+jL1yhBtUIsxuFN8hbyB6jw== X-Google-Smtp-Source: ABdhPJwj25UpjOCh8s4y4qnI0EKHGhfilZz0SCC4DlHMi6btWQ6hwRXxTigXsih3jOgTEpH2lz1kwQ== X-Received: by 2002:a63:4d4a:: with SMTP id n10mr3430255pgl.96.1601498706030; Wed, 30 Sep 2020 13:45:06 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id g24sm3730158pfk.65.2020.09.30.13.45.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 30 Sep 2020 13:45:05 -0700 (PDT) Date: Wed, 30 Sep 2020 13:45:04 -0700 From: Kees Cook To: Sami Tolvanen Cc: Masahiro Yamada , Will Deacon , Steven Rostedt , Peter Zijlstra , Greg Kroah-Hartman , "Paul E. McKenney" , Nick Desaulniers , clang-built-linux@googlegroups.com, kernel-hardening@lists.openwall.com, linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, x86@kernel.org Subject: Re: [PATCH v4 10/29] treewide: remove DISABLE_LTO Message-ID: <202009301344.3949D2FA8@keescook> References: <20200929214631.3516445-1-samitolvanen@google.com> <20200929214631.3516445-11-samitolvanen@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200929214631.3516445-11-samitolvanen@google.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Sep 29, 2020 at 02:46:12PM -0700, Sami Tolvanen wrote: > This change removes all instances of DISABLE_LTO from > Makefiles, as they are currently unused, and the preferred > method of disabling LTO is to filter out the flags instead. > > Suggested-by: Kees Cook > Signed-off-by: Sami Tolvanen Thanks! I think this makes things cleaner in the later patches. :) Reviewed-by: Kees Cook -- Kees Cook From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BE7DEC4363D for ; Wed, 30 Sep 2020 20:46:34 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6709B2071E for ; Wed, 30 Sep 2020 20:46:34 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Xap0/jkq"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="N1JSnjgI" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6709B2071E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=wZ1b5s21rfeL9HUtCs6hQ8KgNmgyxSSMZ8s4ww6nPkM=; b=Xap0/jkqED5WSFbxz4+7GtZ9z zdMO2qofe67z3BsE0T50ckBiKZCLMVulHtRIzSOIf5zTI9GvBGePyUAr9b5GFJpHQ9crmKQBYqeKp 74yajCz5ekFX/X2LFwXSN//2bZvPsiTbtdaxMWlZ6SVv90NE8senPV+hR/1R8qS2zxKAWBiqEN6BF 6uPP1HXWY1kbkQx6kYfDn2YkYRCL6ZVBmJvHu4PzIZz6BB92YVokeRb5WlsuwxcUpv8VV+KJw3ZrD AsBJN8Ep4MptknupyPUBlqfpxE5xqNGiLwEul5xvT4c0ldEUkd+4EKYCa1qvJwPrSSQ07ZVpQH9Yu VqczNq3bA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kNiyO-0004Op-Cz; Wed, 30 Sep 2020 20:45:12 +0000 Received: from mail-pg1-x541.google.com ([2607:f8b0:4864:20::541]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kNiyL-0004N6-QC for linux-arm-kernel@lists.infradead.org; Wed, 30 Sep 2020 20:45:10 +0000 Received: by mail-pg1-x541.google.com with SMTP id 5so1873182pgf.5 for ; Wed, 30 Sep 2020 13:45:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=JgQmmymEepmTyKfdtmZJjASTO5kyTURiWqToh5meDKE=; b=N1JSnjgIbsN1xv7O/7f3T3QNscpYc+Oc8Onavg+xJhKmu87Vl5txC0mRnj581yP+T5 vji39GuQ54k3KnvTyItbHHJyjV7n/9yiIdpidKzXo0JDXhzi+h96aiFk9fi64j8d2bCt gMDMVPAGpbUo9icFxVDwyRsfPfCjPc7VT3l7U= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=JgQmmymEepmTyKfdtmZJjASTO5kyTURiWqToh5meDKE=; b=BtzQTKgsh5jyvkFRvuLs/sjuzDGb0N3evmsXjfbCCML/KUzj+8iUSoIV1nOlutIytP jqMDxKcHnNouVPwByJDTWgVjHU9w5AjEmxCsUMGnzAAolsD6rOjecFXNhR10gk8BTitF BxhOp6HmfE3qv0E0g0DgpMPgstZAIDys8lJKiTHSS8Zh3BLmRZpg78AFmwbM+1pOKKR2 i7I4zexFN/F0a+9P1VwJPjSVprt9t4VLDU8hpbW6chW1Xs0PwJoBAmTiHZQEwIT9ToxG 6wgjl6/CheynTCYlSRSX0s7eOmktPE7pR9rsOIBn4Bn6TNbDrHIBJBPn7wFfbmIHUYmj dv/w== X-Gm-Message-State: AOAM530i5cTom3kG0rZXv4QoHBF6Tjw3zf+FShc3e5WfYOiujW95YCSi DRmGSk4W7FSq+j93UFqitE7p/A== X-Google-Smtp-Source: ABdhPJwj25UpjOCh8s4y4qnI0EKHGhfilZz0SCC4DlHMi6btWQ6hwRXxTigXsih3jOgTEpH2lz1kwQ== X-Received: by 2002:a63:4d4a:: with SMTP id n10mr3430255pgl.96.1601498706030; Wed, 30 Sep 2020 13:45:06 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id g24sm3730158pfk.65.2020.09.30.13.45.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 30 Sep 2020 13:45:05 -0700 (PDT) Date: Wed, 30 Sep 2020 13:45:04 -0700 From: Kees Cook To: Sami Tolvanen Subject: Re: [PATCH v4 10/29] treewide: remove DISABLE_LTO Message-ID: <202009301344.3949D2FA8@keescook> References: <20200929214631.3516445-1-samitolvanen@google.com> <20200929214631.3516445-11-samitolvanen@google.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200929214631.3516445-11-samitolvanen@google.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200930_164509_864622_F3335989 X-CRM114-Status: GOOD ( 12.56 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-arch@vger.kernel.org, x86@kernel.org, "Paul E. McKenney" , kernel-hardening@lists.openwall.com, Peter Zijlstra , Greg Kroah-Hartman , Masahiro Yamada , linux-kbuild@vger.kernel.org, Nick Desaulniers , linux-kernel@vger.kernel.org, Steven Rostedt , clang-built-linux@googlegroups.com, linux-pci@vger.kernel.org, Will Deacon , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Sep 29, 2020 at 02:46:12PM -0700, Sami Tolvanen wrote: > This change removes all instances of DISABLE_LTO from > Makefiles, as they are currently unused, and the preferred > method of disabling LTO is to filter out the flags instead. > > Suggested-by: Kees Cook > Signed-off-by: Sami Tolvanen Thanks! I think this makes things cleaner in the later patches. :) Reviewed-by: Kees Cook -- Kees Cook _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel