All of lore.kernel.org
 help / color / mirror / Atom feed
From: Guchun Chen <guchun.chen@amd.com>
To: amd-gfx@lists.freedesktop.org, alexander.deucher@amd.com,
	Tom.StDenis@amd.com
Cc: Guchun Chen <guchun.chen@amd.com>
Subject: [PATCH] drm/amdgpu: fix build error
Date: Wed, 30 Sep 2020 21:58:34 +0800	[thread overview]
Message-ID: <20200930135834.6917-1-guchun.chen@amd.com> (raw)

Regression by patch:
fd583c4f01a7 drm/amdgpu: drop duplicated ecc check for vega10 (v4)

CC [M]  drivers/gpu/drm/amd/amdgpu/gfxhub_v2_1.o
drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c: In function ‘gmc_v9_0_late_init’:
drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c:1216:59: error: expected ‘)’ before ‘{’ token
 1216 |   if (!(adev->ras_features & (1 << AMDGPU_RAS_BLOCK__UMC)) {
      |      ~                                                    ^~
      |                                                           )
drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c:1220:2: error: expected expression before ‘}’ token
 1220 |  }
      |  ^
  CC [M]  drivers/gpu/drm/amd/amdgpu/umc_v6_1.o

Signed-off-by: Guchun Chen <guchun.chen@amd.com>
---
 drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c b/drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c
index 151686888c32..6e9de02d5455 100644
--- a/drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c
+++ b/drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c
@@ -1213,7 +1213,7 @@ static int gmc_v9_0_late_init(void *handle)
 	 * writes, while disables HBM ECC for vega10.
 	 */
 	if (!amdgpu_sriov_vf(adev) && (adev->asic_type == CHIP_VEGA10)) {
-		if (!(adev->ras_features & (1 << AMDGPU_RAS_BLOCK__UMC)) {
+		if (!(adev->ras_features & (1 << AMDGPU_RAS_BLOCK__UMC))) {
 			if (adev->df.funcs->enable_ecc_force_par_wr_rmw)
 				adev->df.funcs->enable_ecc_force_par_wr_rmw(adev, false);
 		}
-- 
2.17.1

_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

             reply	other threads:[~2020-09-30 13:58 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-30 13:58 Guchun Chen [this message]
2020-09-30 14:02 ` [PATCH] drm/amdgpu: fix build error Zhang, Hawking
2021-07-22  9:25 Guchun Chen
2021-07-22 14:14 ` Luben Tuikov
2021-07-22 14:22   ` Chen, Guchun
2021-07-22 14:43     ` Luben Tuikov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200930135834.6917-1-guchun.chen@amd.com \
    --to=guchun.chen@amd.com \
    --cc=Tom.StDenis@amd.com \
    --cc=alexander.deucher@amd.com \
    --cc=amd-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.