From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 07034C4741F for ; Wed, 30 Sep 2020 21:10:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BE7F92076A for ; Wed, 30 Sep 2020 21:10:37 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="aznXL+Mf" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730404AbgI3VKg (ORCPT ); Wed, 30 Sep 2020 17:10:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38666 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728031AbgI3VKg (ORCPT ); Wed, 30 Sep 2020 17:10:36 -0400 Received: from mail-pf1-x441.google.com (mail-pf1-x441.google.com [IPv6:2607:f8b0:4864:20::441]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 69EDBC0613D2 for ; Wed, 30 Sep 2020 14:10:36 -0700 (PDT) Received: by mail-pf1-x441.google.com with SMTP id q123so2180669pfb.0 for ; Wed, 30 Sep 2020 14:10:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=43NmDXRdfvytQQYY6+SkI5I3v0G1ZKlfq1R/B+8Rbe8=; b=aznXL+Mf1oo937XoxBdAUWYbrGQBox+mHPLXOBi8fxELvJxmtN4Oh2fdCubtsfNRrA rDHSxjRXgFROvxwZKbrgkOQaw+IdYULTR8nRNYUFnd02K6q1DKbVRP6qGTIrAq/ntqIt uicIip4Sy8y/dZqila87XWTqZiy3eaEQT/WgQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=43NmDXRdfvytQQYY6+SkI5I3v0G1ZKlfq1R/B+8Rbe8=; b=l9gceFbxgEYgBuxg0fgHG0JZBJCu2AIEx9YVYGgTLnoprOrmVhtsVGJaBfpcBaQPRr USu4w5ZSmcELcHyP5Hj2AyFj8I8i/xv1UjkoC+i7GBoVQmMQ4PqUScXND6utPyBjx3dO MZcrHJnMGijESAAPH5F4Tnp8W75MF+8yr191UFEcfUQpCkbuBfK5Oy59sWEKIrS9rGg/ ZeR58uiKE5vWUu8rtsFyCQvDjQ9f0f599p+bc3onxlukCaXIKfySVnIJl8tISFLCJvMV IS/SWWdls6gkilfVrFRClyvXvKHqtK/63s/VZpWnlOxVrPVxG7ERFGfs5OjExw4OgM2R LrVA== X-Gm-Message-State: AOAM530ddSgy/ITYyux9iyoREtgLQsWD1Nm47KFV5iOLP3Rg8KUWgfyv X+wBFLjIVtHTkzI+m8fi86Kyrw== X-Google-Smtp-Source: ABdhPJyw4kR2hvM1gD9zLPKC5ogvJTlrWuluJmqFM9fB7y/1oreMiPXLmURVREruQgKi3Vr48qMMIg== X-Received: by 2002:a17:902:c40d:b029:d2:562d:db9 with SMTP id k13-20020a170902c40db02900d2562d0db9mr4239380plk.46.1601500235715; Wed, 30 Sep 2020 14:10:35 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id n2sm3182853pja.41.2020.09.30.14.10.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 30 Sep 2020 14:10:34 -0700 (PDT) Date: Wed, 30 Sep 2020 14:10:33 -0700 From: Kees Cook To: Peter Zijlstra , Steven Rostedt Cc: Sami Tolvanen , Masahiro Yamada , Will Deacon , Greg Kroah-Hartman , "Paul E. McKenney" , Nick Desaulniers , clang-built-linux@googlegroups.com, kernel-hardening@lists.openwall.com, linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, x86@kernel.org Subject: Re: [PATCH v4 00/29] Add support for Clang LTO Message-ID: <202009301402.27A40DD1@keescook> References: <20200929214631.3516445-1-samitolvanen@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200929214631.3516445-1-samitolvanen@google.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Sep 29, 2020 at 02:46:02PM -0700, Sami Tolvanen wrote: > Furthermore, patches 4-8 include Peter's patch for generating > __mcount_loc with objtool, and build system changes to enable it on > x86. With these patches, we no longer need to annotate functions > that have non-call references to __fentry__ with LTO, which makes > supporting dynamic ftrace much simpler. Peter, can you take patches 4-8 into -tip? I think it'd make sense to keep them together. Steven, it sounds like you're okay with the changes (i.e. Sami showed the one concern you had was already handled)? Getting these into v5.10 would be really really nice. I'd really like to get the tree-spanning prerequisites nailed down for this series. It's been difficult to coordinate given the multiple maintainers. :) Specifically these patches: Peter Zijlstra (1): objtool: Add a pass for generating __mcount_loc Sami Tolvanen (4): objtool: Don't autodetect vmlinux.o tracing: move function tracer options to Kconfig tracing: add support for objtool mcount x86, build: use objtool mcount https://lore.kernel.org/lkml/20200929214631.3516445-5-samitolvanen@google.com/ https://lore.kernel.org/lkml/20200929214631.3516445-6-samitolvanen@google.com/ https://lore.kernel.org/lkml/20200929214631.3516445-7-samitolvanen@google.com/ https://lore.kernel.org/lkml/20200929214631.3516445-8-samitolvanen@google.com/ https://lore.kernel.org/lkml/20200929214631.3516445-9-samitolvanen@google.com/ Thanks! -- Kees Cook From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E5752C4363D for ; Wed, 30 Sep 2020 21:12:17 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8BA5B2071E for ; Wed, 30 Sep 2020 21:12:17 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="eVHqYAwP"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="aznXL+Mf" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8BA5B2071E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=xTz/PdGPSUXBPOLhtaJD0os8EgO4WqpULDnmUq1b3/U=; b=eVHqYAwPw2Z1K49XYhEV5qjeR TW5DEs5BnKVa3GQXy4R/CUKPpfr9q8HB4dncqSJhPjuUKsa97bVh8/TjHcajoPLJMEPQdV942Fv2Z EkV9E1nhNmz9HeQ1ZGjQA8s1hxqxVPK2K9rzpYAN9itQvHjOx9TL+8EkTJt3UCoihHGZOzSwiKNOZ DyCmRn7adbQtYL+zdaiqaCXo6SOPTqmt84vwQ5rRRCDhVO7XN9pSCw4VFkANdu9HqxxK5y6cS6JDf yrv1db6v1iScx2J4V2nrMnVhZcK2QlF5t2l1Uv3nTFcFnKuf/icSzVftxxJ1ZTHX5fX4DgrC6B1gq RS1daGbcw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kNjN2-0007Pr-Ld; Wed, 30 Sep 2020 21:10:40 +0000 Received: from mail-pf1-x443.google.com ([2607:f8b0:4864:20::443]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kNjMz-0007OG-NY for linux-arm-kernel@lists.infradead.org; Wed, 30 Sep 2020 21:10:38 +0000 Received: by mail-pf1-x443.google.com with SMTP id l126so2157539pfd.5 for ; Wed, 30 Sep 2020 14:10:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=43NmDXRdfvytQQYY6+SkI5I3v0G1ZKlfq1R/B+8Rbe8=; b=aznXL+Mf1oo937XoxBdAUWYbrGQBox+mHPLXOBi8fxELvJxmtN4Oh2fdCubtsfNRrA rDHSxjRXgFROvxwZKbrgkOQaw+IdYULTR8nRNYUFnd02K6q1DKbVRP6qGTIrAq/ntqIt uicIip4Sy8y/dZqila87XWTqZiy3eaEQT/WgQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=43NmDXRdfvytQQYY6+SkI5I3v0G1ZKlfq1R/B+8Rbe8=; b=jih4kVv3J9ZDsRxm7U86cr8xSBg3xMckfF2RYwMKIaPi+FNsx6ZbhngIyoPSQGlzlt Yy+ehO/+0tLmf/R9R/kXp3Glm3d1IrH2pbC5DKWxJ+rWzVp6n9uA33OZHSzuEYsScCyY KqIXNS6KzBRdHExjHfeIZ6QWVRUWZXM3KR6rVd0457+Z5HWiGkEouNqbdN4iiPTkSb69 DtND1guKbd4dM3BrNuP4Z/RS6AL0+eiaLtDe6W6D78VHFQjUVRhPYhv6AWcO4v+c7U4R /eOuHhVhHcd7Am3eKOyBf0FAZfFhs3ObPXa8ST6IrODkHyv6LZwjHqwRb19iyilqGDsz QexA== X-Gm-Message-State: AOAM533i8dqUuEcUcqjopPEi4HWeka8o6DucmWMbRP9dcWNU29l9WBxG yRK/TXuVdNHZ9ROjSebwqs0Y2g== X-Google-Smtp-Source: ABdhPJyw4kR2hvM1gD9zLPKC5ogvJTlrWuluJmqFM9fB7y/1oreMiPXLmURVREruQgKi3Vr48qMMIg== X-Received: by 2002:a17:902:c40d:b029:d2:562d:db9 with SMTP id k13-20020a170902c40db02900d2562d0db9mr4239380plk.46.1601500235715; Wed, 30 Sep 2020 14:10:35 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id n2sm3182853pja.41.2020.09.30.14.10.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 30 Sep 2020 14:10:34 -0700 (PDT) Date: Wed, 30 Sep 2020 14:10:33 -0700 From: Kees Cook To: Peter Zijlstra , Steven Rostedt Subject: Re: [PATCH v4 00/29] Add support for Clang LTO Message-ID: <202009301402.27A40DD1@keescook> References: <20200929214631.3516445-1-samitolvanen@google.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200929214631.3516445-1-samitolvanen@google.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200930_171037_779816_1849528B X-CRM114-Status: GOOD ( 16.58 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-arch@vger.kernel.org, x86@kernel.org, "Paul E. McKenney" , kernel-hardening@lists.openwall.com, Greg Kroah-Hartman , Masahiro Yamada , linux-kbuild@vger.kernel.org, Nick Desaulniers , linux-kernel@vger.kernel.org, clang-built-linux@googlegroups.com, Sami Tolvanen , linux-pci@vger.kernel.org, Will Deacon , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Sep 29, 2020 at 02:46:02PM -0700, Sami Tolvanen wrote: > Furthermore, patches 4-8 include Peter's patch for generating > __mcount_loc with objtool, and build system changes to enable it on > x86. With these patches, we no longer need to annotate functions > that have non-call references to __fentry__ with LTO, which makes > supporting dynamic ftrace much simpler. Peter, can you take patches 4-8 into -tip? I think it'd make sense to keep them together. Steven, it sounds like you're okay with the changes (i.e. Sami showed the one concern you had was already handled)? Getting these into v5.10 would be really really nice. I'd really like to get the tree-spanning prerequisites nailed down for this series. It's been difficult to coordinate given the multiple maintainers. :) Specifically these patches: Peter Zijlstra (1): objtool: Add a pass for generating __mcount_loc Sami Tolvanen (4): objtool: Don't autodetect vmlinux.o tracing: move function tracer options to Kconfig tracing: add support for objtool mcount x86, build: use objtool mcount https://lore.kernel.org/lkml/20200929214631.3516445-5-samitolvanen@google.com/ https://lore.kernel.org/lkml/20200929214631.3516445-6-samitolvanen@google.com/ https://lore.kernel.org/lkml/20200929214631.3516445-7-samitolvanen@google.com/ https://lore.kernel.org/lkml/20200929214631.3516445-8-samitolvanen@google.com/ https://lore.kernel.org/lkml/20200929214631.3516445-9-samitolvanen@google.com/ Thanks! -- Kees Cook _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel