From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BE7C9C47420 for ; Wed, 30 Sep 2020 15:02:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7CB5A206FC for ; Wed, 30 Sep 2020 15:02:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1601478140; bh=wgtBREp7GX7jbTg82MpTBnYDUzeeak3Og8bQ30VgTOo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=gLJSKoLaqd36vXTDgCC0j10Wy9Fy1ZI93x0qB9DqxQXwVGaoklhDkLoPI48FouPVM 9uezPNzFaNhybkwoKZvQx1HMqstxLQZ1s27jhGgYqFV+3d39tqAyYuvNdAjG+TDUrk TGI6dXx0YdYbQXg9y35OrOm0XJSd7PbU0SL3SrrE= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730794AbgI3PCT (ORCPT ); Wed, 30 Sep 2020 11:02:19 -0400 Received: from mail.kernel.org ([198.145.29.99]:57820 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730774AbgI3PCS (ORCPT ); Wed, 30 Sep 2020 11:02:18 -0400 Received: from localhost (fw-tnat.cambridge.arm.com [217.140.96.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id BAD8B2076B; Wed, 30 Sep 2020 15:02:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1601478138; bh=wgtBREp7GX7jbTg82MpTBnYDUzeeak3Og8bQ30VgTOo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Smk8kFJMwkYcCnbVbtfFFoTNbayV3wRb26dNEP8swsoz8DiuQYekD50RLqfuTno3G 82Z/0H6CU5WFRTM3FHCxYjJaedyNojyqkU4xV73tmkekTG6l1l67tsDldfTpLc0IVN 1IYQd0/oSlcy7XbPHi+ljZh5kXnsmRazfaegMRJo= Date: Wed, 30 Sep 2020 16:01:17 +0100 From: Mark Brown To: Serge Semin Cc: Alexey Malahov , Ramil Zaripov , Pavel Parkhomenko , Andy Shevchenko , Andy Shevchenko , Lars Povlsen , "wuxu . wu" , Feng Tang , Rob Herring , linux-spi@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 02/30] spi: dw: Use ternary op to init set_cs callback Message-ID: <20200930150117.GK4974@sirena.org.uk> References: <20200920112914.26501-1-Sergey.Semin@baikalelectronics.ru> <20200920112914.26501-3-Sergey.Semin@baikalelectronics.ru> <20200929131153.GD4799@sirena.org.uk> <20200929215553.xgst2v5ssweymlpw@mobilestation> <20200930145759.7djm5xijhg6mjtg3@mobilestation> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="jITzwD3HDGXid3BE" Content-Disposition: inline In-Reply-To: <20200930145759.7djm5xijhg6mjtg3@mobilestation> X-Cookie: Doing gets it done. User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --jITzwD3HDGXid3BE Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Sep 30, 2020 at 05:57:59PM +0300, Serge Semin wrote: > On Wed, Sep 30, 2020 at 12:55:55AM +0300, Serge Semin wrote: > > + if (dws->set_cs) > > + master->set_cs = dws->set_cs; > > + else > > + master->set_cs = dw_spi_set_cs; > Judging by having your comment on this patch you obviously didn't like the > ternary operator used to assign a default value to the set_cs callback. So I > suggested a solution, which may suit you. What do you think about it? Agree, > disagree, insist on leaving this part of the code along, etc. That looks fine. --jITzwD3HDGXid3BE Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAl90nbwACgkQJNaLcl1U h9ASfgf/QMr+QBDA7a6p663htW8/oE/VfyDebGfO+9YvBL8at6ceQjbrmSFPIY+Y p6UxWjJYM8gqayOZmJDOLwHHqs+EF56WKVfLJk2qM9vKqsDBPS99Z+Nt1G7Ufzay nqYReurEdo4zXbdbq+0yLcI6P6pBwUJOVzOcqwwxW+7gCQzWOvG+YJUawvkLscT6 cizglDz2zEc3CJCltivU6jWUcLKWSukbPQFLrxt8aYQtMZs4zu350iL/4d0aFIa1 /McGgJYh7XCVgQFioPn7IFocfrlCJETL1vz5Jdnkdr3EooihGbo+nuSDHlqk5TPW inCxg0N+muJngYfr4HY3g4VU4qzO0Q== =Pczo -----END PGP SIGNATURE----- --jITzwD3HDGXid3BE--