From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 74000C4727E for ; Wed, 30 Sep 2020 18:17:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 14CCE20738 for ; Wed, 30 Sep 2020 18:17:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1601489849; bh=P3dxAlu5+lQzDhlFGi4CakpJkda5hkqhU33DaQXs+JM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=e9O99vStc8mjf4jLwmuSV9Go0dzpeeToIxLtL9NEwZthFYJ+nt2cnXbIWdyDErczW vNCKW9g5hUGWak2MaWrSYEwOUfnI71Cld3KKnt4ths6ENnZ4/BGcLKftuNxEmoZNI3 DKnpxibSZQmr6d+JjHsRvczvOyJYwiSvjWaTNAfM= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728140AbgI3SR2 (ORCPT ); Wed, 30 Sep 2020 14:17:28 -0400 Received: from mail-ot1-f68.google.com ([209.85.210.68]:45420 "EHLO mail-ot1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725355AbgI3SR1 (ORCPT ); Wed, 30 Sep 2020 14:17:27 -0400 Received: by mail-ot1-f68.google.com with SMTP id g96so2736403otb.12; Wed, 30 Sep 2020 11:17:27 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=HfocoN8jnNi412P6cV06kFb4hY3gTbW/yUeIlx+erSw=; b=G3Jjza3vFXuc9KDdYtZD1lUtrjf70zUvJt3XLfGcnevnYQEWPFhGr/9DgdYRPQwfTO YVCDhEQh3jdBdt4sPZLuY0xSM7o9abd5clFHbz9b86Hm/MACPF033h/rylpaCceBX4Cb NOEo//gJiBV9YGbxBfGVfxtoxFbSGQV90EiMCDHXYuoJZ/x1QmZ0zQIexYBfUNKCQ6iR laz1+7RxfgXSCsscblIXwtVM/DsKjdFruvs0sG8BIzGh59BVg/dgKgFBH6g5jKDyoVkG RyhbOp3yYeEs/bNn7wBnc5GKLtFceaFt0qMIVWKlfYn5HB29plQcyMc+hzsYvcT6vaTL 2p8g== X-Gm-Message-State: AOAM531bggPCU8+CVKed/mgC9HIgqiXXZZb9B8+mtf4o+9Ra3pH6FhU5 yd6XZKN0MGg0MiJSRJ9FVw== X-Google-Smtp-Source: ABdhPJxbK6hoiyKNpMzmoDBLBobDYx879NczLVglVUutqLlDgqalJ+t+rfvvH+C6HortbEhqDFNSjQ== X-Received: by 2002:a9d:490a:: with SMTP id e10mr2397465otf.325.1601489846902; Wed, 30 Sep 2020 11:17:26 -0700 (PDT) Received: from xps15 (24-155-109-49.dyn.grandenetworks.net. [24.155.109.49]) by smtp.gmail.com with ESMTPSA id b17sm581935oog.25.2020.09.30.11.17.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 30 Sep 2020 11:17:26 -0700 (PDT) Received: (nullmailer pid 3169634 invoked by uid 1000); Wed, 30 Sep 2020 18:17:24 -0000 Date: Wed, 30 Sep 2020 13:17:24 -0500 From: Rob Herring To: Pali =?iso-8859-1?Q?Roh=E1r?= Cc: Kishon Vijay Abraham I , Vinod Koul , Tomasz Maciej Nowak , linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, Miquel Raynal , Lorenzo Pieralisi , Marek =?iso-8859-1?Q?Beh=FAn?= , Bjorn Helgaas , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 1/2] phy: marvell: comphy: Convert internal SMCC firmware return codes to errno Message-ID: <20200930181724.GA3169568@bogus> References: <20200902144344.16684-1-pali@kernel.org> <20200902144344.16684-2-pali@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20200902144344.16684-2-pali@kernel.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 02 Sep 2020 16:43:43 +0200, Pali Rohár wrote: > Driver ->power_on and ->power_off callbacks leaks internal SMCC firmware > return codes to phy caller. This patch converts SMCC error codes to > standard linux errno codes. Include file linux/arm-smccc.h already provides > defines for SMCC error codes, so use them instead of custom driver defines. > Note that return value is signed 32bit, but stored in unsigned long type > with zero padding. > > Signed-off-by: Pali Rohár > --- > drivers/phy/marvell/phy-mvebu-a3700-comphy.c | 14 +++++++++++--- > drivers/phy/marvell/phy-mvebu-cp110-comphy.c | 14 +++++++++++--- > 2 files changed, 22 insertions(+), 6 deletions(-) > Reviewed-by: Rob Herring From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C828FC4727E for ; Wed, 30 Sep 2020 18:19:01 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4B5DB20738 for ; Wed, 30 Sep 2020 18:19:01 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="ia3IpJpm" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4B5DB20738 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=tMbfTDsM9CwnHpjQIBlKBTa2Dx2WPrdnjXxatDeEjMI=; b=ia3IpJpmNvb5pAwWawE4d+inb zNHmHamXX+44Ip0Sd7op4N1O7ZWX0C9fIE5cFa/IT25G4qPX7AkSz6NR5aQGuek0/xFLXTL3RchA7 5qJdgwLGNebHLpFtbAI+TqxKCDwPP5lOwYtOp82dKC7reU082Fs05RFMFKhwDmqbRmTYl/+J5ji4h h9AaZru7DD/+Dc68kg3bXW39vNT5W3bU14ieUt56vZ6X12hN6L2BfVB5UlHzSG+Y6fvH/zp90IZ17 hRbaPVzXhWEdYWO5qC2OTc49qft9L2QSk+MhnsZbd1Mx8cj6e+BNHIF4v0qX5+Oknx9wfZssiLgEg R0djx1Abg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kNgfS-0001UE-59; Wed, 30 Sep 2020 18:17:30 +0000 Received: from mail-ot1-f66.google.com ([209.85.210.66]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kNgfP-0001To-QF for linux-arm-kernel@lists.infradead.org; Wed, 30 Sep 2020 18:17:28 +0000 Received: by mail-ot1-f66.google.com with SMTP id 60so2767990otw.3 for ; Wed, 30 Sep 2020 11:17:27 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=HfocoN8jnNi412P6cV06kFb4hY3gTbW/yUeIlx+erSw=; b=GwkJ8RIonQJNvFIK7nr5jEn170Ju1aWZ/2d8C1vAipxh/pePVoy5doWG2oB1ezz0mX CU3UE8UDv+eOwZdxWYlvYeNfoS9C8zWAesHebx08yDA9/PRTWfZqHJ82fIsZp9A/ehTS aPGwfwZvyqgB4al0uaF/pakRC0ZQl14VRe7YYKbm3MQDB/fucc8UgffznYQ3MaqBr0NP 6aknR1fCaN9pFBtHFfrQReXLpA6HZUFnCo4V3FevIbKBp1f9nuHuEli2eLdWMocYIgI9 SvfDzN6iwEw/KdV668qh6SxvZMZ9VByIaIcq1EJReElHl6+sXO86/fZXqmMslJ1rBDgc Xp2w== X-Gm-Message-State: AOAM533hMestF6xwlmL38H7FtrzzMpT2yGyOp7NwK/7iAnqdkD8o/6KQ VpKPHr1YVQgs4slibEERUA== X-Google-Smtp-Source: ABdhPJxbK6hoiyKNpMzmoDBLBobDYx879NczLVglVUutqLlDgqalJ+t+rfvvH+C6HortbEhqDFNSjQ== X-Received: by 2002:a9d:490a:: with SMTP id e10mr2397465otf.325.1601489846902; Wed, 30 Sep 2020 11:17:26 -0700 (PDT) Received: from xps15 (24-155-109-49.dyn.grandenetworks.net. [24.155.109.49]) by smtp.gmail.com with ESMTPSA id b17sm581935oog.25.2020.09.30.11.17.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 30 Sep 2020 11:17:26 -0700 (PDT) Received: (nullmailer pid 3169634 invoked by uid 1000); Wed, 30 Sep 2020 18:17:24 -0000 Date: Wed, 30 Sep 2020 13:17:24 -0500 From: Rob Herring To: Pali =?iso-8859-1?Q?Roh=E1r?= Subject: Re: [PATCH 1/2] phy: marvell: comphy: Convert internal SMCC firmware return codes to errno Message-ID: <20200930181724.GA3169568@bogus> References: <20200902144344.16684-1-pali@kernel.org> <20200902144344.16684-2-pali@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200902144344.16684-2-pali@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200930_141727_877945_A91299A9 X-CRM114-Status: GOOD ( 13.03 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Tomasz Maciej Nowak , Lorenzo Pieralisi , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, Kishon Vijay Abraham I , Vinod Koul , Miquel Raynal , Bjorn Helgaas , Marek =?iso-8859-1?Q?Beh=FAn?= , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, 02 Sep 2020 16:43:43 +0200, Pali Roh=E1r wrote: > Driver ->power_on and ->power_off callbacks leaks internal SMCC firmware > return codes to phy caller. This patch converts SMCC error codes to > standard linux errno codes. Include file linux/arm-smccc.h already provid= es > defines for SMCC error codes, so use them instead of custom driver define= s. > Note that return value is signed 32bit, but stored in unsigned long type > with zero padding. > = > Signed-off-by: Pali Roh=E1r > --- > drivers/phy/marvell/phy-mvebu-a3700-comphy.c | 14 +++++++++++--- > drivers/phy/marvell/phy-mvebu-cp110-comphy.c | 14 +++++++++++--- > 2 files changed, 22 insertions(+), 6 deletions(-) > = Reviewed-by: Rob Herring _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel