* [PATCH] tracing: remove a pointless assignment
@ 2020-09-30 18:43 Sudip Mukherjee
0 siblings, 0 replies; 2+ messages in thread
From: Sudip Mukherjee @ 2020-09-30 18:43 UTC (permalink / raw)
To: Steven Rostedt, Ingo Molnar; +Cc: linux-kernel, linux-safety, Sudip Mukherjee
The variable 'len' has been assigned a value but is not used after that.
So, remove the assignement.
Signed-off-by: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
---
kernel/trace/trace.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/kernel/trace/trace.c b/kernel/trace/trace.c
index d3c75aab44ad..e13cb3baeff0 100644
--- a/kernel/trace/trace.c
+++ b/kernel/trace/trace.c
@@ -6662,7 +6662,6 @@ tracing_mark_write(struct file *filp, const char __user *ubuf,
written = -EFAULT;
} else
written = cnt;
- len = cnt;
if (tr->trace_marker_file && !list_empty(&tr->trace_marker_file->triggers)) {
/* do not add \n before testing triggers, but add \0 */
--
2.11.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [PATCH] tracing: remove a pointless assignment
@ 2020-09-05 12:50 Dan Carpenter
0 siblings, 0 replies; 2+ messages in thread
From: Dan Carpenter @ 2020-09-05 12:50 UTC (permalink / raw)
To: kernel-janitors
The "tr" is a stack variable so setting it to NULL before a return is
a no-op. Delete the assignment.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
kernel/trace/trace.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/kernel/trace/trace.c b/kernel/trace/trace.c
index f40d850ebabc..a19b56f24350 100644
--- a/kernel/trace/trace.c
+++ b/kernel/trace/trace.c
@@ -8799,7 +8799,6 @@ static int __remove_instance(struct trace_array *tr)
free_cpumask_var(tr->tracing_cpumask);
kfree(tr->name);
kfree(tr);
- tr = NULL;
return 0;
}
--
2.28.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-09-30 18:43 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-30 18:43 [PATCH] tracing: remove a pointless assignment Sudip Mukherjee
-- strict thread matches above, loose matches on Subject: below --
2020-09-05 12:50 Dan Carpenter
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.