From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,UNWANTED_LANGUAGE_BODY autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 76558C4363D for ; Thu, 1 Oct 2020 03:04:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 340C521D7F for ; Thu, 1 Oct 2020 03:04:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1601521469; bh=Kj+fsBMxRWNG9VlBrcTFDufvU96D5sKeoAB1XD3c9GA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=Nrc+Ua9DFNDK7C1vSUz67hcjS2yXaRoRojIb17w7yFZ86qlX1Wh6POwbBfo7bxWZr zukbxJ1BWAR36U02OUOT6OkU61NemgJnj9EfdWeSygQ6GmK41Oiy8EOj1DwGg4OCa5 6671YcLhHpGoawWfrAdDlBFQ7gJl0FHCscTVfD/A= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730262AbgJADE2 (ORCPT ); Wed, 30 Sep 2020 23:04:28 -0400 Received: from mail.kernel.org ([198.145.29.99]:43502 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725372AbgJADE1 (ORCPT ); Wed, 30 Sep 2020 23:04:27 -0400 Received: from sol.localdomain (172-10-235-113.lightspeed.sntcca.sbcglobal.net [172.10.235.113]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 566B921D7D; Thu, 1 Oct 2020 03:04:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1601521467; bh=Kj+fsBMxRWNG9VlBrcTFDufvU96D5sKeoAB1XD3c9GA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=St+j+UHKud3cBmz7WmQqqknMNONsSTGzzhm2ZTtUclYOxNyU0jAdgRRhr3hUztF78 KaEVuFEeeXBABwtSDPkOkC1dWcsBLg8h+FQ+MVtKGfTzRPaQtRak2AxJemiLEKggnf qF7Ime9jkIv3g8/KMyCpGgDSUlGpuMhdJlKVyoDQ= Date: Wed, 30 Sep 2020 20:04:25 -0700 From: Eric Biggers To: Qian Cai Cc: David Howells , Alexander Viro , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] pipe: Fix memory leaks in create_pipe_files() Message-ID: <20201001030425.GA238305@sol.localdomain> References: <20201001025255.29560-1-cai@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201001025255.29560-1-cai@redhat.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Sep 30, 2020 at 10:52:55PM -0400, Qian Cai wrote: > diff --git a/include/linux/watch_queue.h b/include/linux/watch_queue.h > index 5e08db2adc31..20665fbe0552 100644 > --- a/include/linux/watch_queue.h > +++ b/include/linux/watch_queue.h > @@ -123,5 +123,9 @@ static inline void remove_watch_list(struct watch_list *wlist, u64 id) > #define watch_sizeof(STRUCT) (sizeof(STRUCT) << WATCH_INFO_LENGTH__SHIFT) > > #endif > +static inline int watch_queue_init(struct pipe_inode_info *pipe) > +{ > + return -ENOPKG; > +} This needs to be conditional on !CONFIG_WATCH_QUEUE. - Eric