From: Alexei Starovoitov <alexei.starovoitov@gmail.com>
To: Song Liu <songliubraving@fb.com>
Cc: netdev@vger.kernel.org, bpf@vger.kernel.org, kernel-team@fb.com,
ast@kernel.org, daniel@iogearbox.net, john.fastabend@gmail.com,
kpsingh@chromium.org
Subject: Re: [PATCH v5 bpf-next 2/2] selftests/bpf: add tests for BPF_F_PRESERVE_ELEMS
Date: Wed, 30 Sep 2020 23:27:18 -0700 [thread overview]
Message-ID: <20201001062718.uvtymy4l7jq6qkin@ast-mbp.dhcp.thefacebook.com> (raw)
In-Reply-To: <20200930224927.1936644-3-songliubraving@fb.com>
On Wed, Sep 30, 2020 at 03:49:27PM -0700, Song Liu wrote:
> +
> +SEC("raw_tp/task_rename")
> +int BPF_PROG(read_array_2)
> +{
> + struct bpf_perf_event_value val;
> + long ret;
> +
> + ret = bpf_perf_event_read_value(&array_2, 0, &val, sizeof(val));
> + return ret;
> +}
After removing printk there was a pointless 'ret' variable.
I've removed it while applying.
prev parent reply other threads:[~2020-10-01 6:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-30 22:49 [PATCH v5 bpf-next 0/2] introduce BPF_F_PRESERVE_ELEMS Song Liu
2020-09-30 22:49 ` [PATCH v5 bpf-next 1/2] bpf: introduce BPF_F_PRESERVE_ELEMS for perf event array Song Liu
2020-09-30 22:49 ` [PATCH v5 bpf-next 2/2] selftests/bpf: add tests for BPF_F_PRESERVE_ELEMS Song Liu
2020-10-01 6:27 ` Alexei Starovoitov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201001062718.uvtymy4l7jq6qkin@ast-mbp.dhcp.thefacebook.com \
--to=alexei.starovoitov@gmail.com \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=john.fastabend@gmail.com \
--cc=kernel-team@fb.com \
--cc=kpsingh@chromium.org \
--cc=netdev@vger.kernel.org \
--cc=songliubraving@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.