From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D1B13C4727C for ; Thu, 1 Oct 2020 06:48:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3186720848 for ; Thu, 1 Oct 2020 06:48:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725975AbgJAGsu (ORCPT ); Thu, 1 Oct 2020 02:48:50 -0400 Received: from new1-smtp.messagingengine.com ([66.111.4.221]:44195 "EHLO new1-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725878AbgJAGst (ORCPT ); Thu, 1 Oct 2020 02:48:49 -0400 Received: from compute6.internal (compute6.nyi.internal [10.202.2.46]) by mailnew.nyi.internal (Postfix) with ESMTP id 4AD475802D5; Thu, 1 Oct 2020 02:48:48 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute6.internal (MEProxy); Thu, 01 Oct 2020 02:48:48 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cerno.tech; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:content-transfer-encoding:in-reply-to; s=fm1; bh=0 3y1LiXg1NxtfKztmvM8LbH/TEW6ApaxXsj4nZFsU/Y=; b=Y6aYG549ji3R5bqFH 9av9nW2HMSCqOW8ILmPQ9DO9PADhouU+HCosxcRyU1HWnwE3jH9j4rtqPQwTbi4N XMOYj3HX+92mR8FcGFPnSwyRuGmllsY20Ino3Db+yU4OK1kX7Xr67RMTPjOpoiT6 GOPTELpikQukLTrUiHH9SSAU6cUv9Sf0a0cYsf3noCf9alBTxkQ+qnthn2LskoZ9 phrovTvomvmxoxycrbqvAxw0pILcbOrFeadpS4HXF5j67yW5bjs4tWaZFnKMP5n3 IQIPkCcM6cT1eNFz8KD1iFzMIrDlIEDbRpSSWCwVcNdUHkpnCdyZEODrp+njtsqE vc4Mg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=03y1LiXg1NxtfKztmvM8LbH/TEW6ApaxXsj4nZFsU /Y=; b=pB8oDVlpmy+POTenpKlW1uN3BO1+4klcZcOMsK4VzOVTzE49rektbmX9o VOVLN0aBHQ2bzK156gbjSmLLOfTkR9CZAsih8Gt1HHYcejVQVlLMlXw+C4zfHUvS Ra74bqBvdHOzsYwAjPkptfInPbhd36IP3yD6TiHGZA4uuf2WU9HQLoIqMy264crW 3tv6x3CjwQ8FP+pld68MQ3gQV54/Yt6yIaUAwNpocyA0z6h9+VHxJagqwZ9wyGiQ 6En6BQo3Qj2zfyHq/Na/gBQG66EzkET2jGhnrSg5ieogPRDJeH6ZrMMra3IXEnin bY+zC68/smGmvPtiFmUiFWwC2m8GA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedrfeefgdduudehucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvffukfhfgggtugfgjgesthhqredttddtvdenucfhrhhomhepofgrgihi mhgvucftihhprghrugcuoehmrgigihhmvgestggvrhhnohdrthgvtghhqeenucggtffrrg htthgvrhhnpefgjeettdejgffgffdvteeutdehtdehgeehueetkeefgefhtdetjeekledu gedvudenucfkphepledtrdekledrieekrdejieenucevlhhushhtvghrufhiiigvpedtne curfgrrhgrmhepmhgrihhlfhhrohhmpehmrgigihhmvgestggvrhhnohdrthgvtghh X-ME-Proxy: Received: from localhost (lfbn-tou-1-1502-76.w90-89.abo.wanadoo.fr [90.89.68.76]) by mail.messagingengine.com (Postfix) with ESMTPA id 5D2D43280063; Thu, 1 Oct 2020 02:48:46 -0400 (EDT) Date: Thu, 1 Oct 2020 08:48:43 +0200 From: Maxime Ripard To: Stefan Wahren Cc: Nathan Chancellor , Nicolas Saenz Julienne , Eric Anholt , Tim Gover , Dave Stevenson , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Hoegeun Kwon , Chanwoo Choi , bcm-kernel-feedback-list@broadcom.com, linux-rpi-kernel@lists.infradead.org, Phil Elwell , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v5 80/80] ARM: dts: bcm2711: Enable the display pipeline Message-ID: <20201001064843.dlewcu3b7dvqanyy@gilmour.lan> References: <20200929221526.GA1370981@ubuntu-m3-large-x86> <20200930140758.gummt3umouva3wyu@gilmour.lan> <20200930163823.GA237050@ubuntu-m3-large-x86> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Stefan, On Wed, Sep 30, 2020 at 06:52:13PM +0200, Stefan Wahren wrote: > Am 30.09.20 um 18:38 schrieb Nathan Chancellor: > > On Wed, Sep 30, 2020 at 04:07:58PM +0200, Maxime Ripard wrote: > >> Hi Nathan, > >> > >> On Tue, Sep 29, 2020 at 03:15:26PM -0700, Nathan Chancellor wrote: > >>> On Thu, Sep 03, 2020 at 10:01:52AM +0200, Maxime Ripard wrote: > >>>> Now that all the drivers have been adjusted for it, let's bring in t= he > >>>> necessary device tree changes. > >>>> > >>>> The VEC and PV3 are left out for now, since it will require a more s= pecific > >>>> clock setup. > >>>> > >>>> Reviewed-by: Dave Stevenson > >>>> Tested-by: Chanwoo Choi > >>>> Tested-by: Hoegeun Kwon > >>>> Tested-by: Stefan Wahren > >>>> Signed-off-by: Maxime Ripard > >>> Apologies if this has already been reported or have a solution but th= is > >>> patch (and presumably series) breaks output to the serial console aft= er > >>> a certain point during init. On Raspbian, I see systemd startup messa= ges > >>> then the output just turns into complete garbage. It looks like this > >>> patch is merged first in linux-next, which is why my bisect fell on t= he > >>> DRM merge. I am happy to provide whatever information could be helpful > >>> for debugging this. I am on the latest version of the firmware > >>> (currently 26620cc9a63c6cb9965374d509479b4ee2c30241). > >> Unfortunately, the miniUART is in the same clock tree than the core > >> clock and will thus have those kind of issues when the core clock is > >> changed (which is also something that one should expect when using the > >> DRM or other drivers). > >> > >> The only real workaround there would be to switch to one of the PL011 > >> UARTs. I guess we can also somehow make the UART react to the core clo= ck > >> frequency changes, but that's going to require some effort > >> > >> Maxime > > Ack, thank you for the reply! There does not really seem to be a whole > > ton of documentation around using one of the other PL011 UARTs so for > > now, I will just revert this commit locally. >=20 > there was a patch series & discussion about this topic, but we finally > didn't find a rock solid solution. >=20 > You can have a look at "[RFC 5/5] serial: 8250: bcm2835aux: add notifier > to follow clock changes" from 3.4.2019 on linux-rpi-kernel. I couldn't find that discussion on the archive, but based on the title I guess there's some patches that have been merged this cycle for the 8250 driver to do just that (868f3ee6e452 ("serial: 8250: Add 8250 port clock update method") and cc816969d7b5 ("serial: 8250_dw: Fix common clocks usage race condition")). However, I'm not entirely sure the clock notifier works in our case with the firmware / MMIO clocks duality Maxime From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DBCEFC4727C for ; Thu, 1 Oct 2020 06:50:32 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8405220848 for ; Thu, 1 Oct 2020 06:50:32 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="muIfJ0oK"; dkim=temperror (0-bit key) header.d=cerno.tech header.i=@cerno.tech header.b="Y6aYG549"; dkim=temperror (0-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="pB8oDVlp" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8405220848 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=cerno.tech Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=y3hCuBWvwW9sH7yfUsgXlixkXqocLpBSjzs+Sh1iMb4=; b=muIfJ0oK7Bi0PnboZWP/bHjas GIc9vt9dI5dhH5YSQGqA5NOMauyLVCZ8ITqTSHBUOB617IO1MxQ5Zvx2LYP7bZ+LntjhdKlxYs0QJ K1laFtGxVcKvn9quqm0cQPAWk4OBoIzWFoQPaDQgiZvGrDgVeQrRm4fVDCnkNgWncvjobXYtOEIHL +N1d0NWUzAnrQPm/a2qYoCQJCVi9FKmSzs2JkNB3UP9NJAxlj1bv1Bwz4CZ7nF1jcjVcpp/aDvMFL Z1CZFAbm6mtoZOQhuWgiYQy5Vt0cNvrXZR3cXIARKkRskjF2uMuKd86aUCwZoD80HyGELY3S76xhu P5E8VLx2g==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kNsOg-0001QZ-JF; Thu, 01 Oct 2020 06:48:58 +0000 Received: from new1-smtp.messagingengine.com ([66.111.4.221]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kNsOd-0001Pj-G7; Thu, 01 Oct 2020 06:48:56 +0000 Received: from compute6.internal (compute6.nyi.internal [10.202.2.46]) by mailnew.nyi.internal (Postfix) with ESMTP id 4AD475802D5; Thu, 1 Oct 2020 02:48:48 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute6.internal (MEProxy); Thu, 01 Oct 2020 02:48:48 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cerno.tech; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:content-transfer-encoding:in-reply-to; s=fm1; bh=0 3y1LiXg1NxtfKztmvM8LbH/TEW6ApaxXsj4nZFsU/Y=; b=Y6aYG549ji3R5bqFH 9av9nW2HMSCqOW8ILmPQ9DO9PADhouU+HCosxcRyU1HWnwE3jH9j4rtqPQwTbi4N XMOYj3HX+92mR8FcGFPnSwyRuGmllsY20Ino3Db+yU4OK1kX7Xr67RMTPjOpoiT6 GOPTELpikQukLTrUiHH9SSAU6cUv9Sf0a0cYsf3noCf9alBTxkQ+qnthn2LskoZ9 phrovTvomvmxoxycrbqvAxw0pILcbOrFeadpS4HXF5j67yW5bjs4tWaZFnKMP5n3 IQIPkCcM6cT1eNFz8KD1iFzMIrDlIEDbRpSSWCwVcNdUHkpnCdyZEODrp+njtsqE vc4Mg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=03y1LiXg1NxtfKztmvM8LbH/TEW6ApaxXsj4nZFsU /Y=; b=pB8oDVlpmy+POTenpKlW1uN3BO1+4klcZcOMsK4VzOVTzE49rektbmX9o VOVLN0aBHQ2bzK156gbjSmLLOfTkR9CZAsih8Gt1HHYcejVQVlLMlXw+C4zfHUvS Ra74bqBvdHOzsYwAjPkptfInPbhd36IP3yD6TiHGZA4uuf2WU9HQLoIqMy264crW 3tv6x3CjwQ8FP+pld68MQ3gQV54/Yt6yIaUAwNpocyA0z6h9+VHxJagqwZ9wyGiQ 6En6BQo3Qj2zfyHq/Na/gBQG66EzkET2jGhnrSg5ieogPRDJeH6ZrMMra3IXEnin bY+zC68/smGmvPtiFmUiFWwC2m8GA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedrfeefgdduudehucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvffukfhfgggtugfgjgesthhqredttddtvdenucfhrhhomhepofgrgihi mhgvucftihhprghrugcuoehmrgigihhmvgestggvrhhnohdrthgvtghhqeenucggtffrrg htthgvrhhnpefgjeettdejgffgffdvteeutdehtdehgeehueetkeefgefhtdetjeekledu gedvudenucfkphepledtrdekledrieekrdejieenucevlhhushhtvghrufhiiigvpedtne curfgrrhgrmhepmhgrihhlfhhrohhmpehmrgigihhmvgestggvrhhnohdrthgvtghh X-ME-Proxy: Received: from localhost (lfbn-tou-1-1502-76.w90-89.abo.wanadoo.fr [90.89.68.76]) by mail.messagingengine.com (Postfix) with ESMTPA id 5D2D43280063; Thu, 1 Oct 2020 02:48:46 -0400 (EDT) Date: Thu, 1 Oct 2020 08:48:43 +0200 From: Maxime Ripard To: Stefan Wahren Subject: Re: [PATCH v5 80/80] ARM: dts: bcm2711: Enable the display pipeline Message-ID: <20201001064843.dlewcu3b7dvqanyy@gilmour.lan> References: <20200929221526.GA1370981@ubuntu-m3-large-x86> <20200930140758.gummt3umouva3wyu@gilmour.lan> <20200930163823.GA237050@ubuntu-m3-large-x86> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201001_024855_602915_EBD0479E X-CRM114-Status: GOOD ( 29.91 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-arm-kernel@lists.infradead.org, Chanwoo Choi , Tim Gover , Dave Stevenson , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Phil Elwell , Eric Anholt , bcm-kernel-feedback-list@broadcom.com, linux-rpi-kernel@lists.infradead.org, Nathan Chancellor , Hoegeun Kwon , Nicolas Saenz Julienne Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Stefan, On Wed, Sep 30, 2020 at 06:52:13PM +0200, Stefan Wahren wrote: > Am 30.09.20 um 18:38 schrieb Nathan Chancellor: > > On Wed, Sep 30, 2020 at 04:07:58PM +0200, Maxime Ripard wrote: > >> Hi Nathan, > >> > >> On Tue, Sep 29, 2020 at 03:15:26PM -0700, Nathan Chancellor wrote: > >>> On Thu, Sep 03, 2020 at 10:01:52AM +0200, Maxime Ripard wrote: > >>>> Now that all the drivers have been adjusted for it, let's bring in the > >>>> necessary device tree changes. > >>>> > >>>> The VEC and PV3 are left out for now, since it will require a more specific > >>>> clock setup. > >>>> > >>>> Reviewed-by: Dave Stevenson > >>>> Tested-by: Chanwoo Choi > >>>> Tested-by: Hoegeun Kwon > >>>> Tested-by: Stefan Wahren > >>>> Signed-off-by: Maxime Ripard > >>> Apologies if this has already been reported or have a solution but this > >>> patch (and presumably series) breaks output to the serial console after > >>> a certain point during init. On Raspbian, I see systemd startup messages > >>> then the output just turns into complete garbage. It looks like this > >>> patch is merged first in linux-next, which is why my bisect fell on the > >>> DRM merge. I am happy to provide whatever information could be helpful > >>> for debugging this. I am on the latest version of the firmware > >>> (currently 26620cc9a63c6cb9965374d509479b4ee2c30241). > >> Unfortunately, the miniUART is in the same clock tree than the core > >> clock and will thus have those kind of issues when the core clock is > >> changed (which is also something that one should expect when using the > >> DRM or other drivers). > >> > >> The only real workaround there would be to switch to one of the PL011 > >> UARTs. I guess we can also somehow make the UART react to the core clock > >> frequency changes, but that's going to require some effort > >> > >> Maxime > > Ack, thank you for the reply! There does not really seem to be a whole > > ton of documentation around using one of the other PL011 UARTs so for > > now, I will just revert this commit locally. > > there was a patch series & discussion about this topic, but we finally > didn't find a rock solid solution. > > You can have a look at "[RFC 5/5] serial: 8250: bcm2835aux: add notifier > to follow clock changes" from 3.4.2019 on linux-rpi-kernel. I couldn't find that discussion on the archive, but based on the title I guess there's some patches that have been merged this cycle for the 8250 driver to do just that (868f3ee6e452 ("serial: 8250: Add 8250 port clock update method") and cc816969d7b5 ("serial: 8250_dw: Fix common clocks usage race condition")). However, I'm not entirely sure the clock notifier works in our case with the firmware / MMIO clocks duality Maxime _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 01622C4727C for ; Thu, 1 Oct 2020 08:17:25 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B70C220BED for ; Thu, 1 Oct 2020 08:17:24 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B70C220BED Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=cerno.tech Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 737386E880; Thu, 1 Oct 2020 08:17:21 +0000 (UTC) Received: from new1-smtp.messagingengine.com (new1-smtp.messagingengine.com [66.111.4.221]) by gabe.freedesktop.org (Postfix) with ESMTPS id C30466E84E for ; Thu, 1 Oct 2020 06:48:50 +0000 (UTC) Received: from compute6.internal (compute6.nyi.internal [10.202.2.46]) by mailnew.nyi.internal (Postfix) with ESMTP id 4AD475802D5; Thu, 1 Oct 2020 02:48:48 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute6.internal (MEProxy); Thu, 01 Oct 2020 02:48:48 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cerno.tech; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:content-transfer-encoding:in-reply-to; s=fm1; bh=0 3y1LiXg1NxtfKztmvM8LbH/TEW6ApaxXsj4nZFsU/Y=; b=Y6aYG549ji3R5bqFH 9av9nW2HMSCqOW8ILmPQ9DO9PADhouU+HCosxcRyU1HWnwE3jH9j4rtqPQwTbi4N XMOYj3HX+92mR8FcGFPnSwyRuGmllsY20Ino3Db+yU4OK1kX7Xr67RMTPjOpoiT6 GOPTELpikQukLTrUiHH9SSAU6cUv9Sf0a0cYsf3noCf9alBTxkQ+qnthn2LskoZ9 phrovTvomvmxoxycrbqvAxw0pILcbOrFeadpS4HXF5j67yW5bjs4tWaZFnKMP5n3 IQIPkCcM6cT1eNFz8KD1iFzMIrDlIEDbRpSSWCwVcNdUHkpnCdyZEODrp+njtsqE vc4Mg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=03y1LiXg1NxtfKztmvM8LbH/TEW6ApaxXsj4nZFsU /Y=; b=pB8oDVlpmy+POTenpKlW1uN3BO1+4klcZcOMsK4VzOVTzE49rektbmX9o VOVLN0aBHQ2bzK156gbjSmLLOfTkR9CZAsih8Gt1HHYcejVQVlLMlXw+C4zfHUvS Ra74bqBvdHOzsYwAjPkptfInPbhd36IP3yD6TiHGZA4uuf2WU9HQLoIqMy264crW 3tv6x3CjwQ8FP+pld68MQ3gQV54/Yt6yIaUAwNpocyA0z6h9+VHxJagqwZ9wyGiQ 6En6BQo3Qj2zfyHq/Na/gBQG66EzkET2jGhnrSg5ieogPRDJeH6ZrMMra3IXEnin bY+zC68/smGmvPtiFmUiFWwC2m8GA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedrfeefgdduudehucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvffukfhfgggtugfgjgesthhqredttddtvdenucfhrhhomhepofgrgihi mhgvucftihhprghrugcuoehmrgigihhmvgestggvrhhnohdrthgvtghhqeenucggtffrrg htthgvrhhnpefgjeettdejgffgffdvteeutdehtdehgeehueetkeefgefhtdetjeekledu gedvudenucfkphepledtrdekledrieekrdejieenucevlhhushhtvghrufhiiigvpedtne curfgrrhgrmhepmhgrihhlfhhrohhmpehmrgigihhmvgestggvrhhnohdrthgvtghh X-ME-Proxy: Received: from localhost (lfbn-tou-1-1502-76.w90-89.abo.wanadoo.fr [90.89.68.76]) by mail.messagingengine.com (Postfix) with ESMTPA id 5D2D43280063; Thu, 1 Oct 2020 02:48:46 -0400 (EDT) Date: Thu, 1 Oct 2020 08:48:43 +0200 From: Maxime Ripard To: Stefan Wahren Subject: Re: [PATCH v5 80/80] ARM: dts: bcm2711: Enable the display pipeline Message-ID: <20201001064843.dlewcu3b7dvqanyy@gilmour.lan> References: <20200929221526.GA1370981@ubuntu-m3-large-x86> <20200930140758.gummt3umouva3wyu@gilmour.lan> <20200930163823.GA237050@ubuntu-m3-large-x86> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-Mailman-Approved-At: Thu, 01 Oct 2020 08:15:43 +0000 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-arm-kernel@lists.infradead.org, Chanwoo Choi , Tim Gover , Dave Stevenson , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Phil Elwell , bcm-kernel-feedback-list@broadcom.com, linux-rpi-kernel@lists.infradead.org, Nathan Chancellor , Hoegeun Kwon , Nicolas Saenz Julienne Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi Stefan, On Wed, Sep 30, 2020 at 06:52:13PM +0200, Stefan Wahren wrote: > Am 30.09.20 um 18:38 schrieb Nathan Chancellor: > > On Wed, Sep 30, 2020 at 04:07:58PM +0200, Maxime Ripard wrote: > >> Hi Nathan, > >> > >> On Tue, Sep 29, 2020 at 03:15:26PM -0700, Nathan Chancellor wrote: > >>> On Thu, Sep 03, 2020 at 10:01:52AM +0200, Maxime Ripard wrote: > >>>> Now that all the drivers have been adjusted for it, let's bring in the > >>>> necessary device tree changes. > >>>> > >>>> The VEC and PV3 are left out for now, since it will require a more specific > >>>> clock setup. > >>>> > >>>> Reviewed-by: Dave Stevenson > >>>> Tested-by: Chanwoo Choi > >>>> Tested-by: Hoegeun Kwon > >>>> Tested-by: Stefan Wahren > >>>> Signed-off-by: Maxime Ripard > >>> Apologies if this has already been reported or have a solution but this > >>> patch (and presumably series) breaks output to the serial console after > >>> a certain point during init. On Raspbian, I see systemd startup messages > >>> then the output just turns into complete garbage. It looks like this > >>> patch is merged first in linux-next, which is why my bisect fell on the > >>> DRM merge. I am happy to provide whatever information could be helpful > >>> for debugging this. I am on the latest version of the firmware > >>> (currently 26620cc9a63c6cb9965374d509479b4ee2c30241). > >> Unfortunately, the miniUART is in the same clock tree than the core > >> clock and will thus have those kind of issues when the core clock is > >> changed (which is also something that one should expect when using the > >> DRM or other drivers). > >> > >> The only real workaround there would be to switch to one of the PL011 > >> UARTs. I guess we can also somehow make the UART react to the core clock > >> frequency changes, but that's going to require some effort > >> > >> Maxime > > Ack, thank you for the reply! There does not really seem to be a whole > > ton of documentation around using one of the other PL011 UARTs so for > > now, I will just revert this commit locally. > > there was a patch series & discussion about this topic, but we finally > didn't find a rock solid solution. > > You can have a look at "[RFC 5/5] serial: 8250: bcm2835aux: add notifier > to follow clock changes" from 3.4.2019 on linux-rpi-kernel. I couldn't find that discussion on the archive, but based on the title I guess there's some patches that have been merged this cycle for the 8250 driver to do just that (868f3ee6e452 ("serial: 8250: Add 8250 port clock update method") and cc816969d7b5 ("serial: 8250_dw: Fix common clocks usage race condition")). However, I'm not entirely sure the clock notifier works in our case with the firmware / MMIO clocks duality Maxime _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel