From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9BBADC4727E for ; Thu, 1 Oct 2020 08:52:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 642D0215A4 for ; Thu, 1 Oct 2020 08:52:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1601542324; bh=m4mgCzx46g2Oa3eLfk8Tl9IowtEGTj1vx7rUwjnD9KU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=fbm9oYz627yMDuXjhokneVkZCjzThxDMe3pcvqA3onwPfiVBy8FQGksuHGn09iKZo gl8U5OYq1tEYiXmCshDi0gnME9SrDqZPV7EpzxWqNoMvpahAv6GJD5Lsi25tkh6bxP osPFuELVUwx8mGwPFN/7C9M+KaTWEkuuIFdBYAy8= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731548AbgJAIwD (ORCPT ); Thu, 1 Oct 2020 04:52:03 -0400 Received: from mail-ed1-f65.google.com ([209.85.208.65]:40631 "EHLO mail-ed1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731134AbgJAIwB (ORCPT ); Thu, 1 Oct 2020 04:52:01 -0400 Received: by mail-ed1-f65.google.com with SMTP id t16so4777268edw.7 for ; Thu, 01 Oct 2020 01:52:00 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=l7OYBwGt4sviP39N2nF2KS/kLgl84Rv72GGMiBM+ypU=; b=NyRSgexAsmvmhfqL043ICAtbuxhnmG4w0YJGe1+Gx6urBgzwjhiVAm7eaxbPxq+OvB lVnjExXp22k4F395v/Y6Czm+zv+GG0/HkLHmnI/zeTlgIbTZgNNRoNEX9aJpc9RGcQIC 1kNAX6R+yhxUpymV7gur+tZGEMy1hF5WyJQukjtzntYXSRF0SepJ/Q0W1j+R4sj5ab2F ftrlA6Sgsqc8YYuw+TsGfxHRqxeRPuGH02c2gImbsC/ri20QbYjZQuFkI53D1J7BClN0 dkP8ZlyT2devT+rKAPh7j95Qc9SZzD0WFW1sqqUUnlSN028v09JV3ZrsD1tQkvbkMuLU 7NFg== X-Gm-Message-State: AOAM532V7cAJqsxTiKs6iwSuZiSDereMMzldMWWzp0zo+L4BhNvavmAM MWwrb7jHoxx7RGeFgeuamTc= X-Google-Smtp-Source: ABdhPJxMFmftEOyq7mnfL1aGPOTfPARMb0Js8Py8k3LrJ+ajFPfscONS4VjBapttHlVh8V7FFI7XlA== X-Received: by 2002:a50:d65e:: with SMTP id c30mr7095467edj.57.1601542319346; Thu, 01 Oct 2020 01:51:59 -0700 (PDT) Received: from kozik-lap ([194.230.155.194]) by smtp.googlemail.com with ESMTPSA id lc25sm3686349ejb.35.2020.10.01.01.51.57 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Thu, 01 Oct 2020 01:51:58 -0700 (PDT) Date: Thu, 1 Oct 2020 10:51:56 +0200 From: Krzysztof Kozlowski To: Lucas Stach Cc: Shawn Guo , Rob Herring , NXP Linux Team , Fabio Estevam , Frieder Schrempf , Marek Vasut , linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, kernel@pengutronix.de, patchwork-lst@pengutronix.de Subject: Re: [PATCH 10/11] arm64: dts: imx8mm: add GPC node and power domains Message-ID: <20201001085156.GA15804@kozik-lap> References: <20200930155006.535712-1-l.stach@pengutronix.de> <20200930155006.535712-11-l.stach@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20200930155006.535712-11-l.stach@pengutronix.de> User-Agent: Mutt/1.9.4 (2018-02-28) Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Wed, Sep 30, 2020 at 05:50:05PM +0200, Lucas Stach wrote: > This adds the DT nodes to describe the power domains available on the > i.MX8MM. Things are a bit more complex compared to other GPCv2 power > domain setups, as there is now a hierarchy of domains where complete > subsystems (HSIO, GPU, DISPLAY) can be gated as a whole, but also > fine granular gating within those subsystems is possible. > > Note that this is still incomplete, as both VPU and DISP domains are > missing their reset clocks. Those aren't directly sourced from the CCM, > but have another level of clock gating in the BLKCTL of those domains, > which needs a separate driver. > > Signed-off-by: Lucas Stach > --- > arch/arm64/boot/dts/freescale/imx8mm.dtsi | 57 +++++++++++++++++++++++ > 1 file changed, 57 insertions(+) > > diff --git a/arch/arm64/boot/dts/freescale/imx8mm.dtsi b/arch/arm64/boot/dts/freescale/imx8mm.dtsi > index 76f040e4be5e..a841fb2d0458 100644 > --- a/arch/arm64/boot/dts/freescale/imx8mm.dtsi > +++ b/arch/arm64/boot/dts/freescale/imx8mm.dtsi > @@ -4,6 +4,8 @@ > */ > > #include > +#include > +#include > #include > #include > #include > @@ -547,6 +549,61 @@ > interrupts = ; > #reset-cells = <1>; > }; > + > + gpc: gpc@303a0000 { > + compatible = "fsl,imx8mm-gpc"; > + reg = <0x303a0000 0x10000>; > + interrupt-parent = <&gic>; > + interrupt-controller; This does not validate against your GPC dtschema. Please add DTS which passes own schema from day one (except existing issues). Best regards, Krzysztof From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AF929C4727C for ; Thu, 1 Oct 2020 08:53:29 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 41BF2208B6 for ; Thu, 1 Oct 2020 08:53:29 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="DKh/1F+e" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 41BF2208B6 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=0qkGqYVEeiA2qEt8WmXl3NfmG6Y09h75RIoX4M2+4+s=; b=DKh/1F+eQrytwt6jKLv6JJJwq BRJdFBRGeIDjM2ceEwd5x00BB/PsEY+fT6Pp+agH7u+W9ANCyy2oYdqIZQ7z8LY1Naez1QgbVimI+ ED4dEGCPU3tATljm4DDlgh39y5h7jxa2T5791QwKHxZcHGul0DnITj3jzSR+ZThVcvHJlSO9o7//B soBmTQJO0X3AfeX1C8iw4zv5Xz0Ajjbu3kYxwZqghCvL0o0iX0i2vuYHT1bf9UB3xPCIqJB1wQCs3 Eo1JcWa7mAYb4WsqtlHntshNLB6SDGU1ooorAah5b+rvwhDuuGBCD2gLr5j28hFofqrPLc3BMm8pq A36E5yARw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kNuJm-0006V8-LY; Thu, 01 Oct 2020 08:52:02 +0000 Received: from mail-ed1-f66.google.com ([209.85.208.66]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kNuJk-0006US-Sw for linux-arm-kernel@lists.infradead.org; Thu, 01 Oct 2020 08:52:01 +0000 Received: by mail-ed1-f66.google.com with SMTP id g4so4809375edk.0 for ; Thu, 01 Oct 2020 01:52:00 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=l7OYBwGt4sviP39N2nF2KS/kLgl84Rv72GGMiBM+ypU=; b=EG2GTRVaZpxOABwVycxXCni4MTZFRoI26o5wqfzhRqC9HOE2t0kpGxeirWSN9DH3n3 LMZm47jOzgebl7CGN3YEBsGWl7JtduFesIbq+OklQZeRFRd/in/BB76AFr7WEbc5JehP vxJho1mZsvDUmqZA79S0HIxqZQQSXhF+k4qLUUVEuj2mbV78QXxCMb4GgFYkYApXLs8h AEB8X+fACHUKmOsx2rOM+oifM8bwqV/ZBTMAPr1y/8v0IRJw792jXF6tv38HpB3Zcunc 9bG0kgeEDnwA79z2AeehUl1pnG79HBR3KAO382ZgPZtiuZ6aPiNfJyY6Jy2MbESjQIH+ Blng== X-Gm-Message-State: AOAM5307Rg10JqqFf1EX4yFQcGGjxytTvG19ORY11T+liQtKw16nGyJX b79JvjiAbGUKb1ldFyRCvrE= X-Google-Smtp-Source: ABdhPJxMFmftEOyq7mnfL1aGPOTfPARMb0Js8Py8k3LrJ+ajFPfscONS4VjBapttHlVh8V7FFI7XlA== X-Received: by 2002:a50:d65e:: with SMTP id c30mr7095467edj.57.1601542319346; Thu, 01 Oct 2020 01:51:59 -0700 (PDT) Received: from kozik-lap ([194.230.155.194]) by smtp.googlemail.com with ESMTPSA id lc25sm3686349ejb.35.2020.10.01.01.51.57 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Thu, 01 Oct 2020 01:51:58 -0700 (PDT) Date: Thu, 1 Oct 2020 10:51:56 +0200 From: Krzysztof Kozlowski To: Lucas Stach Subject: Re: [PATCH 10/11] arm64: dts: imx8mm: add GPC node and power domains Message-ID: <20201001085156.GA15804@kozik-lap> References: <20200930155006.535712-1-l.stach@pengutronix.de> <20200930155006.535712-11-l.stach@pengutronix.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200930155006.535712-11-l.stach@pengutronix.de> User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201001_045201_021402_0752F28A X-CRM114-Status: GOOD ( 22.94 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Marek Vasut , devicetree@vger.kernel.org, Shawn Guo , Frieder Schrempf , patchwork-lst@pengutronix.de, Rob Herring , NXP Linux Team , kernel@pengutronix.de, Fabio Estevam , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Sep 30, 2020 at 05:50:05PM +0200, Lucas Stach wrote: > This adds the DT nodes to describe the power domains available on the > i.MX8MM. Things are a bit more complex compared to other GPCv2 power > domain setups, as there is now a hierarchy of domains where complete > subsystems (HSIO, GPU, DISPLAY) can be gated as a whole, but also > fine granular gating within those subsystems is possible. > > Note that this is still incomplete, as both VPU and DISP domains are > missing their reset clocks. Those aren't directly sourced from the CCM, > but have another level of clock gating in the BLKCTL of those domains, > which needs a separate driver. > > Signed-off-by: Lucas Stach > --- > arch/arm64/boot/dts/freescale/imx8mm.dtsi | 57 +++++++++++++++++++++++ > 1 file changed, 57 insertions(+) > > diff --git a/arch/arm64/boot/dts/freescale/imx8mm.dtsi b/arch/arm64/boot/dts/freescale/imx8mm.dtsi > index 76f040e4be5e..a841fb2d0458 100644 > --- a/arch/arm64/boot/dts/freescale/imx8mm.dtsi > +++ b/arch/arm64/boot/dts/freescale/imx8mm.dtsi > @@ -4,6 +4,8 @@ > */ > > #include > +#include > +#include > #include > #include > #include > @@ -547,6 +549,61 @@ > interrupts = ; > #reset-cells = <1>; > }; > + > + gpc: gpc@303a0000 { > + compatible = "fsl,imx8mm-gpc"; > + reg = <0x303a0000 0x10000>; > + interrupt-parent = <&gic>; > + interrupt-controller; This does not validate against your GPC dtschema. Please add DTS which passes own schema from day one (except existing issues). Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel