Re: [PATCH v7 1/4] powerpc: Refactor kexec functions to move arch independent code to kernel

From: kernel test robot <lkp@intel.com>
To: kbuild-all@lists.01.org
Subject: Re: [PATCH v7 1/4] powerpc: Refactor kexec functions to move arch independent code to kernel
Date: Thu, 01 Oct 2020 09:21:49 +0800	[thread overview]
Message-ID: <202010010953.qSX7WZwW-lkp@intel.com> (raw)
In-Reply-To: <20200930205941.1576-2-nramas@linux.microsoft.com>

[-- Attachment #1: Type: text/plain, Size: 2985 bytes --]

Hi Lakshmi,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on powerpc/next]
[also build test ERROR on arm64/for-next/core integrity/next-integrity linus/master v5.9-rc7 next-20200930]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Lakshmi-Ramasubramanian/powerpc-Refactor-kexec-functions-to-move-arch-independent-code-to-kernel/20201001-060013
base:   https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git next
config: parisc-randconfig-r012-20200930 (attached as .config)
compiler: hppa-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/6a1d11b4c60a9d19172f2aee98568c0ce65da4ea
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Lakshmi-Ramasubramanian/powerpc-Refactor-kexec-functions-to-move-arch-independent-code-to-kernel/20201001-060013
        git checkout 6a1d11b4c60a9d19172f2aee98568c0ce65da4ea
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=parisc 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   hppa-linux-ld: kernel/kexec_file_fdt.o: in function `delete_fdt_mem_rsv':
>> kernel/kexec_file_fdt.c:30: undefined reference to `fdt_num_mem_rsv'
>> hppa-linux-ld: kernel/kexec_file_fdt.c:35: undefined reference to `fdt_get_mem_rsv'
>> hppa-linux-ld: kernel/kexec_file_fdt.c:42: undefined reference to `fdt_del_mem_rsv'

vim +30 kernel/kexec_file_fdt.c

    18	
    19	/**
    20	 * delete_fdt_mem_rsv - delete memory reservation with given address and size
    21	 *
    22	 * @fdt: Flattened Device Tree to update
    23	 * @start: Starting address of the reservation to delete
    24	 * @size: Size of the reservation to delete
    25	 *
    26	 * Return: 0 on success, or negative errno on error.
    27	 */
    28	int delete_fdt_mem_rsv(void *fdt, unsigned long start, unsigned long size)
    29	{
  > 30		int i, ret, num_rsvs = fdt_num_mem_rsv(fdt);
    31	
    32		for (i = 0; i < num_rsvs; i++) {
    33			uint64_t rsv_start, rsv_size;
    34	
  > 35			ret = fdt_get_mem_rsv(fdt, i, &rsv_start, &rsv_size);
    36			if (ret) {
    37				pr_err("Malformed device tree.\n");
    38				return -EINVAL;
    39			}
    40	
    41			if (rsv_start == start && rsv_size == size) {
  > 42				ret = fdt_del_mem_rsv(fdt, i);

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 26079 bytes --]