All of lore.kernel.org
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Ahmad Fatoum <a.fatoum@pengutronix.de>
Cc: Rob Herring <robh+dt@kernel.org>, Shawn Guo <shawnguo@kernel.org>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	Pengutronix Kernel Team <kernel@pengutronix.de>,
	Fabio Estevam <festevam@gmail.com>,
	NXP Linux Team <linux-imx@nxp.com>,
	Anson Huang <Anson.Huang@nxp.com>,
	Andreas Kemnade <andreas@kemnade.info>,
	Stefan Riedmueller <s.riedmueller@phytec.de>,
	Robert Jones <rjones@gateworks.com>, Li Yang <leoyang.li@nxp.com>,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 08/12] ARM: dts: imx6dl-pico: fix board compatibles
Date: Thu, 1 Oct 2020 12:37:04 +0200	[thread overview]
Message-ID: <20201001103704.GA26287@kozik-lap> (raw)
In-Reply-To: <027fd826-6822-9e92-0c6c-2ebed63f4a07@pengutronix.de>

On Thu, Oct 01, 2020 at 12:19:08PM +0200, Ahmad Fatoum wrote:
> Hi,
> 
> On 10/1/20 9:32 AM, Krzysztof Kozlowski wrote:
> > On Thu, Oct 01, 2020 at 09:22:03AM +0200, Ahmad Fatoum wrote:
> >>> diff --git a/arch/arm/boot/dts/imx6dl-pico-hobbit.dts b/arch/arm/boot/dts/imx6dl-pico-hobbit.dts
> >>> index d7403c5c4337..08fedcbcc91b 100644
> >>> --- a/arch/arm/boot/dts/imx6dl-pico-hobbit.dts
> >>> +++ b/arch/arm/boot/dts/imx6dl-pico-hobbit.dts
> >>> @@ -13,5 +13,5 @@
> >>>  
> >>>  / {
> >>>  	model = "TechNexion PICO-IMX6 DualLite/Solo Board and Hobbit baseboard";
> >>> -	compatible = "technexion,imx6dl-pico", "fsl,imx6dl";
> >>> +	compatible = "technexion,imx6dl-pico-hobbit", "fsl,imx6dl";
> >>>  };
> > 
> > The bindings, added in commit 53b61224ca40 ("dt-bindings: arm: fsl: Add
> > TechNexion boards"), describe that these are the only valid compatibles.
> > "technexion,imx6dl-pico" is not valid and would require changing the
> > bindings, thus breaking compatibility which you want to avoid.> 
> > The bindings, not what is present in DTS, is considered ABI.
> 
> The existing binding doesn't cover these boards then and needs to be
> extended, no? How about following patch?

What do you mean it doesn't cover? It was added exactly to handle them:
+              - technexion,imx6q-pico-dwarf   # TechNexion i.MX6Q Pico-Dwarf
+              - technexion,imx6q-pico-hobbit  # TechNexion i.MX6Q Pico-Hobbit
+              - technexion,imx6q-pico-nymph   # TechNexion i.MX6Q Pico-Nymph
+              - technexion,imx6q-pico-pi      # TechNexion i.MX6Q Pico-Pi

> 
> [I guess we need to keep the two-compatible list they were originally
>  in for compatibility even if it's unused among upstream device trees?]

You want to change both the binding (thus breaking the ABI) and update
the DTS to reflect new ABI. Then why having a binding at all?

I would assume that either binding is correct or DTS. You propose that
both are wrong and both need changes... in such case this is clearly
broken.

Best regards,
Krzysztof

WARNING: multiple messages have this Message-ID
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Ahmad Fatoum <a.fatoum@pengutronix.de>
Cc: devicetree@vger.kernel.org, Robert Jones <rjones@gateworks.com>,
	Stefan Riedmueller <s.riedmueller@phytec.de>,
	Anson Huang <Anson.Huang@nxp.com>,
	Shawn Guo <shawnguo@kernel.org>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	linux-kernel@vger.kernel.org, Li Yang <leoyang.li@nxp.com>,
	Rob Herring <robh+dt@kernel.org>,
	NXP Linux Team <linux-imx@nxp.com>,
	Pengutronix Kernel Team <kernel@pengutronix.de>,
	Andreas Kemnade <andreas@kemnade.info>,
	Fabio Estevam <festevam@gmail.com>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 08/12] ARM: dts: imx6dl-pico: fix board compatibles
Date: Thu, 1 Oct 2020 12:37:04 +0200	[thread overview]
Message-ID: <20201001103704.GA26287@kozik-lap> (raw)
In-Reply-To: <027fd826-6822-9e92-0c6c-2ebed63f4a07@pengutronix.de>

On Thu, Oct 01, 2020 at 12:19:08PM +0200, Ahmad Fatoum wrote:
> Hi,
> 
> On 10/1/20 9:32 AM, Krzysztof Kozlowski wrote:
> > On Thu, Oct 01, 2020 at 09:22:03AM +0200, Ahmad Fatoum wrote:
> >>> diff --git a/arch/arm/boot/dts/imx6dl-pico-hobbit.dts b/arch/arm/boot/dts/imx6dl-pico-hobbit.dts
> >>> index d7403c5c4337..08fedcbcc91b 100644
> >>> --- a/arch/arm/boot/dts/imx6dl-pico-hobbit.dts
> >>> +++ b/arch/arm/boot/dts/imx6dl-pico-hobbit.dts
> >>> @@ -13,5 +13,5 @@
> >>>  
> >>>  / {
> >>>  	model = "TechNexion PICO-IMX6 DualLite/Solo Board and Hobbit baseboard";
> >>> -	compatible = "technexion,imx6dl-pico", "fsl,imx6dl";
> >>> +	compatible = "technexion,imx6dl-pico-hobbit", "fsl,imx6dl";
> >>>  };
> > 
> > The bindings, added in commit 53b61224ca40 ("dt-bindings: arm: fsl: Add
> > TechNexion boards"), describe that these are the only valid compatibles.
> > "technexion,imx6dl-pico" is not valid and would require changing the
> > bindings, thus breaking compatibility which you want to avoid.> 
> > The bindings, not what is present in DTS, is considered ABI.
> 
> The existing binding doesn't cover these boards then and needs to be
> extended, no? How about following patch?

What do you mean it doesn't cover? It was added exactly to handle them:
+              - technexion,imx6q-pico-dwarf   # TechNexion i.MX6Q Pico-Dwarf
+              - technexion,imx6q-pico-hobbit  # TechNexion i.MX6Q Pico-Hobbit
+              - technexion,imx6q-pico-nymph   # TechNexion i.MX6Q Pico-Nymph
+              - technexion,imx6q-pico-pi      # TechNexion i.MX6Q Pico-Pi

> 
> [I guess we need to keep the two-compatible list they were originally
>  in for compatibility even if it's unused among upstream device trees?]

You want to change both the binding (thus breaking the ABI) and update
the DTS to reflect new ABI. Then why having a binding at all?

I would assume that either binding is correct or DTS. You propose that
both are wrong and both need changes... in such case this is clearly
broken.

Best regards,
Krzysztof

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2020-10-01 10:37 UTC|newest]

Thread overview: 64+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-30 19:01 [PATCH v2 00/12] ARM: dts: imx: Board compatibles cleanup Krzysztof Kozlowski
2020-09-30 19:01 ` Krzysztof Kozlowski
2020-09-30 19:01 ` [PATCH v2 01/12] dt-bindings: vendor-prefixes: add MicroSys Krzysztof Kozlowski
2020-09-30 19:01   ` Krzysztof Kozlowski
2020-10-06 17:36   ` Rob Herring
2020-10-06 17:36     ` Rob Herring
2020-09-30 19:01 ` [PATCH v2 02/12] dt-bindings: vendor-prefixes: add Revotics Krzysztof Kozlowski
2020-09-30 19:01   ` Krzysztof Kozlowski
2020-10-06 17:36   ` Rob Herring
2020-10-06 17:36     ` Rob Herring
2020-09-30 19:01 ` [PATCH v2 03/12] dt-bindings: arm: fsl: document i.MX25 and i.MX27 boards Krzysztof Kozlowski
2020-09-30 19:01   ` Krzysztof Kozlowski
2020-09-30 19:01 ` [PATCH v2 04/12] dt-bindings: arm: fsl: document i.MX51 boards Krzysztof Kozlowski
2020-09-30 19:01   ` Krzysztof Kozlowski
2020-09-30 19:01 ` [PATCH v2 05/12] dt-bindings: arm: fsl: document i.MX53 boards Krzysztof Kozlowski
2020-09-30 19:01   ` Krzysztof Kozlowski
2020-09-30 19:01 ` [PATCH v2 06/12] dt-bindings: arm: fsl: document VF boards Krzysztof Kozlowski
2020-09-30 19:01   ` Krzysztof Kozlowski
2020-09-30 19:01 ` [PATCH v2 07/12] dt-bindings: arm: fsl: document i.MX6DL boards Krzysztof Kozlowski
2020-09-30 19:01   ` Krzysztof Kozlowski
2020-09-30 19:01 ` [PATCH v2 08/12] ARM: dts: imx6dl-pico: fix board compatibles Krzysztof Kozlowski
2020-09-30 19:01   ` Krzysztof Kozlowski
2020-10-01  7:22   ` Ahmad Fatoum
2020-10-01  7:22     ` Ahmad Fatoum
2020-10-01  7:32     ` Krzysztof Kozlowski
2020-10-01  7:32       ` Krzysztof Kozlowski
2020-10-01 10:19       ` Ahmad Fatoum
2020-10-01 10:19         ` Ahmad Fatoum
2020-10-01 10:37         ` Krzysztof Kozlowski [this message]
2020-10-01 10:37           ` Krzysztof Kozlowski
2020-10-02  7:41           ` Ahmad Fatoum
2020-10-02  7:41             ` Ahmad Fatoum
2020-10-02  8:20             ` Krzysztof Kozlowski
2020-10-02  8:20               ` Krzysztof Kozlowski
2020-10-02  8:34               ` Ahmad Fatoum
2020-10-02  8:34                 ` Ahmad Fatoum
2020-10-02  8:41               ` Marco Felsch
2020-10-02  8:41                 ` Marco Felsch
2020-10-02 10:36                 ` Krzysztof Kozlowski
2020-10-02 10:36                   ` Krzysztof Kozlowski
2020-10-05 11:39                 ` Fabio Estevam
2020-10-05 11:39                   ` Fabio Estevam
2020-09-30 19:01 ` [PATCH v2 09/12] dt-bindings: vendor-prefixes: add ABB Krzysztof Kozlowski
2020-09-30 19:01   ` Krzysztof Kozlowski
2020-10-01  3:49   ` Heiko Schocher
2020-10-01  3:49     ` Heiko Schocher
2020-10-06 17:38   ` Rob Herring
2020-10-06 17:38     ` Rob Herring
2020-09-30 19:01 ` [PATCH v2 10/12] dt-bindings: arm: fsl: document i.MX6DL Aristainetos boards Krzysztof Kozlowski
2020-09-30 19:01   ` Krzysztof Kozlowski
2020-10-01  3:50   ` Heiko Schocher
2020-10-01  3:50     ` Heiko Schocher
2020-10-06 17:38   ` Rob Herring
2020-10-06 17:38     ` Rob Herring
2020-09-30 19:01 ` [PATCH v2 11/12] ARM: dts: imx6dl: add compatibles for " Krzysztof Kozlowski
2020-09-30 19:01   ` Krzysztof Kozlowski
2020-10-01  3:51   ` Heiko Schocher
2020-10-01  3:51     ` Heiko Schocher
2020-09-30 19:01 ` [PATCH v2 12/12] dt-bindings: arm: fsl: document i.MX6Q boards Krzysztof Kozlowski
2020-09-30 19:01   ` Krzysztof Kozlowski
2020-09-30 19:04   ` Krzysztof Kozlowski
2020-09-30 19:04     ` Krzysztof Kozlowski
2020-10-30  6:51 ` [PATCH v2 00/12] ARM: dts: imx: Board compatibles cleanup Shawn Guo
2020-10-30  6:51   ` Shawn Guo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201001103704.GA26287@kozik-lap \
    --to=krzk@kernel.org \
    --cc=Anson.Huang@nxp.com \
    --cc=a.fatoum@pengutronix.de \
    --cc=andreas@kemnade.info \
    --cc=devicetree@vger.kernel.org \
    --cc=festevam@gmail.com \
    --cc=kernel@pengutronix.de \
    --cc=leoyang.li@nxp.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-imx@nxp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rjones@gateworks.com \
    --cc=robh+dt@kernel.org \
    --cc=s.hauer@pengutronix.de \
    --cc=s.riedmueller@phytec.de \
    --cc=shawnguo@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.