From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1E44BC4727C for ; Thu, 1 Oct 2020 12:15:31 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9641920B1F for ; Thu, 1 Oct 2020 12:15:28 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="KJ5sdBoh"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="wqv79d7g" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9641920B1F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id CF4B7182B; Thu, 1 Oct 2020 14:14:36 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz CF4B7182B DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1601554526; bh=ioh6F6ovm9zl9GAS8exzJ1cS8VGzMqIQ8jI7b6PJDGU=; h=Date:From:To:Subject:References:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=KJ5sdBohRqwUhMOSGbiHkcAg7ntUlbZGOtFGGOsPV5AakIhbuu9qnB7d9h36WGva/ gIboykV474pq931yu0sVhUy82gOuikKL8B9htyHc5iadxMbT0rrY/M1R+14JND4Guo oC/a0w0adFX6+58se+sO/crHAsYbD/YdzV8Bvuzs= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 4DBFAF801DB; Thu, 1 Oct 2020 14:14:36 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 76792F801F5; Thu, 1 Oct 2020 14:14:34 +0200 (CEST) Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 96544F801D8 for ; Thu, 1 Oct 2020 14:14:24 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 96544F801D8 Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="wqv79d7g" Received: from localhost (83-86-74-64.cable.dynamic.v4.ziggo.nl [83.86.74.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 3A5D2207DE; Thu, 1 Oct 2020 12:14:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1601554461; bh=ioh6F6ovm9zl9GAS8exzJ1cS8VGzMqIQ8jI7b6PJDGU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=wqv79d7gJp05Jz5eAUCLC/j84v5bUbEoLurXJnP0fenqc5EDQUBb6917ua1OI5FZk otmXm58yzh26AsmaPMb3GM7PjumkBkpx9mTUVeHqjPibhaH/Asr6lR2TI3tD8tyl8+ EzUm2v7O654UML6ypFu4LqSrNabrhW2B3gik9Jrc= Date: Thu, 1 Oct 2020 14:14:23 +0200 From: Greg KH To: Jason Gunthorpe Subject: Re: [PATCH 1/6] Add ancillary bus support Message-ID: <20201001121423.GA2375307@kroah.com> References: <20200930225051.889607-1-david.m.ertman@intel.com> <20200930225051.889607-2-david.m.ertman@intel.com> <20201001110551.GD1939744@kroah.com> <20201001115847.GY816047@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201001115847.GY816047@nvidia.com> Cc: alsa-devel@alsa-project.org, Kiran Patil , tiwai@suse.de, ranjani.sridharan@intel.com, pierre-louis.bossart@linux.intel.com, Ranjani Sridharan , Fred Oh , broonie@kernel.org, parav@nvidia.com, Dave Ertman , Dan Williams , Shiraz Saleem , Parav Pandit X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Thu, Oct 01, 2020 at 08:58:47AM -0300, Jason Gunthorpe wrote: > On Thu, Oct 01, 2020 at 01:05:51PM +0200, Greg KH wrote: > > > You have to be _VERY_ careful after calling > > ancillary_device_initialize(), as now you can not just free up the > > memory if something goes wrong before ancillary_device_add() is called, > > right? > > I've looked at way too many versions of this patch and related. This > is the only one so far that I didn't find various bugs on the error > cases. But you haven't seen the callers of this function. Without this documented, you will have problems. Why is this two-step process even needed here? thanks, greg k-h