All of lore.kernel.org
 help / color / mirror / Atom feed
From: Serge Semin <Sergey.Semin@baikalelectronics.ru>
To: Mark Brown <broonie@kernel.org>
Cc: Alexey Malahov <Alexey.Malahov@baikalelectronics.ru>,
	Ramil Zaripov <Ramil.Zaripov@baikalelectronics.ru>,
	Pavel Parkhomenko <Pavel.Parkhomenko@baikalelectronics.ru>,
	Andy Shevchenko <andy.shevchenko@gmail.com>,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	Lars Povlsen <lars.povlsen@microchip.com>,
	"wuxu . wu" <wuxu.wu@huawei.com>, Feng Tang <feng.tang@intel.com>,
	Rob Herring <robh+dt@kernel.org>, <linux-spi@vger.kernel.org>,
	<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 02/21] spi: dw: Add DWC SSI capability
Date: Fri, 2 Oct 2020 00:55:32 +0300	[thread overview]
Message-ID: <20201001215532.uxyc77nqehnwsfk5@mobilestation> (raw)
In-Reply-To: <20201001215105.GA6618@sirena.org.uk>

On Thu, Oct 01, 2020 at 10:51:05PM +0100, Mark Brown wrote:
> On Wed, Sep 30, 2020 at 09:55:26PM +0300, Serge Semin wrote:
> > Currently DWC SSI core is supported by means of setting up the
> > core-specific update_cr0() callback. It isn't suitable for multiple
> > reasons. First of all having exported several methods doing the same thing
> > but for different chips makes the code harder to maintain. Secondly the
> > spi-dw-core driver exports the methods, then the spi-dw-mmio driver sets
> 

> This doesn't build with current code in an x86 defconfig, please check
> and resend (looks like you forgot to update dw-pci):
> 
> mnt/kernel/drivers/spi/spi-dw-pci.c: In function 'spi_mid_init':
> /mnt/kernel/drivers/spi/spi-dw-pci.c:52:5: error: 'struct dw_spi' has no member named 'update_cr0'
>   dws->update_cr0 = dw_spi_update_cr0;
>      ^~
> /mnt/kernel/drivers/spi/spi-dw-pci.c:52:20: error: 'dw_spi_update_cr0' undeclared (first use in this function); did you mean 'dw_spi_set_cs'?
>   dws->update_cr0 = dw_spi_update_cr0;
>                     ^~~~~~~~~~~~~~~~~
>                     dw_spi_set_cs
> /mnt/kernel/drivers/spi/spi-dw-pci.c:52:20: note: each undeclared identifier is reported only once for each function it appears in
> /mnt/kernel/drivers/spi/spi-dw-pci.c: In function 'spi_generic_init':
> /mnt/kernel/drivers/spi/spi-dw-pci.c:62:5: error: 'struct dw_spi' has no member named 'update_cr0'
>   dws->update_cr0 = dw_spi_update_cr0;
>      ^~
> /mnt/kernel/drivers/spi/spi-dw-pci.c:62:20: error: 'dw_spi_update_cr0' undeclared (first use in this function); did you mean 'dw_spi_set_cs'?
>   dws->update_cr0 = dw_spi_update_cr0;
>                     ^~~~~~~~~~~~~~~~~
>                     dw_spi_set_cs
> make[3]: *** [/mnt/kernel/scripts/Makefile.build:283: drivers/spi/spi-dw-pci.o] Error 1
> make[2]: *** [/mnt/kernel/scripts/Makefile.build:500: drivers/spi] Error 2
> make[2]: *** Waiting for unfinished jobs....
> make[1]: *** [/mnt/kernel/Makefile:1788: drivers] Error 2
> make[1]: *** Waiting for unfinished jobs....
> make: *** [Makefile:185: __sub-make] Error 2

Oh, thanks for noticing this. I'll fix it straight away and resend. Sorry for
the inconvenience.

-Sergey

  reply	other threads:[~2020-10-01 21:55 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-30 18:55 [PATCH v2 00/21] spi: dw: Add full Baikal-T1 SPI Controllers support Serge Semin
2020-09-30 18:55 ` [PATCH v2 01/21] spi: dw: Use an explicit set_cs assignment Serge Semin
2020-09-30 18:55 ` [PATCH v2 02/21] spi: dw: Add DWC SSI capability Serge Semin
2020-10-01 21:51   ` Mark Brown
2020-10-01 21:55     ` Serge Semin [this message]
2020-09-30 18:55 ` [PATCH v2 03/21] spi: dw: Detach SPI device specific CR0 config method Serge Semin
2020-09-30 18:55 ` [PATCH v2 04/21] spi: dw: Update SPI bus speed in a config function Serge Semin
2020-09-30 18:55 ` [PATCH v2 05/21] spi: dw: Simplify the SPI bus speed config procedure Serge Semin
2020-09-30 18:55 ` [PATCH v2 06/21] spi: dw: Update Rx sample delay in the config function Serge Semin
2020-09-30 18:55 ` [PATCH v2 07/21] spi: dw: Add DW SPI controller config structure Serge Semin
2020-09-30 18:55 ` [PATCH v2 08/21] spi: dw: Refactor data IO procedure Serge Semin
2020-09-30 18:55 ` [PATCH v2 09/21] spi: dw: Refactor IRQ-based SPI transfer procedure Serge Semin
2020-09-30 18:55 ` [PATCH v2 10/21] spi: dw: Perform IRQ setup in a dedicated function Serge Semin
2020-09-30 18:55 ` [PATCH v2 11/21] spi: dw: Unmask IRQs after enabling the chip Serge Semin
2020-09-30 18:55 ` [PATCH v2 12/21] spi: dw: Discard chip enabling on DMA setup error Serge Semin
2020-09-30 18:55 ` [PATCH v2 13/21] spi: dw: De-assert chip-select on reset Serge Semin
2020-09-30 18:55 ` [PATCH v2 14/21] spi: dw: Explicitly de-assert CS on SPI transfer completion Serge Semin
2020-09-30 18:55 ` [PATCH v2 15/21] spi: dw: Move num-of retries parameter to the header file Serge Semin
2020-09-30 18:55 ` [PATCH v2 16/21] spi: dw: Add generic DW SSI status-check method Serge Semin
2020-09-30 18:55 ` [PATCH v2 17/21] spi: dw: Add memory operations support Serge Semin
2020-09-30 18:55 ` [PATCH v2 18/21] spi: dw: Introduce max mem-ops SPI bus frequency setting Serge Semin
2020-09-30 18:55 ` [PATCH v2 19/21] spi: dw: Add poll-based SPI transfers support Serge Semin
2020-09-30 18:55 ` [PATCH v2 20/21] dt-bindings: spi: dw: Add Baikal-T1 SPI Controllers Serge Semin
2020-09-30 18:55 ` [PATCH v2 21/21] spi: dw: Add Baikal-T1 SPI Controller glue driver Serge Semin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201001215532.uxyc77nqehnwsfk5@mobilestation \
    --to=sergey.semin@baikalelectronics.ru \
    --cc=Alexey.Malahov@baikalelectronics.ru \
    --cc=Pavel.Parkhomenko@baikalelectronics.ru \
    --cc=Ramil.Zaripov@baikalelectronics.ru \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=andy.shevchenko@gmail.com \
    --cc=broonie@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=feng.tang@intel.com \
    --cc=lars.povlsen@microchip.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-spi@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    --cc=wuxu.wu@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.