From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8B7F2C4727E for ; Thu, 1 Oct 2020 22:25:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4139F20739 for ; Thu, 1 Oct 2020 22:25:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726741AbgJAWZm (ORCPT ); Thu, 1 Oct 2020 18:25:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46718 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725924AbgJAWZl (ORCPT ); Thu, 1 Oct 2020 18:25:41 -0400 Received: from Chamillionaire.breakpoint.cc (Chamillionaire.breakpoint.cc [IPv6:2a0a:51c0:0:12e:520::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BACC0C0613D0 for ; Thu, 1 Oct 2020 15:25:41 -0700 (PDT) Received: from fw by Chamillionaire.breakpoint.cc with local (Exim 4.92) (envelope-from ) id 1kO716-0001pX-Nv; Fri, 02 Oct 2020 00:25:37 +0200 Date: Fri, 2 Oct 2020 00:25:36 +0200 From: Florian Westphal To: Phil Sutter Cc: Pablo Neira Ayuso , netfilter-devel@vger.kernel.org Subject: Re: [net-next PATCH 0/2] netfilter: Improve inverted IP prefix matches Message-ID: <20201001222536.GB12773@breakpoint.cc> References: <20201001165744.25466-1-phil@nwl.cc> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201001165744.25466-1-phil@nwl.cc> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: netfilter-devel@vger.kernel.org Phil Sutter wrote: > The following two patches improve packet throughput in a test setup > sending UDP packets (using iperf3) between two netns. The ruleset used > on receiver side is like this: > > | *filter > | :test - [0:0] > | -A INPUT -j test > | -A INPUT -j ACCEPT > | -A test ! -s 10.0.0.0/10 -j DROP # this line repeats 10000 times > | COMMIT > > These are the generated VM instructions for each rule: > > | [ payload load 4b @ network header + 12 => reg 1 ] > | [ bitwise reg 1 = (reg=1 & 0x0000c0ff ) ^ 0x00000000 ] Not related to this patch, but we should avoid the bitop if the netmask is divisble by 8 (can adjust the cmp -- adjusting the payload expr is probably not worth it). > | [ cmp eq reg 1 0x0000000a ] > | [ counter pkts 0 bytes 0 ] Out of curiosity, does omitting 'counter' help? nft counter is rather expensive due to bh disable, iptables does it once at the evaluation loop only.