From: David Miller <davem@davemloft.net>
To: weiwan@google.com
Cc: netdev@vger.kernel.org, edumazet@google.com, kuba@kernel.org,
hannes@stressinduktion.org, pabeni@redhat.com, nbd@nbd.name
Subject: Re: [PATCH net-next 0/5] implement kthread based napi poll
Date: Fri, 02 Oct 2020 16:00:42 -0700 (PDT) [thread overview]
Message-ID: <20201002.160042.621154959486835359.davem@davemloft.net> (raw)
In-Reply-To: <20200930192140.4192859-1-weiwan@google.com>
From: Wei Wang <weiwan@google.com>
Date: Wed, 30 Sep 2020 12:21:35 -0700
...
> And the reason we prefer 1 kthread per napi, instead of 1 workqueue
> entity per host, is that kthread is more configurable than workqueue,
> and we could leverage existing tuning tools for threads, like taskset,
> chrt, etc to tune scheduling class and cpu set, etc. Another reason is
> if we eventually want to provide busy poll feature using kernel threads
> for napi poll, kthread seems to be more suitable than workqueue.
...
I think we still need to discuss this some more.
Jakub has some ideas and I honestly think the whole workqueue
approach hasn't been fully considered yet.
If this wan't urgent years ago (when it was NACK'd btw), it isn't
urgent for 5.10 so I don't know why we are pushing so hard for
this patch series to go in as-is right now.
Please be patient and let's have a full discussion on this.
Thank you.
next prev parent reply other threads:[~2020-10-02 23:00 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-30 19:21 [PATCH net-next 0/5] implement kthread based napi poll Wei Wang
2020-09-30 19:21 ` [PATCH net-next 1/5] net: implement threaded-able napi poll loop support Wei Wang
2020-09-30 19:21 ` [PATCH net-next 2/5] net: add sysfs attribute to control napi threaded mode Wei Wang
2020-09-30 19:21 ` [PATCH net-next 3/5] net: extract napi poll functionality to __napi_poll() Wei Wang
2020-09-30 19:21 ` [PATCH net-next 4/5] net: modify kthread handler to use __napi_poll() Wei Wang
2020-09-30 19:21 ` [PATCH net-next 5/5] net: improve napi threaded config Wei Wang
2020-10-01 10:01 ` Felix Fietkau
2020-10-01 17:01 ` Wei Wang
2020-10-01 17:11 ` Felix Fietkau
2020-10-01 18:03 ` Eric Dumazet
2020-10-01 18:37 ` Felix Fietkau
2020-10-01 19:24 ` Wei Wang
2020-10-01 20:48 ` Felix Fietkau
2020-10-01 22:42 ` Wei Wang
2020-09-30 20:08 ` [PATCH net-next 0/5] implement kthread based napi poll Jakub Kicinski
2020-10-01 7:52 ` Eric Dumazet
2020-10-01 20:26 ` Jakub Kicinski
2020-10-01 22:12 ` Wei Wang
2020-10-01 23:46 ` Jakub Kicinski
2020-10-02 1:44 ` Wei Wang
2020-10-02 22:53 ` Jakub Kicinski
2020-10-02 7:56 ` Eric Dumazet
2020-10-02 22:49 ` Jakub Kicinski
2020-10-02 23:00 ` David Miller [this message]
2020-10-02 23:15 ` Alexei Starovoitov
2020-10-03 3:54 ` Eric Dumazet
2020-10-03 4:17 ` Alexei Starovoitov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201002.160042.621154959486835359.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hannes@stressinduktion.org \
--cc=kuba@kernel.org \
--cc=nbd@nbd.name \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=weiwan@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.