From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 69989C47423 for ; Fri, 2 Oct 2020 04:55:07 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2455C20754 for ; Fri, 2 Oct 2020 04:55:06 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="eyGGpeQo"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="nYKRuLwF" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2455C20754 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 8D6A61B12; Fri, 2 Oct 2020 06:54:14 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 8D6A61B12 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1601614504; bh=bCmmWqAsFkwPqsZmxhmOuAbTTiibdUhS7KiD5F5hfaQ=; h=Date:From:To:Subject:References:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=eyGGpeQoQLUO4gckeMBKEMemaQesUJWQ8x8TlEpb50uj5n8JGs9Rt6gKq+OxnQpoh YStS1PFBjDWZh/1NKVX0wagPlVyYRSuPKIQ2JLmMzaZQKwGGD5pK7JVCyd1saCFNuM ovHENro+Fzen+T4mxtVr5CC/2eY6jyLKTz7howkE= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 04EE5F801ED; Fri, 2 Oct 2020 06:54:13 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 0F67EF801F9; Fri, 2 Oct 2020 06:54:12 +0200 (CEST) Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 11FC7F800E5 for ; Fri, 2 Oct 2020 06:54:04 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 11FC7F800E5 Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="nYKRuLwF" Received: from localhost (83-86-74-64.cable.dynamic.v4.ziggo.nl [83.86.74.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id DAB1820754; Fri, 2 Oct 2020 04:54:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1601614441; bh=bCmmWqAsFkwPqsZmxhmOuAbTTiibdUhS7KiD5F5hfaQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=nYKRuLwFbogHosqwkLqWvKfwCNh9fW7l4Zi1UZBuITD+/44VyP7f5SAmB5sbV15qf 5FE381fnJ7YhqOgoHV+2gFK7zcRkwRmuGIiyD+dFu3z/Mah0zk9X8lkiVN36tpsdFT Dj+Htly5929Jhlyg+pkJqsMhU5fyDCv4hGKjdau0= Date: Fri, 2 Oct 2020 06:53:57 +0200 From: "gregkh@linuxfoundation.org" To: "Sridharan, Ranjani" Subject: Re: [PATCH 2/6] ASoC: SOF: Introduce descriptors for SOF client Message-ID: <20201002045357.GA34005@kroah.com> References: <20200930225051.889607-1-david.m.ertman@intel.com> <20200930225051.889607-3-david.m.ertman@intel.com> <20201001130245.GB2378679@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Cc: "alsa-devel@alsa-project.org" , "tiwai@suse.de" , "pierre-louis.bossart@linux.intel.com" , "fred.oh@linux.intel.com" , "broonie@kernel.org" , "parav@nvidia.com" , "jgg@nvidia.com" , "Ertman, David M" X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Thu, Oct 01, 2020 at 10:16:00PM +0000, Sridharan, Ranjani wrote: > On Thu, 2020-10-01 at 15:02 +0200, Greg KH wrote: > > On Wed, Sep 30, 2020 at 03:50:47PM -0700, Dave Ertman wrote: > > > From: Ranjani Sridharan > > > > > > A client in the SOF (Sound Open Firmware) context is a > > > device that needs to communicate with the DSP via IPC > > > messages. The SOF core is responsible for serializing the > > > IPC messages to the DSP from the different clients. One > > > example of an SOF client would be an IPC test client that > > > floods the DSP with test IPC messages to validate if the > > > serialization works as expected. Multi-client support will > > > also add the ability to split the existing audio cards > > > into multiple ones, so as to e.g. to deal with HDMI with a > > > dedicated client instead of adding HDMI to all cards. > > > > > > This patch introduces descriptors for SOF client driver > > > and SOF client device along with APIs for registering > > > and unregistering a SOF client driver, sending IPCs from > > > a client device and accessing the SOF core debugfs root entry. > > > > > > Along with this, add a couple of new members to struct > > > snd_sof_dev that will be used for maintaining the list of > > > clients. > > > > > > Reviewed-by: Pierre-Louis Bossart < > > > pierre-louis.bossart@linux.intel.com> > > > Signed-off-by: Ranjani Sridharan > > > > > > Co-developed-by: Fred Oh > > > Signed-off-by: Fred Oh > > > Signed-off-by: Dave Ertman > > > --- > > > sound/soc/sof/Kconfig | 19 ++++++ > > > sound/soc/sof/Makefile | 3 + > > > sound/soc/sof/core.c | 2 + > > > sound/soc/sof/sof-client.c | 117 > > > +++++++++++++++++++++++++++++++++++++ > > > sound/soc/sof/sof-client.h | 65 +++++++++++++++++++++ > > > sound/soc/sof/sof-priv.h | 6 ++ > > > 6 files changed, 212 insertions(+) > > > create mode 100644 sound/soc/sof/sof-client.c > > > create mode 100644 sound/soc/sof/sof-client.h > > > > As you are creating new sysfs directories, you should have some > > documentation for them :( > Hi Greg, > > We are not adding any sysfs entries in this series. You added directories in sysfs, right?