From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6B186C4363D for ; Fri, 2 Oct 2020 06:55:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2DB65206FA for ; Fri, 2 Oct 2020 06:55:04 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="dPcWs/ve" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725995AbgJBGzA (ORCPT ); Fri, 2 Oct 2020 02:55:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41174 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725948AbgJBGzA (ORCPT ); Fri, 2 Oct 2020 02:55:00 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CA833C0613D0; Thu, 1 Oct 2020 23:54:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=wsszzdNdt8/s5qmse2DtQE9T6ptZdmllS5Ln6Q6wU9w=; b=dPcWs/vek1tL6i1nQlvOrE1uA7 8xNJ8Oje5kX7lSLWTZyOtzuVqtVFyeYSK1k+YIC4hGdDMAVJix1JWLikC5X5IMWqei9i4rHgZwVGd SD0S05U3c/JiwtVUkoPuwiYZEYROVD9jo7aNA0uZo8FMJLUmj6UXjrCS4I45G+y+s0isM6bwvh7dP Mb6tKl+tTbGqe6MJsL9Z5CDppphb88mIwyztnvEAI6ZVtZ3QFkMZaFBUXwFdYq3zWn+lXU7X1M9Hz qUm9iN54MuQJB97nh2XBZhPFT665ncwJylT4Br6ojvvNBQiuEsWumjLPjZeirdZDZIV/cZjn1eiSn 472YLMnw==; Received: from hch by casper.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1kOExy-0007q1-6R; Fri, 02 Oct 2020 06:54:54 +0000 Date: Fri, 2 Oct 2020 07:54:54 +0100 From: Christoph Hellwig To: Nick Terrell Cc: Christoph Hellwig , Nick Terrell , Herbert Xu , "linux-crypto@vger.kernel.org" , Btrfs BTRFS , "squashfs-devel@lists.sourceforge.net" , "linux-f2fs-devel@lists.sourceforge.net" , "linux-kernel@vger.kernel.org" , Kernel Team , Chris Mason , Petr Malat , Johannes Weiner , Niket Agarwal , Yann Collet , Greg Kroah-Hartman Subject: Re: [PATCH v4 0/9] Update to zstd-1.4.6 Message-ID: <20201002065454.GA29993@infradead.org> References: <20200930065318.3326526-1-nickrterrell@gmail.com> <20200930065336.GA13656@infradead.org> <8743398B-0BBB-424E-A6A7-9D8AE4EFE8ED@fb.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <8743398B-0BBB-424E-A6A7-9D8AE4EFE8ED@fb.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On Wed, Sep 30, 2020 at 08:05:45PM +0000, Nick Terrell wrote: > > > > On Sep 29, 2020, at 11:53 PM, Christoph Hellwig wrote: > > > > As you keep resend this I keep retelling you that should not do it. > > Please provide a proper Linux API, and switch to that. Versioned APIs > > have absolutely no business in the Linux kernel. > > The API is not versioned. We provide a stable ABI for a large section of our API, > and the parts that aren???t ABI stable don???t change in semantics, and undergo long > deprecation periods before being removed. > > The change of callers is a one-time change to transition from the existing API > in the kernel, which was never upstream's API, to upstream's API. Again, please transition it to a sane kernel API. We don't have an "upstream" in this case. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AD4D0C4363D for ; Fri, 2 Oct 2020 06:55:51 +0000 (UTC) Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1FD92206DD; Fri, 2 Oct 2020 06:55:50 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=sourceforge.net header.i=@sourceforge.net header.b="nVXnAWsZ"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=sf.net header.i=@sf.net header.b="TWTzQjxe"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="dPcWs/ve" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1FD92206DD Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linux-f2fs-devel-bounces@lists.sourceforge.net Received: from [127.0.0.1] (helo=sfs-ml-2.v29.lw.sourceforge.com) by sfs-ml-2.v29.lw.sourceforge.com with esmtp (Exim 4.90_1) (envelope-from ) id 1kOEyq-000405-UU; Fri, 02 Oct 2020 06:55:48 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-2.v29.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kOEyX-0003zA-Jr; Fri, 02 Oct 2020 06:55:29 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=In-Reply-To:Content-Type:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=wsszzdNdt8/s5qmse2DtQE9T6ptZdmllS5Ln6Q6wU9w=; b=nVXnAWsZ71xuMg0P2cWswsoPap S3GL4epL5cSeohoBU/BgmMgOMNKvsyhtuHDMqU5mbb/JKZxCsZ+V12IGFyPDd7Eebt9Hji/93FU7H aBho59dcNJGr4JNCh9WW88/E+/YaBcyA7NSiYMUJyHrHH4Sxm+6kxAHfbVVHF1RHOFSY=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To :From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=wsszzdNdt8/s5qmse2DtQE9T6ptZdmllS5Ln6Q6wU9w=; b=TWTzQjxer6UANyvBQ6Bi8k0rIi N4JO2DYPp0OFst4XJEJAq1zGddOlAhPyjp7GV09aef3BRpOXfL2uHKcapbQqa0H5ADiqmF6VapiWJ z3dhsJJrJ5lvyd47PsgEnyC2HjwSDLrv5+TkKMW1OBt5KloQ5TflSpd9RQ1LPjgrv8as=; Received: from casper.infradead.org ([90.155.50.34]) by sfi-mx-3.v28.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92.2) id 1kOEyL-00DnNN-5u; Fri, 02 Oct 2020 06:55:29 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=wsszzdNdt8/s5qmse2DtQE9T6ptZdmllS5Ln6Q6wU9w=; b=dPcWs/vek1tL6i1nQlvOrE1uA7 8xNJ8Oje5kX7lSLWTZyOtzuVqtVFyeYSK1k+YIC4hGdDMAVJix1JWLikC5X5IMWqei9i4rHgZwVGd SD0S05U3c/JiwtVUkoPuwiYZEYROVD9jo7aNA0uZo8FMJLUmj6UXjrCS4I45G+y+s0isM6bwvh7dP Mb6tKl+tTbGqe6MJsL9Z5CDppphb88mIwyztnvEAI6ZVtZ3QFkMZaFBUXwFdYq3zWn+lXU7X1M9Hz qUm9iN54MuQJB97nh2XBZhPFT665ncwJylT4Br6ojvvNBQiuEsWumjLPjZeirdZDZIV/cZjn1eiSn 472YLMnw==; Received: from hch by casper.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1kOExy-0007q1-6R; Fri, 02 Oct 2020 06:54:54 +0000 Date: Fri, 2 Oct 2020 07:54:54 +0100 From: Christoph Hellwig To: Nick Terrell Message-ID: <20201002065454.GA29993@infradead.org> References: <20200930065318.3326526-1-nickrterrell@gmail.com> <20200930065336.GA13656@infradead.org> <8743398B-0BBB-424E-A6A7-9D8AE4EFE8ED@fb.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <8743398B-0BBB-424E-A6A7-9D8AE4EFE8ED@fb.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html X-Headers-End: 1kOEyL-00DnNN-5u Subject: Re: [f2fs-dev] [PATCH v4 0/9] Update to zstd-1.4.6 X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "squashfs-devel@lists.sourceforge.net" , Herbert Xu , Nick Terrell , Yann Collet , Petr Malat , "linux-kernel@vger.kernel.org" , "linux-f2fs-devel@lists.sourceforge.net" , Christoph Hellwig , Chris Mason , "linux-crypto@vger.kernel.org" , Greg Kroah-Hartman , Kernel Team , Niket Agarwal , Btrfs BTRFS , Johannes Weiner Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net On Wed, Sep 30, 2020 at 08:05:45PM +0000, Nick Terrell wrote: > > > > On Sep 29, 2020, at 11:53 PM, Christoph Hellwig wrote: > > > > As you keep resend this I keep retelling you that should not do it. > > Please provide a proper Linux API, and switch to that. Versioned APIs > > have absolutely no business in the Linux kernel. > > The API is not versioned. We provide a stable ABI for a large section of our API, > and the parts that aren???t ABI stable don???t change in semantics, and undergo long > deprecation periods before being removed. > > The change of callers is a one-time change to transition from the existing API > in the kernel, which was never upstream's API, to upstream's API. Again, please transition it to a sane kernel API. We don't have an "upstream" in this case. _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel