From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 42720C4363D for ; Fri, 2 Oct 2020 11:39:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 03DF2206E3 for ; Fri, 2 Oct 2020 11:39:48 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b="kQh4ocMe" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387717AbgJBLjr (ORCPT ); Fri, 2 Oct 2020 07:39:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56612 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725964AbgJBLjr (ORCPT ); Fri, 2 Oct 2020 07:39:47 -0400 Received: from mail-qv1-xf42.google.com (mail-qv1-xf42.google.com [IPv6:2607:f8b0:4864:20::f42]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 62574C0613D0 for ; Fri, 2 Oct 2020 04:39:47 -0700 (PDT) Received: by mail-qv1-xf42.google.com with SMTP id j10so559424qvk.11 for ; Fri, 02 Oct 2020 04:39:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=q4iK1I/SnNAoc+7Y+E8xiOO2Lt6oZM4orbJzQinvTvs=; b=kQh4ocMexmYDSbQ5KWrwdjVrKH3hcwpgq8aAUpOrtz7LIAcY6z1nGDvzWxWXPyDX8G FNL8V9YmTeOLHsW4KqHlaFqTBorTQEIVM5rjcvrCBxtpU/WqYFPDhZ17jkYT4056IZkC Ow8D8qF/wZkTtz3xkSXJxrmh3YgIZE/gwpsn8heaiVL0SjoZm3P7J1XGBzqD9qW5kfgL XD7c1Ua9PBS/kzHnTlh3D2Aqkjp603UN1PRCkxf0IrLUx5Z7KyIWTBh4xOmBKVV54cs+ XjXd6QOgu4CqIJNgMTnIvYNtyZX0IL4DHocziXzl9kwGI44vH9rajDP3SRFIOaaAag+V r5/A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=q4iK1I/SnNAoc+7Y+E8xiOO2Lt6oZM4orbJzQinvTvs=; b=GCwueyVXmlAOUbS2X0YgeO9lWi21Id2IS+c9I2+Wz1rlP8xM7xZXVq+y6Deguuw1i+ UTioQZkpff5OtsVpemQ7/PZvH9/F1SjHwN6vshXAcH23daj/2RxMlPPK580EzZNHxA1K jrX2bEltV6FdchbYjdNktpawouxVzZqwMpEIqTH8vtxl9BydddWWxsyIrPTOUNBh6Ag3 CcJrN1zvMBy5kUpvlh9OxxwRQoJXXM0p6vGZayUB0ugHeknIGQ+pCu3lw7GCourL4P6i 2iouyKSP+sDQhpu7ghTWW4wLfkrpD4wm4gakdpHFRmj4CpUlwO8FnxatoBqW/TLHss7d vVhg== X-Gm-Message-State: AOAM5334kiMaKhPOciL9o9NG2Wdanrx6tT7+DnUrqIBWIIPbcsyJpx96 hmyiaobsQESUfBuCYNo3nFQJ0A== X-Google-Smtp-Source: ABdhPJyj4/OCeK99T3cxyXoCe9rfZhXRSkt6RP3645TYyjAREoTemtw4nsP/mTiWY/lLuXpZi11ULA== X-Received: by 2002:a0c:dd81:: with SMTP id v1mr1742177qvk.62.1601638786662; Fri, 02 Oct 2020 04:39:46 -0700 (PDT) Received: from ziepe.ca (hlfxns017vw-156-34-48-30.dhcp-dynamic.fibreop.ns.bellaliant.net. [156.34.48.30]) by smtp.gmail.com with ESMTPSA id h40sm827396qte.59.2020.10.02.04.39.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 02 Oct 2020 04:39:45 -0700 (PDT) Received: from jgg by mlx with local (Exim 4.94) (envelope-from ) id 1kOJPd-005Yy6-0U; Fri, 02 Oct 2020 08:39:45 -0300 Date: Fri, 2 Oct 2020 08:39:44 -0300 From: Jason Gunthorpe To: Michel Lespinasse Cc: Jann Horn , Andrew Morton , linux-mm , LKML , "Eric W . Biederman" , Mauro Carvalho Chehab , Sakari Ailus , Jeff Dike , Richard Weinberger , Anton Ivanov , linux-um@lists.infradead.org, John Hubbard Subject: Re: [PATCH 1/2] mmap locking API: Order lock of nascent mm outside lock of live mm Message-ID: <20201002113944.GH9916@ziepe.ca> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Oct 02, 2020 at 02:17:49AM -0700, Michel Lespinasse wrote: > Also FYI I was going to play with these patches a bit to help answer > these questions on my own, but wasn't able to easily apply them as > they came lightly mangled (whitespace issues) when I saved them. Me too It seems OK, you've created sort of a SINGLE_DEPTH_NESTING but in reverse - instead of marking the child of the nest it marks the parent. It would be nice to add a note in the commit message where the nesting happens on this path. Thanks, Jason From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qv1-xf44.google.com ([2607:f8b0:4864:20::f44]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kOJPk-0003hp-RH for linux-um@lists.infradead.org; Fri, 02 Oct 2020 11:39:53 +0000 Received: by mail-qv1-xf44.google.com with SMTP id b13so584743qvl.2 for ; Fri, 02 Oct 2020 04:39:47 -0700 (PDT) Date: Fri, 2 Oct 2020 08:39:44 -0300 From: Jason Gunthorpe Subject: Re: [PATCH 1/2] mmap locking API: Order lock of nascent mm outside lock of live mm Message-ID: <20201002113944.GH9916@ziepe.ca> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-um" Errors-To: linux-um-bounces+geert=linux-m68k.org@lists.infradead.org To: Michel Lespinasse Cc: Jann Horn , Richard Weinberger , Jeff Dike , linux-um@lists.infradead.org, LKML , linux-mm , "Eric W . Biederman" , Sakari Ailus , John Hubbard , Andrew Morton , Mauro Carvalho Chehab , Anton Ivanov On Fri, Oct 02, 2020 at 02:17:49AM -0700, Michel Lespinasse wrote: > Also FYI I was going to play with these patches a bit to help answer > these questions on my own, but wasn't able to easily apply them as > they came lightly mangled (whitespace issues) when I saved them. Me too It seems OK, you've created sort of a SINGLE_DEPTH_NESTING but in reverse - instead of marking the child of the nest it marks the parent. It would be nice to add a note in the commit message where the nesting happens on this path. Thanks, Jason _______________________________________________ linux-um mailing list linux-um@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-um