From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 879D4C4363D for ; Fri, 2 Oct 2020 11:57:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6015F20874 for ; Fri, 2 Oct 2020 11:57:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387841AbgJBL5l (ORCPT ); Fri, 2 Oct 2020 07:57:41 -0400 Received: from foss.arm.com ([217.140.110.172]:33818 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387768AbgJBL5l (ORCPT ); Fri, 2 Oct 2020 07:57:41 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 748CE1063; Fri, 2 Oct 2020 04:57:40 -0700 (PDT) Received: from e121166-lin.cambridge.arm.com (e121166-lin.cambridge.arm.com [10.1.196.255]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id A82793F70D; Fri, 2 Oct 2020 04:57:39 -0700 (PDT) Date: Fri, 2 Oct 2020 12:57:37 +0100 From: Lorenzo Pieralisi To: Qinglang Miao Cc: Rob Herring , Bjorn Helgaas , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH -next] PCI: loongson: simplify the return expression of loongson_pci_probe() Message-ID: <20201002115737.GD23640@e121166-lin.cambridge.arm.com> References: <20200921131054.92797-1-miaoqinglang@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200921131054.92797-1-miaoqinglang@huawei.com> User-Agent: Mutt/1.9.4 (2018-02-28) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Sep 21, 2020 at 09:10:54PM +0800, Qinglang Miao wrote: > Simplify the return expression. > > Signed-off-by: Qinglang Miao > --- > drivers/pci/controller/pci-loongson.c | 7 +------ > 1 file changed, 1 insertion(+), 6 deletions(-) Applied to pci/loongson, thanks. Lorenzo > diff --git a/drivers/pci/controller/pci-loongson.c b/drivers/pci/controller/pci-loongson.c > index 719c19fe2..48169b1e3 100644 > --- a/drivers/pci/controller/pci-loongson.c > +++ b/drivers/pci/controller/pci-loongson.c > @@ -183,7 +183,6 @@ static int loongson_pci_probe(struct platform_device *pdev) > struct device_node *node = dev->of_node; > struct pci_host_bridge *bridge; > struct resource *regs; > - int err; > > if (!node) > return -ENODEV; > @@ -222,11 +221,7 @@ static int loongson_pci_probe(struct platform_device *pdev) > bridge->ops = &loongson_pci_ops; > bridge->map_irq = loongson_map_irq; > > - err = pci_host_probe(bridge); > - if (err) > - return err; > - > - return 0; > + return pci_host_probe(bridge); > } > > static struct platform_driver loongson_pci_driver = { > -- > 2.23.0 >