From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5802BC47426 for ; Fri, 2 Oct 2020 12:32:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1401D2074B for ; Fri, 2 Oct 2020 12:32:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1601641922; bh=DjB3lJ5elsAGKLAg+aUvxF4JFE/JZNPDkxVAMkFNT9Q=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=xENIsQFlcYf3E6gDQda+29An3e1pItNDK7G7Q62XmAFLmpMbZhwzZaFDx+yG3tmy9 xp8naExQ4uFPmYelGi+4fykiSTRn18C2rjSUBzIVzAIgCiTwXzBcvVXxM1N9PuZrMq Nx+11o5yOynvD+U6Y/dwI5QJ+rahfcs93mafH8g8= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387893AbgJBMcB convert rfc822-to-8bit (ORCPT ); Fri, 2 Oct 2020 08:32:01 -0400 Received: from mail-ej1-f66.google.com ([209.85.218.66]:38847 "EHLO mail-ej1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726017AbgJBMb7 (ORCPT ); Fri, 2 Oct 2020 08:31:59 -0400 Received: by mail-ej1-f66.google.com with SMTP id ce10so1725670ejc.5; Fri, 02 Oct 2020 05:31:57 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=ruty7DVy+OZPgSY4H/PWNx+35iqlcL+AUfsjOvXskTs=; b=bCidhWP34d7hMNiuycxC4287P50KNdhUGOpcSVSh8X3Y17my6Oqo2/kyG8WjruGyrF Lm+TXvzaCphpGV1DF9R1x66vNB9h67zBPB+RB72Sr3KNTFL8KvWL5sOu2nJE79BqFB05 gBpW0Hm9nR7q3UQuNH0+XSq7wdjpdIVDORyZ2soCYm0dYePfFWHCUrpTOtdPit6kewjB e0LwG9wUrxzlFeas9mnMOG9GKsD7JOQx9F8pbaoqrKD1gFffSfYFC98oahTvyT8bGkxh msaBQ5pS8RB9RD+5goykYKZqcoPyKMv8m8HeIutN9co3STxYosnwmsOK5G5FHabXl6vC OPYA== X-Gm-Message-State: AOAM533mqHZKRCTMcghRzpGgTAvAN9+sYGYXA0CRTVxhFL08lF+I95JX s9zTmRslrvUAzoJ9paSUWLk7xH3Vd+Q= X-Google-Smtp-Source: ABdhPJyhM3dwv7SEyAI4chEDpCbHJ/cxuWy1xtuG8hiRd28Nc8mdupnHvxGqdM5WftW4lVi38BAeFQ== X-Received: by 2002:a17:906:37c6:: with SMTP id o6mr2118364ejc.404.1601641917025; Fri, 02 Oct 2020 05:31:57 -0700 (PDT) Received: from pi3 ([194.230.155.194]) by smtp.googlemail.com with ESMTPSA id a22sm1039191ejt.65.2020.10.02.05.31.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 02 Oct 2020 05:31:55 -0700 (PDT) Date: Fri, 2 Oct 2020 14:31:53 +0200 From: Krzysztof Kozlowski To: =?utf-8?Q?=C5=81ukasz?= Stelmach Cc: Kukjin Kim , Tomasz Figa , Andi Shyti , Mark Brown , linux-spi@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Marek Szyprowski , =?utf-8?Q?Bart=C5=82omiej_=C5=BBo=C5=82nierkiewicz?= Subject: Re: [PATCH v3 7/9] spi: spi-s3c64xx: Ensure cur_speed holds actual clock value Message-ID: <20201002123153.GA7463@pi3> References: <20201002122243.26849-1-l.stelmach@samsung.com> <20201002122243.26849-8-l.stelmach@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8BIT In-Reply-To: <20201002122243.26849-8-l.stelmach@samsung.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Oct 02, 2020 at 02:22:41PM +0200, Łukasz Stelmach wrote: > Make sure the cur_speed value used in s3c64xx_enable_datapath() > to configure DMA channel and in s3c64xx_wait_for_*() to calculate the > transfer timeout is set to the actual value of (half) the clock speed. > > Don't change non-CMU case, because no frequency calculation errors have > been reported. > > Reviewed-by: Krzysztof Kozlowski > Suggested-by: Tomasz Figa > Signed-off-by: Łukasz Stelmach For the future, tags are added in chronological order, so first is suggested (as someone suggested to make a patch), then your SoB (as you wrote it) and then my review (because you had to write a patch before I could review). All other patches here have these mixed up. No need to resend, but keep it in mind for the future. Best regards, Krzysztof From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 37275C4363D for ; Fri, 2 Oct 2020 12:33:26 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D44A5206DB for ; Fri, 2 Oct 2020 12:33:25 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="RE16LeFT" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D44A5206DB Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=fRIIyPIcx+xhK+c1YU7AI1lW/uxf+DrpOKpIINQqwzw=; b=RE16LeFT4TFuJ74hWmfh4W64A y6lmGYyiefcno7iCz2sqMoYFguHQ+lO4lUmExG5W0hIeP12/CCDzbyNH5YrERNOMKxJC3V6JR548w jhh1/qi/6PiixUiGhcEFPJrvf/0VAMhs/JI0nwiSRZb+aCU9iNEu2h3g791o1C6HrrV7x0cS49vq0 KfmGhnKCNtYR1o6cN2/EA3gjO0DkgerAKOKGmN1wMRkk7fVCnN5QCWKGQj14PM6n6tGi9YZekboNc JSw2TChWOGb3bZubCqipRVqhOmZCheMYHayyTOHngHlm6E3AG5lcaYkS3eCLidPHNvVQleXDwMhDQ bOcHkCang==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kOKEC-0005Fu-CK; Fri, 02 Oct 2020 12:32:00 +0000 Received: from mail-ej1-f65.google.com ([209.85.218.65]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kOKEA-0005FM-AJ for linux-arm-kernel@lists.infradead.org; Fri, 02 Oct 2020 12:31:59 +0000 Received: by mail-ej1-f65.google.com with SMTP id nw23so1728477ejb.4 for ; Fri, 02 Oct 2020 05:31:57 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=ruty7DVy+OZPgSY4H/PWNx+35iqlcL+AUfsjOvXskTs=; b=KXmgx6MPZvjl9PXPu/lJvFdQxkpbelkGU/hr+nLEVObHgMlYCzrhH+00HhKJNIc4i1 7luBpUbYsHfJN/8MUSOw8ZTjpX/BplCoS7qCvDEuo2EheKoeDzF3lQu5Fv25gm2zfVKW tMR6AdxQ6+OFoi25I97vqOR41TJNBdFqAwyu0J9DwFZwFsC074TZHP2lJJuOOMvNKGEW lyw+Pt0nxDntvC68KuH2PiajTL/gDSEzg8Rb4/0o6C6pRRkns8Xat0UOxwlN59Sjn3Fx YKNmHpbroxNsxxPsqTy8yCFPEInqo4ND9Fc8/e04+dFuTrcpuHxsirvXyP+sbZX6nKo8 jY2Q== X-Gm-Message-State: AOAM533rtZvsO/MNoGbb800nINyMMTydrvueSGLbTYwqYfs+FOdaB6df Z26oaLJUgcohWO7odFQjTwo= X-Google-Smtp-Source: ABdhPJyhM3dwv7SEyAI4chEDpCbHJ/cxuWy1xtuG8hiRd28Nc8mdupnHvxGqdM5WftW4lVi38BAeFQ== X-Received: by 2002:a17:906:37c6:: with SMTP id o6mr2118364ejc.404.1601641917025; Fri, 02 Oct 2020 05:31:57 -0700 (PDT) Received: from pi3 ([194.230.155.194]) by smtp.googlemail.com with ESMTPSA id a22sm1039191ejt.65.2020.10.02.05.31.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 02 Oct 2020 05:31:55 -0700 (PDT) Date: Fri, 2 Oct 2020 14:31:53 +0200 From: Krzysztof Kozlowski To: =?utf-8?Q?=C5=81ukasz?= Stelmach Subject: Re: [PATCH v3 7/9] spi: spi-s3c64xx: Ensure cur_speed holds actual clock value Message-ID: <20201002123153.GA7463@pi3> References: <20201002122243.26849-1-l.stelmach@samsung.com> <20201002122243.26849-8-l.stelmach@samsung.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20201002122243.26849-8-l.stelmach@samsung.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201002_083158_370750_29420BD2 X-CRM114-Status: GOOD ( 13.35 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-samsung-soc@vger.kernel.org, =?utf-8?Q?Bart=C5=82omiej_=C5=BBo=C5=82nierkiewicz?= , linux-kernel@vger.kernel.org, Tomasz Figa , linux-spi@vger.kernel.org, Mark Brown , Kukjin Kim , Andi Shyti , linux-arm-kernel@lists.infradead.org, Marek Szyprowski Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gRnJpLCBPY3QgMDIsIDIwMjAgYXQgMDI6MjI6NDFQTSArMDIwMCwgxYF1a2FzeiBTdGVsbWFj aCB3cm90ZToKPiBNYWtlIHN1cmUgdGhlIGN1cl9zcGVlZCB2YWx1ZSB1c2VkIGluIHMzYzY0eHhf ZW5hYmxlX2RhdGFwYXRoKCkKPiB0byBjb25maWd1cmUgRE1BIGNoYW5uZWwgYW5kIGluIHMzYzY0 eHhfd2FpdF9mb3JfKigpIHRvIGNhbGN1bGF0ZSB0aGUKPiB0cmFuc2ZlciB0aW1lb3V0IGlzIHNl dCB0byB0aGUgYWN0dWFsIHZhbHVlIG9mIChoYWxmKSB0aGUgY2xvY2sgc3BlZWQuCj4gCj4gRG9u J3QgY2hhbmdlIG5vbi1DTVUgY2FzZSwgYmVjYXVzZSBubyBmcmVxdWVuY3kgY2FsY3VsYXRpb24g ZXJyb3JzIGhhdmUKPiBiZWVuIHJlcG9ydGVkLgo+IAo+IFJldmlld2VkLWJ5OiBLcnp5c3p0b2Yg S296bG93c2tpIDxrcnprQGtlcm5lbC5vcmc+Cj4gU3VnZ2VzdGVkLWJ5OiBUb21hc3ogRmlnYSA8 dG9tYXN6LmZpZ2FAZ21haWwuY29tPgo+IFNpZ25lZC1vZmYtYnk6IMWBdWthc3ogU3RlbG1hY2gg PGwuc3RlbG1hY2hAc2Ftc3VuZy5jb20+CgpGb3IgdGhlIGZ1dHVyZSwgdGFncyBhcmUgYWRkZWQg aW4gY2hyb25vbG9naWNhbCBvcmRlciwgc28gZmlyc3QgaXMKc3VnZ2VzdGVkIChhcyBzb21lb25l IHN1Z2dlc3RlZCB0byBtYWtlIGEgcGF0Y2gpLCB0aGVuIHlvdXIgU29CIChhcyB5b3UKd3JvdGUg aXQpIGFuZCB0aGVuIG15IHJldmlldyAoYmVjYXVzZSB5b3UgaGFkIHRvIHdyaXRlIGEgcGF0Y2gg YmVmb3JlIEkKY291bGQgcmV2aWV3KS4KCkFsbCBvdGhlciBwYXRjaGVzIGhlcmUgaGF2ZSB0aGVz ZSBtaXhlZCB1cC4gTm8gbmVlZCB0byByZXNlbmQsIGJ1dCBrZWVwCml0IGluIG1pbmQgZm9yIHRo ZSBmdXR1cmUuCgpCZXN0IHJlZ2FyZHMsCktyenlzenRvZgoKCl9fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fCmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0 CmxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFk ZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK