From: Herbert Xu <herbert@gondor.apana.org.au>
To: Christophe Leroy <christophe.leroy@csgroup.eu>
Cc: "Linux Crypto Mailing List" <linux-crypto@vger.kernel.org>,
"Horia Geantă" <horia.geanta@nxp.com>,
"Kim Phillips" <kim.phillips@arm.com>
Subject: Re: [PATCH] crypto: talitos - Fix sparse warnings
Date: Fri, 2 Oct 2020 22:42:23 +1000 [thread overview]
Message-ID: <20201002124223.GA1547@gondor.apana.org.au> (raw)
In-Reply-To: <be222fed-425b-d55c-3efc-9c4e873ccf8e@csgroup.eu>
On Fri, Oct 02, 2020 at 02:40:00PM +0200, Christophe Leroy wrote:
>
> However I guess the initial intention was to avoid conversion as much as
> possible. Most tests and bit wise operations can be done regardless of the
> endianess, that's the reason why the endianness conversion was applied to
> constants, in order to apply them at build time and avoid converting vars
> back and forth during runtime.
>
> I have not looked at your patch in details but I have the feeling you are
> defeating this initial purpose.
I don't think that's a valid optimisation unless it's backed up
with real numbers.
Cheers,
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
next prev parent reply other threads:[~2020-10-02 12:42 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-02 11:52 [PATCH] crypto: talitos - Fix sparse warnings Herbert Xu
2020-10-02 12:40 ` Christophe Leroy
2020-10-02 12:42 ` Herbert Xu [this message]
2020-10-02 12:43 ` Herbert Xu
2020-10-03 17:15 ` Christophe Leroy
2020-10-03 17:15 ` Christophe Leroy
2020-10-07 6:50 ` Herbert Xu
2020-10-07 6:50 ` Herbert Xu
2020-10-08 9:50 ` Christophe Leroy
2020-10-08 9:50 ` Christophe Leroy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201002124223.GA1547@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=christophe.leroy@csgroup.eu \
--cc=horia.geanta@nxp.com \
--cc=kim.phillips@arm.com \
--cc=linux-crypto@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.