From: Gerd Hoffmann <kraxel@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: "QEMU Trivial" <qemu-trivial@nongnu.org>,
"Alex Bennée" <alex.bennee@linaro.org>,
"Richard Henderson" <richard.henderson@linaro.org>,
qemu-devel@nongnu.org, "Laurent Vivier" <laurent@vivier.eu>,
"Yonggang Luo" <luoyonggang@gmail.com>,
"Philippe Mathieu-Daudé" <philmd@redhat.com>
Subject: Re: [PATCH v6 0/4] Fixes curses on msys2/mingw
Date: Fri, 2 Oct 2020 14:47:44 +0200 [thread overview]
Message-ID: <20201002124744.whdgh4xtmvifi72y@sirius.home.kraxel.org> (raw)
In-Reply-To: <89710921-1d64-14fd-f8ce-05ee58f412c5@redhat.com>
On Thu, Oct 01, 2020 at 07:39:33PM +0200, Paolo Bonzini wrote:
> On 01/10/20 19:32, Yonggang Luo wrote:
> > And also convert related configure script to meson.
> > V5-V6
> > Dropping configure: Fixes ncursesw detection under msys2/mingw by convert the=
> > m to meson first.
> > That need the meson 0.56 upstream to fixes the curses detection.
> > Add
> > * configure: fixes indent of $meson setup
> >
> > Yonggang Luo (4):
> > configure: fixes indent of $meson setup
> > curses: Fixes compiler error that complain don't have langinfo.h on
> > msys2/mingw
> > curses: Fixes curses compiling errors.
> > win32: Simplify gmtime_r detection not depends on if _POSIX_C_SOURCE
> > are defined on msys2/mingw
> >
> > configure | 42 ++++-----------------------------------
> > include/sysemu/os-win32.h | 4 ++--
> > ui/curses.c | 14 ++++++-------
> > util/oslib-win32.c | 4 ++--
> > 4 files changed, 15 insertions(+), 49 deletions(-)
> >
> > --=20
> > 2.28.0.windows.1
> >
> >
>
> Looks good (though there is no conversion to meson yet in this version).
>
> Not trivial, but perhaps Gerd can take it?
Sure, series looks good.
Can't finish this today due to -ENOTIME and I'm offline next week so
this has to wait a bit in the UI patch queue ...
take care,
Gerd
next prev parent reply other threads:[~2020-10-02 12:50 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-01 17:32 [PATCH v6 0/4] Fixes curses on msys2/mingw Yonggang Luo
2020-10-01 17:32 ` [PATCH v6 1/4] configure: fixes indent of $meson setup Yonggang Luo
2020-10-02 15:34 ` Daniel P. Berrangé
2020-10-01 17:32 ` [PATCH v6 2/4] curses: Fixes compiler error that complain don't have langinfo.h on msys2/mingw Yonggang Luo
2020-10-02 15:35 ` Daniel P. Berrangé
2020-10-02 16:38 ` 罗勇刚(Yonggang Luo)
2020-10-02 16:42 ` Daniel P. Berrangé
2020-10-02 17:46 ` Paolo Bonzini
2020-10-02 17:47 ` 罗勇刚(Yonggang Luo)
2020-10-02 17:49 ` Paolo Bonzini
2020-10-02 17:54 ` 罗勇刚(Yonggang Luo)
2020-10-01 17:32 ` [PATCH v6 3/4] curses: Fixes curses compiling errors Yonggang Luo
2020-10-01 17:32 ` [PATCH v6 4/4] win32: Simplify gmtime_r detection not depends on if _POSIX_C_SOURCE are defined on msys2/mingw Yonggang Luo
2020-10-02 15:36 ` Daniel P. Berrangé
2020-10-01 17:39 ` [PATCH v6 0/4] Fixes curses " Paolo Bonzini
2020-10-02 12:47 ` Gerd Hoffmann [this message]
2020-10-02 15:38 ` Daniel P. Berrangé
2020-10-12 6:49 ` Gerd Hoffmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201002124744.whdgh4xtmvifi72y@sirius.home.kraxel.org \
--to=kraxel@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=laurent@vivier.eu \
--cc=luoyonggang@gmail.com \
--cc=pbonzini@redhat.com \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.