From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C042CC4727D for ; Fri, 2 Oct 2020 13:40:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7EB9B20795 for ; Fri, 2 Oct 2020 13:40:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1601646043; bh=yjK6TcIFC7WXaFANQVFI2LqqnRBV+qGWxHefP5P1k28=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=uSRvH/x+o3e1Mjh/cH6p71zp8nNcgeb4ELeXU/8WZ21Di4HyfM+hsXcEGFCgGnI8j y8fJwsF+Xc02xMVPn5D95cl4H5xdHR6oTB2px5w4sxUeG7835f2/4DJrCjMGO52xKv qBVmDmvyMFN4FG3Eb2M7QntZUlSKndEFJFsbrO84= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387983AbgJBNkm (ORCPT ); Fri, 2 Oct 2020 09:40:42 -0400 Received: from mail.kernel.org ([198.145.29.99]:42262 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726282AbgJBNkm (ORCPT ); Fri, 2 Oct 2020 09:40:42 -0400 Received: from localhost (83-86-74-64.cable.dynamic.v4.ziggo.nl [83.86.74.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 754BE206E3; Fri, 2 Oct 2020 13:40:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1601646042; bh=yjK6TcIFC7WXaFANQVFI2LqqnRBV+qGWxHefP5P1k28=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=bEQLbL7il6w6SFWs1Lh7cQmKfz1YUU/mHZU/kIAUWD6g4uHjK/z+lzJtnsHcEfOQ1 fdfhrMbM+lylNr1Q+epNw9pohNlEWEYjR1pTUL6i6GY8rtKXHEmxoxZ1ePmarptrYZ CCSOoaduARDb67RMu3tstCOoDYuNc9N52VkFkuqo= Date: Fri, 2 Oct 2020 15:40:41 +0200 From: Greg Kroah-Hartman To: Badhri Jagan Sridharan Cc: Guenter Roeck , Heikki Krogerus , Rob Herring , Lee Jones , Mark Brown , Maxime Ripard , Alexandre Belloni , Thierry Reding , Prashant Malani , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org Subject: Re: [PATCH v9 02/15] usb: typec: tcpci: Add set_vbus tcpci callback Message-ID: <20201002134041.GA3412330@kroah.com> References: <20200929024004.244992-1-badhri@google.com> <20200929024004.244992-3-badhri@google.com> <20201002133952.GA3411859@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20201002133952.GA3411859@kroah.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Oct 02, 2020 at 03:39:52PM +0200, Greg Kroah-Hartman wrote: > On Mon, Sep 28, 2020 at 07:39:51PM -0700, Badhri Jagan Sridharan wrote: > > set_vbus callback allows TCPC which are TCPCI based, however, > > does not support turning on sink and source mode through > > Command.SinkVbus and Command.SourceVbusDefaultVoltage. > > > > Signed-off-by: Badhri Jagan Sridharan > > Reviewed-by: Heikki Krogerus > > This patch breaks the build, are you sure you tested it? Sorry, not this patch, patch 4: drivers/usb/typec/tcpm/tcpci.c: In function ‘tcpci_register_port’: drivers/usb/typec/tcpm/tcpci.c:630:13: error: ‘struct tcpc_dev’ has no member named ‘enable_frs’ 630 | tcpci->tcpc.enable_frs = tcpci_enable_frs; | ^ thanks, greg k-h