From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 17B20C4363D for ; Fri, 2 Oct 2020 14:06:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BCEC2206FA for ; Fri, 2 Oct 2020 14:06:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1601647578; bh=c4j3rEm69/p/IH6X7L+DozfKN3NnLwrHolhiQzZs2lc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=ZKwc2vT32wo97XpHzF2c3wFv60vT4WynXDWEYQ/4NNq/Fi28fnraddt04Rjppvqtt aivhSaEUyo5zxHLHPVYTcZ6c/R8IB5pcYVTd4ZHek81cFf4QBipMKQXA/ykkfYQ3Sj Uu+1X6TRtVdLaopYWYb098RtQbx3xmm13rmamPTY= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387989AbgJBOGR (ORCPT ); Fri, 2 Oct 2020 10:06:17 -0400 Received: from mail.kernel.org ([198.145.29.99]:49590 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726017AbgJBOGR (ORCPT ); Fri, 2 Oct 2020 10:06:17 -0400 Received: from localhost (83-86-74-64.cable.dynamic.v4.ziggo.nl [83.86.74.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 8ECBB206CD; Fri, 2 Oct 2020 14:06:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1601647576; bh=c4j3rEm69/p/IH6X7L+DozfKN3NnLwrHolhiQzZs2lc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=mqXbkq5l+9HGSlHdk5vLQ5UChn3x/Z2Kg0d/FNzi7lriakUSIaUHW4HAE0WGLfjG5 3Tq7RN+wyZAeupYWxy+wlF5QNLDuo1jP/VPSt/iXHxDv5BGw0lNzys3JUbnQLwRpcS OYb2UswTnW1ZZ3N7EcNk4lVkH0l4daY9DGfgB0E0= Date: Fri, 2 Oct 2020 16:05:49 +0200 From: Greg KH To: Laurentiu Tudor Cc: Diana Craciun , linux-kernel@vger.kernel.org, stuyoder@gmail.com, leoyang.li@nxp.com, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v5 00/13] bus/fsl-mc: Extend mc-bus driver functionalities in preparation for mc-bus VFIO support Message-ID: <20201002140549.GA3492850@kroah.com> References: <20200929085441.17448-1-diana.craciun@oss.nxp.com> <8b3c1222-5dbd-5c51-ac10-8b1c1a69d2d5@nxp.com> <20201002135512.GA3466738@kroah.com> <9e5576fb-6e42-4216-286c-7afb7979ed0b@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <9e5576fb-6e42-4216-286c-7afb7979ed0b@nxp.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Oct 02, 2020 at 04:56:52PM +0300, Laurentiu Tudor wrote: > Hi Greg, > > On 10/2/2020 4:55 PM, Greg KH wrote: > > On Tue, Sep 29, 2020 at 02:06:41PM +0300, Laurentiu Tudor wrote: > >> > >> > >> On 9/29/2020 11:54 AM, Diana Craciun wrote: > >>> The vfio-mc bus driver needs some additional services to be exported by the > >>> mc-bus driver like: > >>> - a way to reset the DPRC container > >>> - driver_override support > >>> - functions to setup/tear down a DPRC > >>> - functions for allocating the pool of interrupts. In case of VFIO the > >>> interrupts are not configured at probe time, but later by userspace > >>> request > >>> > >>> v4 -> v5 > >>> - dprc_celanup should not fail > >>> > >>> v3 -> v4 > >>> - Rebased on the latest kernel. > >>> - Exported a dprc_remove function > >>> > >>> v2 -> v3 > >>> - Add a new version for dprc_get_obj_region > >>> - Export the cacheability bus specific bits defines > >>> > >>> v1 -> v2 > >>> - Remove driver_override propagation through various functions > >>> - Cache the DPRC API version > >>> > >>> The patches are related with "vfio/fsl-mc: VFIO support for FSL-MC > >>> devices" patches, but the series were split because they are targeting > >>> different subsystems. However, the mc-bus patches may suffer changes > >>> when addressing the VFIO review comments. > >>> > >>> The patches do not address the comment regarding moving driver_override > >>> in the core code. I prefer not to tie these patches on that change and > >>> address that separately. > >>> > >>> Bharat Bhushan (3): > >>> bus/fsl-mc: add support for 'driver_override' in the mc-bus > >>> bus/fsl-mc: Add dprc-reset-container support > >>> bus/fsl-mc: Extend ICID size from 16bit to 32bit > >>> > >>> Diana Craciun (10): > >>> bus/fsl-mc: Do no longer export the total number of irqs outside > >>> dprc_scan_objects > >>> bus/fsl-mc: Add a new parameter to dprc_scan_objects function > >>> bus/fsl-mc: Set the QMAN/BMAN region flags > >>> bus/fsl-mc: Cache the DPRC API version > >>> bus/fsl-mc: Export dprc_scan/dprc_remove functions to be used by > >>> multiple entities > >>> bus/fsl-mc: Export a cleanup function for DPRC > >>> bus/fsl-mc: Add a container setup function > >>> bus/fsl_mc: Do not rely on caller to provide non NULL mc_io > >>> bus/fsl-mc: Export IRQ pool handling functions to be used by VFIO > >>> bus/fsl-mc: Add a new version for dprc_get_obj_region command > >>> > >>> drivers/bus/fsl-mc/dprc-driver.c | 190 ++++++++++++++++---------- > >>> drivers/bus/fsl-mc/dprc.c | 141 +++++++++++++++---- > >>> drivers/bus/fsl-mc/fsl-mc-allocator.c | 12 +- > >>> drivers/bus/fsl-mc/fsl-mc-bus.c | 64 ++++++++- > >>> drivers/bus/fsl-mc/fsl-mc-private.h | 31 ++--- > >>> drivers/bus/fsl-mc/mc-io.c | 7 +- > >>> include/linux/fsl/mc.h | 41 +++++- > >>> 7 files changed, 359 insertions(+), 127 deletions(-) > >>> > >> > >> For the series: > >> Reviewed-by: Laurentiu Tudor > >> Acked-by: Laurentiu Tudor > > > > Do you want me to take these patches in my tree, or are they going to > > Linus some other way? > > I'm prefectly fine with you picking up the patches through your tree. Great, now queued up. greg k-h From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 12567C4363D for ; Fri, 2 Oct 2020 14:07:42 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 99751206DB for ; Fri, 2 Oct 2020 14:07:41 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="iCEvkPmG"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="mqXbkq5l" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 99751206DB Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=h7Ov9eBrf5V7wEVVnh99grJYS+h7fBYKo8hsHy0BbIg=; b=iCEvkPmG/aEv/F2cGrlNXiVKX 1eMcSa0jNW37tHTswFeGQb5lRuPEtn2DQngJtgeX6g8yBKrmKd1MDQvhKnFcyvqotDtEpC/DVZ2+h rfvUn2exU1SUIRGSclV72N6/FXZNGwWJ2iifXFf8/A7rNXeMESbNGqHrYhIgVNYLdz6zerqe/+ohw RrRxxu/1PcyE7rW2JwLSGzXa5VkSiFFqYO1aC1PBgI0+aGL73DkPB4fr28T0rkx+UDLH23sslFgdZ 4EAaTC7naV+VSadiPe9bL3wVn2nbCvoljU2mEm759TT6WuJ+IwDHUUBeAk5r/Ftjgvg+FWHy8wsFk kLUvSLBWw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kOLhU-0005wZ-J9; Fri, 02 Oct 2020 14:06:20 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kOLhR-0005w3-BE for linux-arm-kernel@lists.infradead.org; Fri, 02 Oct 2020 14:06:18 +0000 Received: from localhost (83-86-74-64.cable.dynamic.v4.ziggo.nl [83.86.74.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 8ECBB206CD; Fri, 2 Oct 2020 14:06:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1601647576; bh=c4j3rEm69/p/IH6X7L+DozfKN3NnLwrHolhiQzZs2lc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=mqXbkq5l+9HGSlHdk5vLQ5UChn3x/Z2Kg0d/FNzi7lriakUSIaUHW4HAE0WGLfjG5 3Tq7RN+wyZAeupYWxy+wlF5QNLDuo1jP/VPSt/iXHxDv5BGw0lNzys3JUbnQLwRpcS OYb2UswTnW1ZZ3N7EcNk4lVkH0l4daY9DGfgB0E0= Date: Fri, 2 Oct 2020 16:05:49 +0200 From: Greg KH To: Laurentiu Tudor Subject: Re: [PATCH v5 00/13] bus/fsl-mc: Extend mc-bus driver functionalities in preparation for mc-bus VFIO support Message-ID: <20201002140549.GA3492850@kroah.com> References: <20200929085441.17448-1-diana.craciun@oss.nxp.com> <8b3c1222-5dbd-5c51-ac10-8b1c1a69d2d5@nxp.com> <20201002135512.GA3466738@kroah.com> <9e5576fb-6e42-4216-286c-7afb7979ed0b@nxp.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <9e5576fb-6e42-4216-286c-7afb7979ed0b@nxp.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201002_100617_557186_6A5D7873 X-CRM114-Status: GOOD ( 28.43 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-arm-kernel@lists.infradead.org, leoyang.li@nxp.com, linux-kernel@vger.kernel.org, stuyoder@gmail.com, Diana Craciun Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Oct 02, 2020 at 04:56:52PM +0300, Laurentiu Tudor wrote: > Hi Greg, > > On 10/2/2020 4:55 PM, Greg KH wrote: > > On Tue, Sep 29, 2020 at 02:06:41PM +0300, Laurentiu Tudor wrote: > >> > >> > >> On 9/29/2020 11:54 AM, Diana Craciun wrote: > >>> The vfio-mc bus driver needs some additional services to be exported by the > >>> mc-bus driver like: > >>> - a way to reset the DPRC container > >>> - driver_override support > >>> - functions to setup/tear down a DPRC > >>> - functions for allocating the pool of interrupts. In case of VFIO the > >>> interrupts are not configured at probe time, but later by userspace > >>> request > >>> > >>> v4 -> v5 > >>> - dprc_celanup should not fail > >>> > >>> v3 -> v4 > >>> - Rebased on the latest kernel. > >>> - Exported a dprc_remove function > >>> > >>> v2 -> v3 > >>> - Add a new version for dprc_get_obj_region > >>> - Export the cacheability bus specific bits defines > >>> > >>> v1 -> v2 > >>> - Remove driver_override propagation through various functions > >>> - Cache the DPRC API version > >>> > >>> The patches are related with "vfio/fsl-mc: VFIO support for FSL-MC > >>> devices" patches, but the series were split because they are targeting > >>> different subsystems. However, the mc-bus patches may suffer changes > >>> when addressing the VFIO review comments. > >>> > >>> The patches do not address the comment regarding moving driver_override > >>> in the core code. I prefer not to tie these patches on that change and > >>> address that separately. > >>> > >>> Bharat Bhushan (3): > >>> bus/fsl-mc: add support for 'driver_override' in the mc-bus > >>> bus/fsl-mc: Add dprc-reset-container support > >>> bus/fsl-mc: Extend ICID size from 16bit to 32bit > >>> > >>> Diana Craciun (10): > >>> bus/fsl-mc: Do no longer export the total number of irqs outside > >>> dprc_scan_objects > >>> bus/fsl-mc: Add a new parameter to dprc_scan_objects function > >>> bus/fsl-mc: Set the QMAN/BMAN region flags > >>> bus/fsl-mc: Cache the DPRC API version > >>> bus/fsl-mc: Export dprc_scan/dprc_remove functions to be used by > >>> multiple entities > >>> bus/fsl-mc: Export a cleanup function for DPRC > >>> bus/fsl-mc: Add a container setup function > >>> bus/fsl_mc: Do not rely on caller to provide non NULL mc_io > >>> bus/fsl-mc: Export IRQ pool handling functions to be used by VFIO > >>> bus/fsl-mc: Add a new version for dprc_get_obj_region command > >>> > >>> drivers/bus/fsl-mc/dprc-driver.c | 190 ++++++++++++++++---------- > >>> drivers/bus/fsl-mc/dprc.c | 141 +++++++++++++++---- > >>> drivers/bus/fsl-mc/fsl-mc-allocator.c | 12 +- > >>> drivers/bus/fsl-mc/fsl-mc-bus.c | 64 ++++++++- > >>> drivers/bus/fsl-mc/fsl-mc-private.h | 31 ++--- > >>> drivers/bus/fsl-mc/mc-io.c | 7 +- > >>> include/linux/fsl/mc.h | 41 +++++- > >>> 7 files changed, 359 insertions(+), 127 deletions(-) > >>> > >> > >> For the series: > >> Reviewed-by: Laurentiu Tudor > >> Acked-by: Laurentiu Tudor > > > > Do you want me to take these patches in my tree, or are they going to > > Linus some other way? > > I'm prefectly fine with you picking up the patches through your tree. Great, now queued up. greg k-h _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel