From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_GIT autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3FCB8C35257 for ; Fri, 2 Oct 2020 15:24:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 135E6206DC for ; Fri, 2 Oct 2020 15:24:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388296AbgJBPYn (ORCPT ); Fri, 2 Oct 2020 11:24:43 -0400 Received: from mailout06.rmx.de ([94.199.90.92]:38542 "EHLO mailout06.rmx.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726017AbgJBPYn (ORCPT ); Fri, 2 Oct 2020 11:24:43 -0400 Received: from kdin02.retarus.com (kdin02.dmz1.retloc [172.19.17.49]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mailout06.rmx.de (Postfix) with ESMTPS id 4C2v1N4XFpz9w9H; Fri, 2 Oct 2020 17:24:40 +0200 (CEST) Received: from mta.arri.de (unknown [217.111.95.66]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by kdin02.retarus.com (Postfix) with ESMTPS id 4C2v1005yYz2TSBc; Fri, 2 Oct 2020 17:24:20 +0200 (CEST) Received: from N95HX1G2.wgnetz.xx (192.168.54.33) by mta.arri.de (192.168.100.104) with Microsoft SMTP Server (TLS) id 14.3.408.0; Fri, 2 Oct 2020 17:23:57 +0200 From: Christian Eggers To: Oleksij Rempel , Shawn Guo , Sascha Hauer , Fabio Estevam , =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= CC: Pengutronix Kernel Team , NXP Linux Team , , , Subject: [PATCH v2 0/3] i2c: imx: Fix handling of arbitration loss Date: Fri, 2 Oct 2020 17:23:02 +0200 Message-ID: <20201002152305.4963-1-ceggers@arri.de> X-Mailer: git-send-email 2.26.2 MIME-Version: 1.0 Content-Transfer-Encoding: 7BIT Content-Type: text/plain; charset=US-ASCII X-Originating-IP: [192.168.54.33] X-RMX-ID: 20201002-172422-4C2v1005yYz2TSBc-0@kdin02 X-RMX-SOURCE: 217.111.95.66 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Changes in v2: --------------- - Don't accidently clear additional status flags on Vybrid (reported by Uwe Kleine-Koenig) On my (noisy) system, I2C arbitration losses happen quite often. In it's current implementation, the IAL flag is partly handled, but has a number of shortcomings: 1. The driver runs unnecessarily in a timeout when waiting for an interrupt. 2. The driver performs 500 ms busy-waiting without any value. 3. Arbitration loss errors may be reported one transfer later than they occured. Best regards Christian From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8D6D5C46466 for ; Fri, 2 Oct 2020 15:26:00 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 48E19206DC for ; Fri, 2 Oct 2020 15:26:00 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="De+RoOjr" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 48E19206DC Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arri.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:Subject:To:From: Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender :Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Owner; bh=wJZKg236hYcHJc79CYPGBerRszrTHoNgkE3+PLowhbw=; b=De+RoOjrMmIRZSap1pFB+ybj+o 7WR8jaH5lp/fkKCLl9TH4mt3m+//OxAs3XT1Qb5/YHjttZD2p80d9QpiQPyMcPwsHCuold7jOOA8l RLcl0XduLNLLEVhYToywqZNKBb1IJQ/NBLkKRxuYdQAKQAwkSx8ZEdQEU44bXsHnt4O4QbFfvihaF OS7lxIYxAkC/TVS6DXiA+OW9sTYzzx1/BvGVbbSGHGPSBe40deMYB897aeU+RRJ7BGyISOzEoFwLJ bTAWqqDN+9wKySX1KHd2b7g4G//+m9MnWCKQALLpuVRk4nZq2uj9X244FrZTIEG+pjn3g7DpypjAk 2HwOq75g==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kOMvR-0002TW-Jv; Fri, 02 Oct 2020 15:24:49 +0000 Received: from mailout06.rmx.de ([94.199.90.92]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kOMvO-0002ST-HS for linux-arm-kernel@lists.infradead.org; Fri, 02 Oct 2020 15:24:47 +0000 Received: from kdin02.retarus.com (kdin02.dmz1.retloc [172.19.17.49]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mailout06.rmx.de (Postfix) with ESMTPS id 4C2v1N4XFpz9w9H; Fri, 2 Oct 2020 17:24:40 +0200 (CEST) Received: from mta.arri.de (unknown [217.111.95.66]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by kdin02.retarus.com (Postfix) with ESMTPS id 4C2v1005yYz2TSBc; Fri, 2 Oct 2020 17:24:20 +0200 (CEST) Received: from N95HX1G2.wgnetz.xx (192.168.54.33) by mta.arri.de (192.168.100.104) with Microsoft SMTP Server (TLS) id 14.3.408.0; Fri, 2 Oct 2020 17:23:57 +0200 From: Christian Eggers To: Oleksij Rempel , Shawn Guo , Sascha Hauer , Fabio Estevam , =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= Subject: [PATCH v2 0/3] i2c: imx: Fix handling of arbitration loss Date: Fri, 2 Oct 2020 17:23:02 +0200 Message-ID: <20201002152305.4963-1-ceggers@arri.de> X-Mailer: git-send-email 2.26.2 MIME-Version: 1.0 X-Originating-IP: [192.168.54.33] X-RMX-ID: 20201002-172422-4C2v1005yYz2TSBc-0@kdin02 X-RMX-SOURCE: 217.111.95.66 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201002_112446_684415_2ABD9DCD X-CRM114-Status: UNSURE ( 9.58 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, NXP Linux Team , Pengutronix Kernel Team , linux-i2c@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Changes in v2: --------------- - Don't accidently clear additional status flags on Vybrid (reported by Uwe Kleine-Koenig) On my (noisy) system, I2C arbitration losses happen quite often. In it's current implementation, the IAL flag is partly handled, but has a number of shortcomings: 1. The driver runs unnecessarily in a timeout when waiting for an interrupt. 2. The driver performs 500 ms busy-waiting without any value. 3. Arbitration loss errors may be reported one transfer later than they occured. Best regards Christian _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel