Hi Mike, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on char-misc/char-misc-testing] [also build test WARNING on tip/master v5.9-rc7 next-20201001] [cannot apply to tip/x86/core] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Mike-Travis/x86-platform-uv-Updates-for-UV5-Architecture/20201002-085248 base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/char-misc.git 4cb1a880e7f774e59c2ebb68187d4811ad9d0c4e config: x86_64-rhel (attached as .config) compiler: gcc-9 (Debian 9.3.0-15) 9.3.0 reproduce (this is a W=1 build): # https://github.com/0day-ci/linux/commit/cc7436be5847f8bedccc6e397f23967799046c1b git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Mike-Travis/x86-platform-uv-Updates-for-UV5-Architecture/20201002-085248 git checkout cc7436be5847f8bedccc6e397f23967799046c1b # save the attached .config to linux build tree make W=1 ARCH=x86_64 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot All warnings (new ones prefixed by >>): arch/x86/kernel/apic/x2apic_uv_x.c: In function 'uv_set_system_type': arch/x86/kernel/apic/x2apic_uv_x.c:366:6: warning: variable 'pnodeid' set but not used [-Wunused-but-set-variable] 366 | int pnodeid; | ^~~~~~~ arch/x86/kernel/apic/x2apic_uv_x.c: In function 'uv_init_hub_info': arch/x86/kernel/apic/x2apic_uv_x.c:1150:22: warning: variable 'node_id' set but not used [-Wunused-but-set-variable] 1150 | union uvh_node_id_u node_id; | ^~~~~~~ In function 'uv_stringify', inlined from 'decode_arch_type' at arch/x86/kernel/apic/x2apic_uv_x.c:315:3, inlined from 'early_get_arch_type' at arch/x86/kernel/apic/x2apic_uv_x.c:359:8, inlined from 'uv_set_system_type' at arch/x86/kernel/apic/x2apic_uv_x.c:372:7, inlined from 'uv_acpi_madt_oem_check' at arch/x86/kernel/apic/x2apic_uv_x.c:456:6: >> arch/x86/kernel/apic/x2apic_uv_x.c:287:2: warning: 'strncpy' output may be truncated copying 7 bytes from a string of length 7 [-Wstringop-truncation] 287 | strncpy(to, from, len-1); | ^~~~~~~~~~~~~~~~~~~~~~~~ vim +/strncpy +287 arch/x86/kernel/apic/x2apic_uv_x.c c8f730b1ab825f0 Russ Anderson 2010-10-26 283 61e5ddca9c2a312 Mike Travis 2019-09-10 284 static void __init uv_stringify(int len, char *to, char *from) 61e5ddca9c2a312 Mike Travis 2019-09-10 285 { 61e5ddca9c2a312 Mike Travis 2019-09-10 286 /* Relies on 'to' being NULL chars so result will be NULL terminated */ 61e5ddca9c2a312 Mike Travis 2019-09-10 @287 strncpy(to, from, len-1); 61e5ddca9c2a312 Mike Travis 2019-09-10 288 } 61e5ddca9c2a312 Mike Travis 2019-09-10 289 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org