All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: manjunath.b.patil@oracle.com
Cc: santosh.shilimkar@oracle.com, netdev@vger.kernel.org,
	linux-rdma@vger.kernel.org, aruna.ramakrishna@oracle.com,
	rama.nichanamatlu@oracle.com
Subject: Re: [PATCH 1/1] net/rds: suppress page allocation failure error in recv buffer refill
Date: Sat, 03 Oct 2020 17:26:47 -0700 (PDT)	[thread overview]
Message-ID: <20201003.172647.2111926819782777286.davem@davemloft.net> (raw)
In-Reply-To: <1601669145-13604-1-git-send-email-manjunath.b.patil@oracle.com>

From: Manjunath Patil <manjunath.b.patil@oracle.com>
Date: Fri,  2 Oct 2020 13:05:45 -0700

> RDS/IB tries to refill the recv buffer in softirq context using
> GFP_NOWAIT flag. However alloc failure is handled by queueing a work to
> refill the recv buffer with GFP_KERNEL flag. This means failure to
> allocate with GFP_NOWAIT isn't fatal. Do not print the PAF warnings if
> softirq context fails to refill the recv buffer, instead print rate
> limited warnings.
> 
> Signed-off-by: Manjunath Patil <manjunath.b.patil@oracle.com>
> Reviewed-by: Aruna Ramakrishna <aruna.ramakrishna@oracle.com>

Honestly I don't think the subsystem should print any warning at all.

Either it's a softirq failure, and that's ok because you will push
the allocation to GFP_KERNEL via a work job.  Or it's a GFP_KERNEL
failure in non-softirq context and the kernel will print a warning
and a stack backtrace from the memory allocator.

Therefore, please remove all of the warnings in the rds code.

Thanks.

  parent reply	other threads:[~2020-10-04  0:26 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-02 20:05 [PATCH 1/1] net/rds: suppress page allocation failure error in recv buffer refill Manjunath Patil
2020-10-02 20:10 ` santosh.shilimkar
2020-10-02 20:23   ` Manjunath Patil
2020-10-04  0:26 ` David Miller [this message]
2020-10-05 21:39   ` Manjunath Patil
  -- strict thread matches above, loose matches on Subject: below --
2020-09-16 19:08 Manjunath Patil
2020-09-16 19:27 ` santosh.shilimkar
2020-09-16 21:15   ` Manjunath Patil
2020-09-16 21:25     ` santosh.shilimkar
2020-09-16 21:35       ` Manjunath Patil

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201003.172647.2111926819782777286.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=aruna.ramakrishna@oracle.com \
    --cc=linux-rdma@vger.kernel.org \
    --cc=manjunath.b.patil@oracle.com \
    --cc=netdev@vger.kernel.org \
    --cc=rama.nichanamatlu@oracle.com \
    --cc=santosh.shilimkar@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.