From: David Miller <davem at davemloft.net>
To: mptcp at lists.01.org
Subject: [MPTCP] Re: [PATCH net-next] mptcp: ADD_ADDRs with echo bit are smaller
Date: Sat, 03 Oct 2020 17:36:48 -0700 [thread overview]
Message-ID: <20201003.173648.767792137065746549.davem@davemloft.net> (raw)
In-Reply-To: 20201003153656.1224144-1-matthieu.baerts@tessares.net
[-- Attachment #1: Type: text/plain, Size: 798 bytes --]
From: Matthieu Baerts <matthieu.baerts(a)tessares.net>
Date: Sat, 3 Oct 2020 17:36:56 +0200
> The MPTCP ADD_ADDR suboption with echo-flag=1 has no HMAC, the size is
> smaller than the one initially sent without echo-flag=1. We then need to
> use the correct size everywhere when we need this echo bit.
>
> Before this patch, the wrong size was reserved but the correct amount of
> bytes were written (and read): the remaining bytes contained garbage.
>
> Fixes: 6a6c05a8b016 ("mptcp: send out ADD_ADDR with echo flag")
> Closes: https://github.com/multipath-tcp/mptcp_net-next/issues/95
> Reported-and-tested-by: Davide Caratti <dcaratti(a)redhat.com>
> Acked-by: Geliang Tang <geliangtang(a)gmail.com>
> Signed-off-by: Matthieu Baerts <matthieu.baerts(a)tessares.net>
Applied.
WARNING: multiple messages have this Message-ID (diff)
From: David Miller <davem@davemloft.net>
To: matthieu.baerts@tessares.net
Cc: mathew.j.martineau@linux.intel.com, kuba@kernel.org,
geliangtang@gmail.com, dcaratti@redhat.com,
netdev@vger.kernel.org, mptcp@lists.01.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next] mptcp: ADD_ADDRs with echo bit are smaller
Date: Sat, 03 Oct 2020 17:36:48 -0700 (PDT) [thread overview]
Message-ID: <20201003.173648.767792137065746549.davem@davemloft.net> (raw)
In-Reply-To: <20201003153656.1224144-1-matthieu.baerts@tessares.net>
From: Matthieu Baerts <matthieu.baerts@tessares.net>
Date: Sat, 3 Oct 2020 17:36:56 +0200
> The MPTCP ADD_ADDR suboption with echo-flag=1 has no HMAC, the size is
> smaller than the one initially sent without echo-flag=1. We then need to
> use the correct size everywhere when we need this echo bit.
>
> Before this patch, the wrong size was reserved but the correct amount of
> bytes were written (and read): the remaining bytes contained garbage.
>
> Fixes: 6a6c05a8b016 ("mptcp: send out ADD_ADDR with echo flag")
> Closes: https://github.com/multipath-tcp/mptcp_net-next/issues/95
> Reported-and-tested-by: Davide Caratti <dcaratti@redhat.com>
> Acked-by: Geliang Tang <geliangtang@gmail.com>
> Signed-off-by: Matthieu Baerts <matthieu.baerts@tessares.net>
Applied.
next reply other threads:[~2020-10-04 0:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-04 0:36 David Miller [this message]
2020-10-04 0:36 ` [PATCH net-next] mptcp: ADD_ADDRs with echo bit are smaller David Miller
-- strict thread matches above, loose matches on Subject: below --
2020-10-03 15:36 [MPTCP] " Matthieu Baerts
2020-10-03 15:36 ` Matthieu Baerts
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201003.173648.767792137065746549.davem@davemloft.net \
--to=unknown@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.